[jdk11u] RFR: 8348760: RadioButton is not shown if JRadioButtonMenuItem is rendered with ImageIcon in WindowsLookAndFeel [v4]

Andrew John Hughes andrew at openjdk.org
Wed Sep 24 15:31:47 UTC 2025


On Tue, 23 Sep 2025 15:23:40 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

>> Antonio Vieiro has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Keep import wildcards in 11. Removed propertyChangeListener & doc.
>
> `WindowsCheckBoxMenuItemUI.java` still has a host of import changes that don't seem necessary:
> 
> ~~~
> -import java.awt.*;
> -import javax.swing.*;
> -import javax.swing.plaf.*;
> -import javax.swing.plaf.basic.*;
> +import java.awt.Color;
> +import java.awt.Graphics;
> +import java.awt.Rectangle;
> +
> +import javax.swing.ButtonModel;
> +import javax.swing.Icon;
> +import javax.swing.JComponent;
> +import javax.swing.JMenuItem;
> +import javax.swing.plaf.ComponentUI;
> +import javax.swing.plaf.basic.BasicCheckBoxMenuItemUI;
> ~~~
> 
> The 17u patch just adds `javax.swing.Icon`, which shouldn't be needed with the existing wildcard.
> ~~~

> Thanks for the review, @gnu-andrew ,
> 
> I removed the explicit imports and restored the wildcards in `WindowsCheckBoxMenuItemUI.java`
> 

Thanks, I'll do a fresh look in a moment.

> We can do this in `BasicMenuItemUI.java` too, let me know if you want me to do that in all files.

I didn't notice an issue with this file, but will double-check. Thanks for the update.

-------------

PR Comment: https://git.openjdk.org/jdk11u/pull/104#issuecomment-3329424968


More information about the jdk-updates-dev mailing list