[jdk11u] RFR: 8348760: RadioButton is not shown if JRadioButtonMenuItem is rendered with ImageIcon in WindowsLookAndFeel [v4]

Andrew John Hughes andrew at openjdk.org
Wed Sep 24 17:10:29 UTC 2025


On Wed, 24 Sep 2025 15:29:15 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> > We can do this in `BasicMenuItemUI.java` too, let me know if you want me to do that in all files.
> 
> I didn't notice an issue with this file, but will double-check. Thanks for the update.

I double-checked this and the import changes there were introduced in the original 8348760, so to remove them would be to deviate from the original fix. For clarity, my concern with these `import` changes was not that they were wrong, but that they were a deviation from the change being backported. We try to keep backports as close to the original as possible. Changes beyond what those which are essential to make the backport work should be done in other backports or possibly even fixed in trunk first and backported.

In this case, the `import` changes were added in OpenJDK 16 as part of [JDK-8256014](https://bugs.openjdk.org/browse/JDK-8256014), a change unsuitable for backporting. If you do wish to bring these import changes to 8u & 11u to simplify other backports, I'd be open to this as a separate 8u & 11u bug which brings in the import changes but not the doc changes from 8256014. However, I don't see a real need for this. In this case, the wildcards in 11u have actually resulted in removing the need to alter the `import` statements in some places where it was needed in 17+.

-------------

PR Comment: https://git.openjdk.org/jdk11u/pull/104#issuecomment-3329897276


More information about the jdk-updates-dev mailing list