[jdk17u-dev] RFR: 8348986: Improve coverage of enhanced exception messages [v2]

[Alexey Bakhtin]

On Mon, 29 Sep 2025 13:26:54 GMT, Sergey Chernyshev <schernyshev at openjdk.org> wrote:

>> Alexey Bakhtin has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Fix review findings
>>  - Add accessClassInPackage.jdk.internal.util permission for java.net.http module
>
> src/java.base/share/classes/module-info.java line 345:
> 
>> 343:         jdk.crypto.ec,
>> 344:         jdk.crypto.cryptoki,
>> 345:         jdk.httpserver,
> 
> This change must be for jdk.internal.util

Thank you. Moved

> src/java.base/share/classes/sun/net/util/SocketExceptions.java line 1:
> 
>> 1: /*
> 
> SocketExceptions becomes an empty file

Thank you. Removed

> src/java.base/share/classes/sun/net/www/protocol/jmod/Handler.java line 2:
> 
>> 1: /*
>> 2:  * Copyright (c) 2025, Oracle and/or its affiliates. All rights reserved.
> 
> Only the copyright header changed

Thank you. Fixed

> src/java.base/share/classes/sun/nio/ch/SocketChannelImpl.java line 879:
> 
>> 877:             // connect failed, close the channel
>> 878:             close();
>> 879:             throw Exceptions.ioException(ioe, sa);
> 
> A similar change is needed also in `AbstractPlainSocketImpl.java`

Yes. Thank you. Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/3989#discussion_r2389545982
PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/3989#discussion_r2389545830
PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/3989#discussion_r2389546678
PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/3989#discussion_r2389668144