[jdk11u-dev] RFR: 8298730: Refactor subsystem_file_line_contents and add docs and tests [v2]

[Severin Gehwolf]

On Thu, 12 Feb 2026 13:56:13 GMT, Jonathan Dowland <jdowland at openjdk.org> wrote:

>> Not clean, adjustments necessary to adapt for pre-C++-11, and a small change to account for lack of JEP 371.
>
> Jonathan Dowland has updated the pull request incrementally with one additional commit since the last revision:
> 
>   different approach for initializing _is_frozen
>   
>   G++ does not like a trailing ',' in the member initialiser list,
>   which occurs for non-debug builds when expanding DEBUG_ONLY.
>   
>   Move the initialisation of _is_fixed into the constructor
>   definitions.
>   
>   Signed-off-by: Jonathan Dowland <jdowland at redhat.com>

Changes requested by sgehwolf (Reviewer).

src/hotspot/share/utilities/ostream.hpp line 231:

> 229:   };
> 230:   void  reset();
> 231:   // Copy to a resource, or C-heap, array as requested

This comment seems misleading in JDK 11u. I'd leave it out.

test/hotspot/gtest/os/linux/test_cgroupSubsystem_linux.cpp line 49:

> 47:   path.print("%s-test-jdk.pid%d.%s.%s", prefix, os::current_process_id(),
> 48:              test_info->test_case_name(), test_info->name());
> 49:   return path.as_string();

This should fix the test failure.

Suggestion:

  return os::strdup(path.freeze());

-------------

PR Review: https://git.openjdk.org/jdk11u-dev/pull/3149#pullrequestreview-3815365703
PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/3149#discussion_r2818317595
PR Review Comment: https://git.openjdk.org/jdk11u-dev/pull/3149#discussion_r2818254870