[jdk21u-dev] RFR: 8367772: Refactor createUI in PassFailJFrame
Roland Mesde
duke at openjdk.org
Mon Feb 23 17:21:46 UTC 2026
Backporting 8367772: Refactor createUI in PassFailJFrame.
This PR refactors PassFailJFrame UI creation to use Builder pattern internally, eliminating parameter proliferation and code duplication.
For parity with Oracle JDK. Already backported to 25.
Ran a manual test that uses the PassFailJFrame on macos-aarch64:
~/github/jtreg/build/images/jtreg/bin/jtreg -jdk build/macosx-aarch64-server-release/images/jdk -m test/jdk/java/awt/Dialog/ModalDialogTest/ModalDialogTest.java
ScreenShots:
<img width="1416" height="508" alt="Step1" src="https://github.com/user-attachments/assets/9d1e6eb6-242f-428e-84a0-e2350284ba59" />
<img width="1425" height="641" alt="Step2" src="https://github.com/user-attachments/assets/d19d338f-cb2c-4b98-8dc1-d1988cada043" />
<img width="1404" height="848" alt="Step3" src="https://github.com/user-attachments/assets/7708ca9b-78f4-487e-b932-b2969b5168f1" />
Results:
[ModalDialogTest-Success.jtr.txt](https://github.com/user-attachments/files/25496112/ModalDialogTest-Success.jtr.txt)
-------------
Commit messages:
- Backport d278043ddba0cd9ec3ddf8b490366965f5831a22
Changes: https://git.openjdk.org/jdk21u-dev/pull/2628/files
Webrev: https://webrevs.openjdk.org/?repo=jdk21u-dev&pr=2628&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8367772
Stats: 55 lines in 1 file changed: 8 ins; 33 del; 14 mod
Patch: https://git.openjdk.org/jdk21u-dev/pull/2628.diff
Fetch: git fetch https://git.openjdk.org/jdk21u-dev.git pull/2628/head:pull/2628
PR: https://git.openjdk.org/jdk21u-dev/pull/2628
More information about the jdk-updates-dev
mailing list