[jdk17u-dev] RFR: 8328608: Multiple NewSessionTicket support for TLS
Ralf Schmelter
rschmelter at openjdk.org
Thu Feb 26 11:46:16 UTC 2026
On Tue, 24 Feb 2026 07:30:05 GMT, Goetz Lindenmaier <goetz at openjdk.org> wrote:
> src/java.base/share/classes/sun/security/ssl/NewSessionTicket.java
> Trivial resolve.
>
> src/java.base/share/classes/sun/security/ssl/SSLConfiguration.java
> Copyright
>
> src/java.base/share/classes/sun/security/util/Cache.java
> Some larger but trivial resolves.
>
> To make it compile I had to add some imports and remove an unsupported switch espression, see extra commit.
>
> The third commit contains the changes needed to make the tests work. Here especially the change to [CertMsgCheck.java](https://github.com/openjdk/jdk17u-dev/pull/4276/changes/ab79bf619937002f78a476d7548a298abd86cf50#diff-ebde63cf18c95b63a577d9b9f75983d20dae417ace1f2258d6dfcca7fe2d1321), without adding the arbitrary import, jtreg did not compile TLSBase.java.
Looks good apart from the one remark.
src/java.base/share/classes/sun/security/util/Cache.java line 433:
> 431: } else {
> 432: CacheEntry<K, V> entry = cacheMap.get(key);
> 433: if (entry != null && entry instanceof QueueCacheEntry<K, V>) {
No need to check for != null, since instanceof would fail if entry is null anyway.
-------------
Changes requested by rschmelter (Reviewer).
PR Review: https://git.openjdk.org/jdk17u-dev/pull/4276#pullrequestreview-3859983160
PR Review Comment: https://git.openjdk.org/jdk17u-dev/pull/4276#discussion_r2858215747
More information about the jdk-updates-dev
mailing list