[jdk25u-dev] RFR: 8373714: Shenandoah: Register heuristic penalties following a degenerated GC

[Aleksey Shipilev]

On Thu, 22 Jan 2026 17:16:04 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:

>> src/hotspot/share/gc/shenandoah/heuristics/shenandoahAdaptiveHeuristics.hpp line 79:
>> 
>>> 77:   virtual void record_success_concurrent() override;
>>> 78:   virtual void record_degenerated() override;
>>> 79:   virtual void record_success_full() override;
>> 
>> So adding `virtual` in this hunk is what makes the backport unclean? Do you need to do it here?
>
> I can remove virtual and override from these declarations and the code still compiles on Linux with gcc 10.5.0.
> 
> My recollection is that certain other compilers (e.g. MacOS and/or Windows) are less forgiving, which is what motivated these changes in the original PR.
> 
> The GHA testing for backports is not as thorough as the GHA for changes to master.

Yes, prefer clean backports. 

I think you need to go to https://github.com/kdnilsen/jdk25u-dev/actions and enable GHA for your personal fork to get the GHA run.

-------------

PR Review Comment: https://git.openjdk.org/jdk25u-dev/pull/162#discussion_r2717861589