<div dir="ltr"><div>Hi Christopher,</div><div><br></div><div>I'm not familiar with the CSR process, do you have some pointers ?<br></div><div>Thanks in advance<br></div><div><br></div><div><div><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div>-- Brice</div></div></div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Oct 11, 2022 at 10:42 AM Langer, Christoph <<a href="mailto:christoph.langer@sap.com">christoph.langer@sap.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="msg3729029485221023792">
<div style="overflow-wrap: break-word;">
<div class="m_3729029485221023792WordSection1">
<p class="MsoNormal"><span lang="EN-US">Hi Brice,<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US"><u></u> <u></u></span></p>
<p class="MsoNormal"><span lang="EN-US">sounds good. For the javadoc change we might think about going through the CSR process to be on the safe side (although the original change doesn’t have a CSR attached). But in my opinion
the javadoc change is worthwhile doing, too.<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US"><u></u> <u></u></span></p>
<p class="MsoNormal"><span lang="EN-US">Cheers<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-US">Christoph<u></u><u></u></span></p>
<p class="MsoNormal"><span><u></u> <u></u></span></p>
<div style="border-color:currentcolor currentcolor currentcolor blue;border-style:none none none solid;border-width:medium medium medium 1.5pt;padding:0cm 0cm 0cm 4pt">
<div>
<div style="border-color:rgb(225,225,225) currentcolor currentcolor;border-style:solid none none;border-width:1pt medium medium;padding:3pt 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US">From:</span></b><span lang="EN-US"> Brice Dutheil <<a href="mailto:brice.dutheil@gmail.com" target="_blank">brice.dutheil@gmail.com</a>>
<br>
<b>Sent:</b> Dienstag, 11. Oktober 2022 10:39<br>
<b>To:</b> Langer, Christoph <<a href="mailto:christoph.langer@sap.com" target="_blank">christoph.langer@sap.com</a>><br>
<b>Cc:</b> <a href="mailto:jdk-updates-dev@openjdk.org" target="_blank">jdk-updates-dev@openjdk.org</a><br>
<b>Subject:</b> Re: Backporting JDK-8217264 on JDK11u<u></u><u></u></span></p>
</div>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
<table style="width:100%" width="100%" cellspacing="0" cellpadding="0" border="0" align="left">
<tbody>
<tr>
<td style="background:rgb(166,166,166);padding:5.25pt 1.5pt"></td>
<td style="width:100%;background:rgb(234,234,234);padding:5.25pt 3.75pt 5.25pt 11.25pt" width="100%">
<div>
<p class="MsoNormal">
<span style="font-size:9pt;font-family:"Segoe UI",sans-serif;color:rgb(33,33,33)">You don't often get email from
<a href="mailto:brice.dutheil@gmail.com" target="_blank">brice.dutheil@gmail.com</a>. <a href="https://aka.ms/LearnAboutSenderIdentification" target="_blank">
Learn why this is important</a><u></u><u></u></span></p>
</div>
</td>
<td style="width:56.25pt;background:rgb(234,234,234);padding:5.25pt 3.75pt" width="75">
</td>
</tr>
</tbody>
</table>
<div>
<div>
<div>
<p class="MsoNormal">Hi Chrstopher,<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Thank you for the feedback.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">I will go ahead with maybe two PR: one for the javadoc and one for the deadlock prevention fix.<u></u><u></u></p>
</div>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<div>
<p class="MsoNormal">On Mon 10 Oct 2022 at 18:07 Langer, Christoph <<a href="mailto:christoph.langer@sap.com" target="_blank">christoph.langer@sap.com</a>> wrote:<u></u><u></u></p>
</div>
<blockquote style="border-color:currentcolor currentcolor currentcolor rgb(204,204,204);border-style:none none none solid;border-width:medium medium medium 1pt;padding:0cm 0cm 0cm 6pt;margin-left:4.8pt;margin-right:0cm">
<div>
<div>
<p class="MsoNormal"><span lang="EN-US">Hi Brice,</span><u></u><u></u></p>
<p class="MsoNormal"><span lang="EN-US"> </span><u></u><u></u></p>
<p class="MsoNormal"><span lang="EN-US">yes, the backport you suggest seems appropriate. Please go ahead with a PR if you like.</span><u></u><u></u></p>
<p class="MsoNormal"><span lang="EN-US"> </span><u></u><u></u></p>
<p class="MsoNormal"><span lang="EN-US">Cheers</span><u></u><u></u></p>
<p class="MsoNormal"><span lang="EN-US">Christoph</span><u></u><u></u></p>
<p class="MsoNormal"> <u></u><u></u></p>
<div style="border-style:none none none solid;border-width:medium medium medium 1.5pt;padding:0cm 0cm 0cm 4pt;border-color:currentcolor currentcolor currentcolor blue">
<div>
<div style="border-style:solid none none;border-width:1pt medium medium;padding:3pt 0cm 0cm;border-color:currentcolor">
<p class="MsoNormal"><b><span lang="EN-US">From:</span></b><span lang="EN-US"> jdk-updates-dev <<a href="mailto:jdk-updates-dev-retn@openjdk.org" target="_blank">jdk-updates-dev-retn@openjdk.org</a>>
<b>On Behalf Of </b>Brice Dutheil<br>
<b>Sent:</b> Samstag, 1. Oktober 2022 14:01<br>
<b>To:</b> <a href="mailto:jdk-updates-dev@openjdk.org" target="_blank">jdk-updates-dev@openjdk.org</a><br>
<b>Subject:</b> Backporting JDK-8217264 on JDK11u</span><u></u><u></u></p>
</div>
</div>
<p class="MsoNormal"> <u></u><u></u></p>
<table style="width:100%" width="100%" cellspacing="0" cellpadding="0" border="0" align="left">
<tbody>
<tr>
<td style="background:rgb(166,166,166);padding:5.25pt 1.5pt"></td>
<td style="width:100%;background:rgb(234,234,234);padding:5.25pt 3.75pt 5.25pt 11.25pt" width="100%">
<div>
<p class="MsoNormal">
<span style="font-size:9pt;font-family:"Segoe UI",sans-serif;color:rgb(33,33,33)">Some people who received this message don't often get email from
<a href="mailto:brice.dutheil@gmail.com" target="_blank">brice.dutheil@gmail.com</a>.
<a href="https://aka.ms/LearnAboutSenderIdentification" target="_blank">Learn why this is important</a></span><u></u><u></u></p>
</div>
</td>
<td style="width:56.25pt;background:rgb(234,234,234);padding:5.25pt 3.75pt" width="75">
</td>
</tr>
</tbody>
</table>
</div>
</div>
</div>
<div>
<div>
<div style="border-style:none none none solid;border-width:medium medium medium 1.5pt;padding:0cm 0cm 0cm 4pt;border-color:currentcolor currentcolor currentcolor blue">
<div>
<div>
<div>
<p class="MsoNormal"><span style="color:white">Hi everyone,</span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">I was redirected there, to ask about backporting some fixes made to `HttpClient` to JDK11u.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">Indeed, some API usage around the BodySubscribers with a common need of handling GZipped HTTP payload, are problematic (results in a deadlock) on JDK11 because,<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">1. The API is improperly documented ; this was fixed in JDK 13 with
<a href="https://bugs.openjdk.org/browse/JDK-8217627" target="_blank">https://bugs.openjdk.org/browse/JDK-8217627</a><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">2. Daniel fuchs contributed a mechanism that prevents the deadlock, also contributed in JDK 13 with
<a href="https://bugs.openjdk.org/browse/JDK-8217264" target="_blank">https://bugs.openjdk.org/browse/JDK-8217264</a>
<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">While I would prefer users to upgrade to a more recent JDK, I believe fixing this deadlock on an LTS seems appropriate.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">Thank you in advance for considering the backport of these fixes.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">Cheers,<u></u><u></u></p>
</div>
<div>
<div>
<div>
<p class="MsoNormal">-- Brice<u></u><u></u></p>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</blockquote>
</div>
</div>
</div>
</div>
</div>
</div>
</div></blockquote></div>