<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Hi Severin,</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
I forgot to add this in my last reply. From my last email, if that is the correct 21u repo and if there aren't any other special details for backporting to 21u, could you or someone with JBS account help me add an initial "Fix request 21u" to JDK-8308593 to
start the backport process for 21u?</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Thanks again,</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Terry</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Terry Chow (Simba Technologies Inc) <v-terrychow@microsoft.com><br>
<b>Sent:</b> August 24, 2023 11:42 AM<br>
<b>To:</b> Severin Gehwolf <sgehwolf@redhat.com>; jdk-updates-dev@openjdk.org <jdk-updates-dev@openjdk.org><br>
<b>Subject:</b> Re: [EXTERNAL] Re: Backporting Keepalive Windows Extended Socket Options (JDK-8308593) to 11u and 17u</font>
<div> </div>
</div>
<style type="text/css" style="display:none">
<!--
p
{margin-top:0;
margin-bottom:0}
-->
</style>
<div dir="ltr">
<div class="x_elementToProof" style="font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
Hi Severin,</div>
<div class="x_elementToProof" style="font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
<br>
</div>
<div class="x_elementToProof" style="font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
Thanks for the feedback. Just to confirm some details, is this the correct repo for backports into 21u? I was expecting a "jdk21u-dev" repo, similar to 17u and 11u.</div>
<div class="x_elementToProof" style="font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
<br>
</div>
<div class="x_elementToProof" style="font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
<a href="https://github.com/openjdk/jdk21u" id="OWA1721c2cc-2629-c3ec-0458-24705cf057d7" class="x_OWAAutoLink">openjdk/jdk21u: https://openjdk.org/projects/jdk-updates (github.com)</a></div>
<div class="x__Entity x__EType_OWALinkPreview x__EId_OWALinkPreview x__EReadonly_1">
</div>
<div class="x_elementToProof" style="font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
<br>
</div>
<div class="x_elementToProof" style="font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
Also, can the guide below be applied to backporting into 21u, the process is the same as 17u and 11u? There aren't any specific details I need to be aware of to get a backport into 21u right?</div>
<div class="x_elementToProof" style="font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
<br>
</div>
<div class="x_elementToProof" style="font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
<a href="https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix" id="OWA4f894486-b298-b55a-9f2c-31e95da3139a" class="x_OWAAutoLink">How to contribute or backport a fix - How to contribute or backport a fix - OpenJDK Wiki</a></div>
<div class="x__Entity x__EType_OWALinkPreview x__EId_OWALinkPreview_1 x__EReadonly_1">
</div>
<div class="x_elementToProof" style="font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
<br>
</div>
<div class="x_elementToProof" style="font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
Thanks,
<div>Terry</div>
</div>
<div id="x_appendonsend"></div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Severin Gehwolf <sgehwolf@redhat.com><br>
<b>Sent:</b> August 24, 2023 1:17 AM<br>
<b>To:</b> Terry Chow (Simba Technologies Inc) <v-terrychow@microsoft.com>; jdk-updates-dev@openjdk.org <jdk-updates-dev@openjdk.org><br>
<b>Subject:</b> [EXTERNAL] Re: Backporting Keepalive Windows Extended Socket Options (JDK-8308593) to 11u and 17u</font>
<div> </div>
</div>
<div class="x_BodyFragment"><font size="2"><span style="font-size:11pt">
<div class="x_PlainText">[You don't often get email from sgehwolf@redhat.com. Learn why this is important at
<a href="https://aka.ms/LearnAboutSenderIdentification">https://aka.ms/LearnAboutSenderIdentification</a> ]<br>
<br>
Hi Terry,<br>
<br>
On Thu, 2023-08-24 at 00:54 +0000, Terry Chow (Simba Technologies Inc) wrote:<br>
> Hi maintainers of OpenJDK updates,<br>
><br>
> I'd like to backport JDK-8308593 (keepalive extended socket options for Windows) to 11u and 17u (maybe 8u later as well). And so, I just want to open discussion on this topic to hear your opinions before I start the backporting process. I did some initial
investigation on the backport and I learned the following:<br>
><br>
> Backporting to 11u requires three additional changes to be made on top of the backport in order for it to work.<br>
> 1. Lib-jdk.net.gmk will need to be updated to support building extnet for Windows.<br>
> 2. jdk.net.ExtendedSocketOption will need to add a case to support returning a Windows instance of PlatformSocketOptions.<br>
> 3. The Windows PlainSocketImpl class needs to have the same code on lines 61 - 96 in the Unix PlainSocketImpl class.<br>
> Backporting to 17u requires two additional changes (similar to 11u).<br>
> 1. jdk.net/Lib.gmkwill need to be updated to support building extnet for Windows.<br>
> 2. jdk.net.ExtendedSocketOption will need to add a case to support returning a Windows instance of PlatformSocketOptions.<br>
> Let me know if the additional changes are acceptable or if they're disruptive.<br>
<br>
As the change went into JDK 22, I'd first suggest to get this into JDK<br>
21u which would bring this feature to LTS users. JDK 17u seems OK as a<br>
next step from a brief glance (once it's in 21u). Only then we should<br>
evaluate JDK 11u and older releases.<br>
<br>
Thanks,<br>
Severin<br>
<br>
</div>
</span></font></div>
</div>
</body>
</html>