<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Hello Severin and JDK maintainers,</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
The backports for 21u and 17u have been completely merged, and so I want to move forward with discussing on getting the backport into 11u. I've already done some initial work/investigating for backporting to 11u. The following are necessary changes to ensure
a working backport:</div>
<ol start="1" data-editing-info="{"orderedStyleType":1,"unorderedStyleType":1}" data-listchain="__List_Chain_348" style="text-align: left; list-style-position: initial; list-style-type: decimal; background-color: rgb(255, 255, 255);">
<li style="letter-spacing: normal; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; font-weight: 400; color: black;">
<span style="letter-spacing: normal; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; font-weight: 400; color: black;">Lib-jdk.net.gmk will need to be updated to support building extnet for Windows.</span></li><li style="letter-spacing: normal; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; font-weight: 400; color: black;">
<span style="letter-spacing: normal; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; font-weight: 400; color: black;">jdk.net.ExtendedSocketOption will need to add a case to support returning a Windows
instance of PlatformSocketOptions.<br>
</span></li><li style="letter-spacing: normal; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; font-weight: 400; color: black;">
<span style="letter-spacing: normal; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; font-weight: 400; color: black;">The Windows PlainSocketImpl class will need to have similar setOption/getOption
methods as the Unix PlainSocketImpl class to support setting these extended socket options for Windows.</span></li></ol>
<div class="elementToProof"><span style="letter-spacing: normal; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; font-weight: 400; color: black;">For points 1 and 2, those changes were also required
for the 17u backport and so I believe they should also be acceptable for 11u. For point 3, that is mostly copying what's already in the Unix PlainSocketImpl class over to the Windows version of the class. Overall, the changes seem innocuous, but let me know
if I missed anything that could be disruptive for 11u.</span></div>
<div class="elementToProof"><span style="letter-spacing: normal; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; font-weight: 400; color: black;"><br>
</span></div>
<div class="elementToProof"><span style="letter-spacing: normal; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; font-weight: 400; color: black;">Thanks again,</span></div>
<div class="elementToProof"><span style="letter-spacing: normal; font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; font-weight: 400; color: black;">Terry</span></div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Severin Gehwolf <sgehwolf@redhat.com><br>
<b>Sent:</b> September 18, 2023 1:52 AM<br>
<b>To:</b> Terry Chow (Simba Technologies Inc) <v-terrychow@microsoft.com>; jdk-updates-dev@openjdk.org <jdk-updates-dev@openjdk.org><br>
<b>Subject:</b> Re: [EXTERNAL] Re: Backporting Keepalive Windows Extended Socket Options (JDK-8308593) to 11u and 17u</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">Hi,<br>
<br>
On Fri, 2023-09-15 at 19:31 +0000, Terry Chow (Simba Technologies Inc) wrote:<br>
> Hi Severin,<br>
> <br>
> I just saw that the 21u backport merged. Thanks again for the help. I also now want to do a backport for 17u.<br>
> <br>
> The "Fix request" comment for 17u:<br>
> <br>
> The backport does not cleanly apply to 17u. The following changes were made in these files to resolve conflicts and issues:<br>
> 1. make/modules/jdk.net/Lib.gmk --I updated this script to support building extnet for Windows.<br>
> 2. jdk.net/share/classes/jdk/net/ExtendedSocketOptions.java --I added a case to support returning an instance of WindowsSocketOptions in PlatformSocketOptions.<br>
> The reason for the backport to 17u is to have keepalive parity with the other OS platforms. Similarly to the 21u backport, the risk is low as the backported code introduces a new code path that only takes effect when keepalive extended socket options are
set on a Windows platform. I manually tested the patch and Tier 1 tests were ran and they're passing. No new tests were added as there are existing tests in 17u that cover this scenario. URL to intended backport PR: Backport f3ade388dac0b882e671462caa762138f44817fb
· tkyc/jdk17u-dev@7c75b9d (github.com).<br>
<br>
Please create a backport PR for jdk17u-dev and use the new Skara<br>
tooling for the approval process. It should handle the "Fix Request"<br>
comment for you with the "/approval" command[1].<br>
<br>
Thanks,<br>
Severin<br>
<br>
[1] <a href="https://wiki.openjdk.org/display/SKARA/Pull+Request+Commands#PullRequestCommands-/approval">
https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwiki.openjdk.org%2Fdisplay%2FSKARA%2FPull%2BRequest%2BCommands%23PullRequestCommands-%2Fapproval&data=05%7C01%7Cv-terrychow%40microsoft.com%7Cceedf509a96345938eb908dbb824974f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638306239531822349%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=zRoPe8DtbjNT%2FYeI8%2FL2%2FGmP5KVhbFXbFmf9IOmoF5w%3D&reserved=0</a><br>
<br>
</div>
</span></font></div>
</body>
</html>