<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Thanks Severin for your feedback. I'll start on the approval process for the backport since all looks ok.</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Severin Gehwolf <sgehwolf@redhat.com><br>
<b>Sent:</b> November 7, 2023 2:30 AM<br>
<b>To:</b> Terry Chow (SIMBA TECHNOLOGIES INC) <v-terrychow@microsoft.com>; jdk-updates-dev@openjdk.org <jdk-updates-dev@openjdk.org><br>
<b>Subject:</b> Re: [EXTERNAL] Re: Backporting Keepalive Windows Extended Socket Options (JDK-8308593) to 11u and 17u</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">[You don't often get email from sgehwolf@redhat.com. Learn why this is important at
<a href="https://aka.ms/LearnAboutSenderIdentification">https://aka.ms/LearnAboutSenderIdentification</a> ]<br>
<br>
Hi,<br>
<br>
Thanks for reaching out.<br>
<br>
On Fri, 2023-11-03 at 23:33 +0000, Terry Chow (SIMBA TECHNOLOGIES INC)<br>
wrote:<br>
> Hello Severin and JDK maintainers,<br>
><br>
> The backports for 21u and 17u have been completely merged, and so I<br>
> want to move forward with discussing on getting the backport into<br>
> 11u. I've already done some initial work/investigating for<br>
> backporting to 11u. The following are necessary changes to ensure a<br>
> working backport:<br>
> 1. Lib-jdk.net.gmk will need to be updated to support building<br>
> extnet for Windows.<br>
> 2. jdk.net.ExtendedSocketOption will need to add a case to support<br>
> returning a Windows instance of PlatformSocketOptions.<br>
> 3. The Windows PlainSocketImpl class will need to have similar<br>
> setOption/getOption methods as the Unix PlainSocketImpl class to<br>
> support setting these extended socket options for Windows.<br>
> For points 1 and 2, those changes were also required for the 17u<br>
> backport and so I believe they should also be acceptable for 11u. For<br>
> point 3, that is mostly copying what's already in the Unix<br>
> PlainSocketImpl class over to the Windows version of the class.<br>
> Overall, the changes seem innocuous, but let me know if I missed<br>
> anything that could be disruptive for 11u.<br>
<br>
While the JDK 11u updates tree is a very stable bugfix-only release at<br>
this point, it seems OK to backport this feature for Windows as it<br>
would mostly affect Windows code (one platform). The risk seems<br>
tolerable. Personally, for the JDK 11u backport I would refrain from<br>
those renaming changes, though.<br>
<br>
Thanks,<br>
Severin<br>
<br>
</div>
</span></font></div>
</body>
</html>