<div dir="ltr"><div>Hi Goetz,</div><div><br></div><div>I am working on a fix. It is a test issue when the new method I introduced to WhiteBox calls <div style="color:rgb(59,59,59);background-color:rgb(255,255,255);font-family:Menlo,Monaco,"Courier New",monospace;font-weight:normal;font-size:14px;line-height:21px;white-space:pre"><div><span style="color:rgb(59,59,59)">ClassLoaderDataGraph::do_unloading </span></div></div>and that will trigger an assert if not called in safepoint. Unfortunately, the custom reg tests for tier2 I ran were not run with fastdebug but only release so this issue escaped.</div><div><br></div><div>The fix should be as easy as wrapping the 'do_unloading' call in a VM_WhiteBoxOperation. Also, I fixed our local GHA definition to run both release and fastdebug for custom test selection so this does not repeat again.</div><div><br></div><div>I apologize again for the inconvenience. I am going to file a JBS ticket to track the test failure and propose a PR immediately.</div><div><br></div><div>Regards,</div><div><br></div><div>Jaroslav<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, Dec 24, 2023 at 12:59 AM Lindenmaier, Goetz <<a href="mailto:goetz.lindenmaier@sap.com">goetz.lindenmaier@sap.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Jaroslav,<br>
<br>
I backed out the change in our nightly testing and the issue<br>
is gone. So it's really caused by your change.<br>
<br>
Best regards, <br>
Goetz.<br>
<br>
<br>
> -----Original Message-----<br>
> From: jdk-updates-dev <<a href="mailto:jdk-updates-dev-retn@openjdk.org" target="_blank">jdk-updates-dev-retn@openjdk.org</a>> On Behalf Of<br>
> Amos Shi<br>
> Sent: Samstag, 23. Dezember 2023 00:02<br>
> To: <a href="mailto:jdk-updates-dev@openjdk.org" target="_blank">jdk-updates-dev@openjdk.org</a><br>
> Subject: Re: [jdk11u-dev] RFR: 8313816: Accessing jmethodID might lead to<br>
> spurious crashes [v2]<br>
> <br>
> [Some people who received this message don't often get email from<br>
> <a href="mailto:ashi@openjdk.org" target="_blank">ashi@openjdk.org</a>. Learn why this is important at<br>
> <a href="https://aka.ms/LearnAboutSenderIdentification" rel="noreferrer" target="_blank">https://aka.ms/LearnAboutSenderIdentification</a> ]<br>
> <br>
> On Wed, 6 Dec 2023 10:38:56 GMT, Jaroslav Bachorik<br>
> <<a href="mailto:jbachorik@openjdk.org" target="_blank">jbachorik@openjdk.org</a>> wrote:<br>
> <br>
> >> Looks like a clean backport from the 17u PR, except for replacing nullptr<br>
> with NULL as you note, and the unused declaration of<br>
> metaspaceSharedRegionAlignment in WhiteBox.java. The latter doesn't seem<br>
> have a definition in 11u: if so, please remove it.<br>
> ><br>
> > @phohensee There are the additional changes in the testing that were<br>
> necessary. Although they are not affecting any existing code/tests.<br>
> <br>
> Hi @jbachorik,<br>
> <br>
> In today's test result, the test case<br>
> `test/hotspot/jtreg/serviceability/jvmti/thread/GetStackTrace/GetStackTraceAn<br>
> dRetransformTest/GetStackTraceAndRetransformTest.java` is failing with the<br>
> following info:<br>
> <br>
> - _Unsupported internal testing APIs have been used._<br>
> <br>
> <br>
> ----------System.out:(20/1185)----------<br>
> # To suppress the following error report, specify this argument<br>
> # after -XX: or in .hotspotrc: SuppressErrorAt=/metadataOnStackMark.cpp:50<br>
> #<br>
> # A fatal error has been detected by the Java Runtime Environment:<br>
> #<br>
> # Internal Error (/priv/jenkins/client-home/workspace/openjdk-11u-dev-<br>
> linux_x86_64-<br>
> dbg/jdk/src/hotspot/share/classfile/metadataOnStackMark.cpp:50), pid=65261,<br>
> tid=65413<br>
> # assert(SafepointSynchronize::is_at_safepoint()) failed: sanity check<br>
> #<br>
> # JRE version: OpenJDK Runtime Environment (11.0.23) (fastdebug build<br>
> 11.0.23-internal+0-adhoc..jdk)<br>
> # Java VM: OpenJDK 64-Bit Server VM (fastdebug 11.0.23-internal+0-<br>
> adhoc..jdk, mixed mode, tiered, compressed oops, g1 gc, linux-amd64)<br>
> # Core dump will be written. Default location:<br>
> /priv/jvmtests/output_openjdk11_dev_dbgU_linuxx86_64/jtreg_hotspot_tier2<br>
> _work/JTwork/scratch/8/core.65261<br>
> #<br>
> Unsupported internal testing APIs have been used.<br>
> <br>
> # An error report file with more information is saved as:<br>
> #<br>
> /priv/jvmtests/output_openjdk11_dev_dbgU_linuxx86_64/jtreg_hotspot_tier2<br>
> _work/JTwork/scratch/8/hs_err_pid65261.log<br>
> #<br>
> # If you would like to submit a bug report, please visit:<br>
> #<br>
> <a href="https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugrepo" rel="noreferrer" target="_blank">https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugrepo</a><br>
> <a href="http://rt.java.com" rel="noreferrer" target="_blank">rt.java.com</a>%2Fbugreport%2Fcrash.jsp&data=05%7C02%7Cgoetz.lindenmaier%<br>
> <a href="http://40sap.com" rel="noreferrer" target="_blank">40sap.com</a>%7Cd348179c4a08439f11d208dc03420cea%7C42f7676cf455423c8<br>
> 2f6dc2d99791af7%7C0%7C0%7C638388829421636554%7CUnknown%7CTWF<br>
> pbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI<br>
> 6Mn0%3D%7C3000%7C%7C%7C&sdata=xS617527CbTO5OPMg6uxqMvXEbAfy<br>
> nXDYVaWQGqbYzA%3D&reserved=0<br>
> <br>
> <br>
> Need your help to identify if this failure is caused by current PR or not.<br>
> <br>
> Thanks<br>
> Amos<br>
> A Happy Developer<br>
> <br>
> -------------<br>
> <br>
> PR Comment: <a href="https://git.openjdk.org/jdk11u-dev/pull/2321#issuecomment-" rel="noreferrer" target="_blank">https://git.openjdk.org/jdk11u-dev/pull/2321#issuecomment-</a><br>
> 1868118735<br>
</blockquote></div>