<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:DengXian;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"\@DengXian";
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
mso-ligatures:standardcontextual;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="#0563C1" vlink="#954F72" style="word-wrap:break-word">
<div class="WordSection1">
<p class="MsoNormal">Hi contributors to the jdk-updates projects<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">You need to test changes you want to bring to the <o:p></o:p></p>
<p class="MsoNormal">updates repositories before labeling -fix-request or <o:p></o:p></p>
<p class="MsoNormal">using the /approval command.<o:p></o:p></p>
<p class="MsoNormal">This includes passing the GHA tests.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">We currently see the GHA tests fail due to a build issue<o:p></o:p></p>
<p class="MsoNormal">on Risc-V. This does not give you the right to <o:p></o:p></p>
<p class="MsoNormal">just request approval. You must first assure the failure <o:p>
</o:p></p>
<p class="MsoNormal">is only caused by this issue, and you must give a reason in the PR<o:p></o:p></p>
<p class="MsoNormal">why you want to integrate your change anyways.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">If you fail to do this, I will just remove the -fix-request<o:p></o:p></p>
<p class="MsoNormal">label when I check your change for approval. Check the <o:p>
</o:p></p>
<p class="MsoNormal">tests, add a comment and request approval again.<o:p></o:p></p>
<p class="MsoNormal">Also give the approval reason again: the comment in the <o:p>
</o:p></p>
<p class="MsoNormal">JBS issue will be overwritten.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">I will not comment in each change that you need to check <o:p>
</o:p></p>
<p class="MsoNormal">the tests, nor will I check them by myself. Scanning the <o:p>
</o:p></p>
<p class="MsoNormal">approval request on a daily basis is a considerable effort, <o:p>
</o:p></p>
<p class="MsoNormal">and I can not keep it up if a large amount of changes don’t meet the<o:p></o:p></p>
<p class="MsoNormal">criteria that are documented in <o:p></o:p></p>
<p class="MsoNormal"><a href="https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix">How to contribute or backport a fix - How to contribute or backport a fix - OpenJDK Wiki</a><o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Just for the records, it just happened that a change <o:p></o:p></p>
<p class="MsoNormal">was pushed that broke the build which was overseen <o:p></o:p></p>
<p class="MsoNormal">because the tests had not been checked.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Best regards, <o:p></o:p></p>
<p class="MsoNormal"> Goetz.<o:p></o:p></p>
</div>
</body>
</html>