From oleksandr at tvori.info Sat Apr 1 16:04:36 2017 From: oleksandr at tvori.info (Oleksandr Nikitin) Date: Sat, 1 Apr 2017 19:04:36 +0300 Subject: JDK10 build on Win64 fails on `make images` Message-ID: <CAPxxM_9innDKpbquLFngiSnfSQJFB-w=zcgRvXva494CVKUbqA@mail.gmail.com> TLDR: configure seems to run fine, but the `make images` step fails with the error: No rule to make target `java.base-libs` I am following this guide: http://openjdk.java.net/jeps/8174901 Full build log: https://gist.github.com/wizzard0/ad8406ea1c2aea4bfe9faeda35a76dd0 JDK9 builds fine in this environment (so I assume it is configured mostly correctly). I can provide access to the machine if needed. Thanks in advance! -- With best wishes, Oleksandr Nikitin github/skype/fb: wizzard0 twitter/medium: oleksandr_now From wizzard0 at gmail.com Sat Apr 1 16:11:06 2017 From: wizzard0 at gmail.com (Oleksandr Nikitin) Date: Sat, 1 Apr 2017 19:11:06 +0300 Subject: JDK10 build on Win64 fails on `make images` Message-ID: <CAPxxM_-hzLur+sTmSvs6izpjYvHaEab=yE-=dLApaS+Whuxr+g@mail.gmail.com> Hello, I am trying to build JDK 10 + Epsilon GC on Windows by this guide: http://openjdk.java.net/jeps/8174901 TLDR: configure seems to run fine, but the `make images` step fails with the error: No rule to make target `java.base-libs` Full build log: https://gist.github.com/wizzard0/ ad8406ea1c2aea4bfe9faeda35a76dd0 I can build JDK 8 and 9 in this environment, so I assume it is configured mostly correctly. Never dabbled with any JDK sources before, so looking for any advice. I can provide access to the machine if needed. Machine: Windows 10 Pro x64, Windows SDK 7.1, Cygwin x64, bootstrap JDK 1.8u121 x64 Thanks in advance! -- With best wishes, Oleksandr Nikitin skype: wizzard0 From thomas.stuefe at gmail.com Mon Apr 3 18:50:15 2017 From: thomas.stuefe at gmail.com (=?UTF-8?Q?Thomas_St=C3=BCfe?=) Date: Mon, 3 Apr 2017 20:50:15 +0200 Subject: JDK10 build on Win64 fails on `make images` In-Reply-To: <CAPxxM_-hzLur+sTmSvs6izpjYvHaEab=yE-=dLApaS+Whuxr+g@mail.gmail.com> References: <CAPxxM_-hzLur+sTmSvs6izpjYvHaEab=yE-=dLApaS+Whuxr+g@mail.gmail.com> Message-ID: <CAA-vtUy57OLHSmL7YJV6oGFA+TVF7bU-Z0Oq+=QPbRv=m37rtw@mail.gmail.com> Hi Oleksandr, make sure you have https://bugs.openjdk.java.net/browse/JDK-8177137 . This was fixed in 9, but I think the patch has not yet been ported to 10 (not sure). Kind Regards, Thomas On Sat, Apr 1, 2017 at 6:11 PM, Oleksandr Nikitin <wizzard0 at gmail.com> wrote: > Hello, > > I am trying to build JDK 10 + Epsilon GC on Windows by this guide: > http://openjdk.java.net/jeps/8174901 > > TLDR: configure seems to run fine, but the `make images` step fails with > the error: > No rule to make target `java.base-libs` > > Full build log: https://gist.github.com/wizzard0/ > ad8406ea1c2aea4bfe9faeda35a76dd0 > > I can build JDK 8 and 9 in this environment, so I assume it is configured > mostly correctly. > Never dabbled with any JDK sources before, so looking for any advice. I can > provide access to the machine if needed. > > Machine: Windows 10 Pro x64, Windows SDK 7.1, Cygwin x64, bootstrap JDK > 1.8u121 x64 > > Thanks in advance! > > -- > With best wishes, Oleksandr Nikitin > > skype: wizzard0 > From joe.darcy at oracle.com Mon Apr 3 18:55:46 2017 From: joe.darcy at oracle.com (joe darcy) Date: Mon, 3 Apr 2017 11:55:46 -0700 Subject: JDK10 build on Win64 fails on `make images` In-Reply-To: <CAA-vtUy57OLHSmL7YJV6oGFA+TVF7bU-Z0Oq+=QPbRv=m37rtw@mail.gmail.com> References: <CAPxxM_-hzLur+sTmSvs6izpjYvHaEab=yE-=dLApaS+Whuxr+g@mail.gmail.com> <CAA-vtUy57OLHSmL7YJV6oGFA+TVF7bU-Z0Oq+=QPbRv=m37rtw@mail.gmail.com> Message-ID: <79f72a05-72b4-15e6-04e0-9d776c85ba45@oracle.com> Hello, On 4/3/2017 11:50 AM, Thomas St?fe wrote: > Hi Oleksandr, > > make sure you have https://bugs.openjdk.java.net/browse/JDK-8177137 . This > was fixed in 9, but I think the patch has not yet been ported to 10 (not > sure). In more detail, the fix for JDK-8177137 is in the JDK 9 client forest. To get into JDK 10, first, the fix will need to be be integrated into the JDK 9 dev forest. After it is then promoted to JDK 9 master, the change will be synced over to JDK 10 at some point. HTH, -Joe > > Kind Regards, Thomas > > > > On Sat, Apr 1, 2017 at 6:11 PM, Oleksandr Nikitin <wizzard0 at gmail.com> > wrote: > >> Hello, >> >> I am trying to build JDK 10 + Epsilon GC on Windows by this guide: >> http://openjdk.java.net/jeps/8174901 >> >> TLDR: configure seems to run fine, but the `make images` step fails with >> the error: >> No rule to make target `java.base-libs` >> >> Full build log: https://gist.github.com/wizzard0/ >> ad8406ea1c2aea4bfe9faeda35a76dd0 >> >> I can build JDK 8 and 9 in this environment, so I assume it is configured >> mostly correctly. >> Never dabbled with any JDK sources before, so looking for any advice. I can >> provide access to the machine if needed. >> >> Machine: Windows 10 Pro x64, Windows SDK 7.1, Cygwin x64, bootstrap JDK >> 1.8u121 x64 >> >> Thanks in advance! >> >> -- >> With best wishes, Oleksandr Nikitin >> >> skype: wizzard0 >> From joe.darcy at oracle.com Tue Apr 4 00:08:36 2017 From: joe.darcy at oracle.com (Joseph D. Darcy) Date: Mon, 03 Apr 2017 17:08:36 -0700 Subject: How to handle future backports from JDK 10 into JDK 9? In-Reply-To: <e5bf529f-7803-1ce6-64f5-cc02199712fa@oracle.com> References: <49f8daf7-6c15-dec9-92e3-ef76dc6f2afb@oracle.com> <58db6d43-3457-8bd9-bb04-3ab01aeb64e7@oracle.com> <5df4217f-0a88-4938-a06f-e00176a5153b@oracle.com> <3729188d-aa28-25bf-efaf-e74acc19437a@oracle.com> <c3a49adf-7746-8883-1544-267e51ea637c@oracle.com> <a1844d9b-eeba-8f09-4b95-645284333719@oracle.com> <a89154ec-64db-1718-67de-de5bfb8af0f9@oracle.com> <e833b500-e77e-e5d1-8406-08bfdf2006a0@oracle.com> <3815dda4-c612-dd5a-547f-553477fad5d7@oracle.com> <2a244a55-3576-1c69-b3c5-f0331df20f6c@oracle.com> <77bbab8f-854a-e718-8d5c-e85faa8cc4f0@oracle.com> <e5bf529f-7803-1ce6-64f5-cc02199712fa@oracle.com> Message-ID: <58E2E404.3020901@oracle.com> Hello, Last call for objections to disabling the unique bug id check in JDK 10. Thanks, -Joe On 3/27/2017 10:11 AM, joe darcy wrote: > Hello David and others, > > Returning to this topic, I concede there are exceptional cases where > backporting some functionality under a different bug id may be > reasonable. However, I don't think such rare cases should drive larger > decisions of handling forward and backports in 9 and 10 and whether or > not the duplicate bug id check should be disabled in JDK 10. > > While the bug id check does prevent the error of accidentally reusing > a bug id, it does not prevent many other classes of errors around bug > ids, such as swapped digit typos. (Sharing of scripts to do such > checks pre-push welcome.) Additionally, the duplicate bug id check > causes complications, including the topic under discussion now, as > well as for the possible repository consolidation. That check has been > disabled in the update releases for years without problems. > > Therefore, on the whole, I think it would be a net benefit to disable > the duplicate bug id check for JDK 10 too. > > Cheers, > > -Joe > > > On 2/21/2017 7:05 PM, David Holmes wrote: >> Hi Joe, >> >> From my own observation/experience the "why" we would create a new >> bug to "backport" something is when the something is not neatly >> packaged and obtainable through direct backports of specific issues. >> Take an example of an issue that is fixed but is buggy and has quite >> a lengthy bugtail - once it is reliable you want to backport it to an >> earlier release. Do you backport each individual bug (some of which >> may not even apply to the earlier release) or do you backport the >> resulting functionality that was finally obtained? There are pros and >> cons to both approaches - neither is clean nor ideal. Such is life. >> >> Cheers, >> David >> ----- [snip] From thomas.stuefe at gmail.com Tue Apr 4 08:31:51 2017 From: thomas.stuefe at gmail.com (=?UTF-8?Q?Thomas_St=C3=BCfe?=) Date: Tue, 4 Apr 2017 10:31:51 +0200 Subject: JDK10 build on Win64 fails on `make images` In-Reply-To: <79f72a05-72b4-15e6-04e0-9d776c85ba45@oracle.com> References: <CAPxxM_-hzLur+sTmSvs6izpjYvHaEab=yE-=dLApaS+Whuxr+g@mail.gmail.com> <CAA-vtUy57OLHSmL7YJV6oGFA+TVF7bU-Z0Oq+=QPbRv=m37rtw@mail.gmail.com> <79f72a05-72b4-15e6-04e0-9d776c85ba45@oracle.com> Message-ID: <CAA-vtUwGX0x3CX35LDP+LSqXTQLpUwX5_qVLt6gE=w2-oL71Fg@mail.gmail.com> Hi Joe, thanks for clarifying! Is the fix author responsible for bringing the client fix to dev or will this happen automatically? Thanks, Thomas On Mon, Apr 3, 2017 at 8:55 PM, joe darcy <joe.darcy at oracle.com> wrote: > Hello, > > > On 4/3/2017 11:50 AM, Thomas St?fe wrote: > >> Hi Oleksandr, >> >> make sure you have https://bugs.openjdk.java.net/browse/JDK-8177137 . >> This >> was fixed in 9, but I think the patch has not yet been ported to 10 (not >> sure). >> > > In more detail, the fix for JDK-8177137 is in the JDK 9 client forest. To > get into JDK 10, first, the fix will need to be be integrated into the JDK > 9 dev forest. After it is then promoted to JDK 9 master, the change will be > synced over to JDK 10 at some point. > > HTH, > > -Joe > > > >> Kind Regards, Thomas >> >> >> >> On Sat, Apr 1, 2017 at 6:11 PM, Oleksandr Nikitin <wizzard0 at gmail.com> >> wrote: >> >> Hello, >>> >>> I am trying to build JDK 10 + Epsilon GC on Windows by this guide: >>> http://openjdk.java.net/jeps/8174901 >>> >>> TLDR: configure seems to run fine, but the `make images` step fails with >>> the error: >>> No rule to make target `java.base-libs` >>> >>> Full build log: https://gist.github.com/wizzard0/ >>> ad8406ea1c2aea4bfe9faeda35a76dd0 >>> >>> I can build JDK 8 and 9 in this environment, so I assume it is configured >>> mostly correctly. >>> Never dabbled with any JDK sources before, so looking for any advice. I >>> can >>> provide access to the machine if needed. >>> >>> Machine: Windows 10 Pro x64, Windows SDK 7.1, Cygwin x64, bootstrap JDK >>> 1.8u121 x64 >>> >>> Thanks in advance! >>> >>> -- >>> With best wishes, Oleksandr Nikitin >>> >>> skype: wizzard0 >>> >>> > From joe.darcy at oracle.com Tue Apr 4 15:54:02 2017 From: joe.darcy at oracle.com (joe darcy) Date: Tue, 4 Apr 2017 08:54:02 -0700 Subject: JDK10 build on Win64 fails on `make images` In-Reply-To: <CAA-vtUwGX0x3CX35LDP+LSqXTQLpUwX5_qVLt6gE=w2-oL71Fg@mail.gmail.com> References: <CAPxxM_-hzLur+sTmSvs6izpjYvHaEab=yE-=dLApaS+Whuxr+g@mail.gmail.com> <CAA-vtUy57OLHSmL7YJV6oGFA+TVF7bU-Z0Oq+=QPbRv=m37rtw@mail.gmail.com> <79f72a05-72b4-15e6-04e0-9d776c85ba45@oracle.com> <CAA-vtUwGX0x3CX35LDP+LSqXTQLpUwX5_qVLt6gE=w2-oL71Fg@mail.gmail.com> Message-ID: <fa11e65d-2a4e-b613-873e-039d2c67f49f@oracle.com> Hi Thomas, The rest of the fix propagation described below will take place without any additional intervention from the fix author. Cheers, -Joe On 4/4/2017 1:31 AM, Thomas St?fe wrote: > Hi Joe, thanks for clarifying! > > Is the fix author responsible for bringing the client fix to dev or > will this happen automatically? > > Thanks, Thomas > > On Mon, Apr 3, 2017 at 8:55 PM, joe darcy <joe.darcy at oracle.com > <mailto:joe.darcy at oracle.com>> wrote: > > Hello, > > > On 4/3/2017 11:50 AM, Thomas St?fe wrote: > > Hi Oleksandr, > > make sure you have > https://bugs.openjdk.java.net/browse/JDK-8177137 > <https://bugs.openjdk.java.net/browse/JDK-8177137> . This > was fixed in 9, but I think the patch has not yet been ported > to 10 (not > sure). > > > In more detail, the fix for JDK-8177137 is in the JDK 9 client > forest. To get into JDK 10, first, the fix will need to be be > integrated into the JDK 9 dev forest. After it is then promoted to > JDK 9 master, the change will be synced over to JDK 10 at some point. > > HTH, > > -Joe > > > > Kind Regards, Thomas > > > > On Sat, Apr 1, 2017 at 6:11 PM, Oleksandr Nikitin > <wizzard0 at gmail.com <mailto:wizzard0 at gmail.com>> > wrote: > > Hello, > > I am trying to build JDK 10 + Epsilon GC on Windows by > this guide: > http://openjdk.java.net/jeps/8174901 > <http://openjdk.java.net/jeps/8174901> > > TLDR: configure seems to run fine, but the `make images` > step fails with > the error: > No rule to make target `java.base-libs` > > Full build log: https://gist.github.com/wizzard0/ > <https://gist.github.com/wizzard0/> > ad8406ea1c2aea4bfe9faeda35a76dd0 > > I can build JDK 8 and 9 in this environment, so I assume > it is configured > mostly correctly. > Never dabbled with any JDK sources before, so looking for > any advice. I can > provide access to the machine if needed. > > Machine: Windows 10 Pro x64, Windows SDK 7.1, Cygwin x64, > bootstrap JDK > 1.8u121 x64 > > Thanks in advance! > > -- > With best wishes, Oleksandr Nikitin > > skype: wizzard0 > > > From joe.darcy at oracle.com Wed Apr 5 16:44:31 2017 From: joe.darcy at oracle.com (joe darcy) Date: Wed, 5 Apr 2017 09:44:31 -0700 Subject: Coming soon: second generation prototype of Hg forest consolidation Message-ID: <732ba4ba-5538-9afb-8d29-24d7911d1baf@oracle.com> Hello, As previously discussed [1], we've been exploring consolidating the many repositories in an OpenJDK Hg forest (jdk, langtools, hotspot, ...) into a single repository for JDK 10. The initial prototype of a consolidated repo [2], equivalent to JDK 9 build 138, was published in October 2016. Erik Joelsson has been working on a refined version of the consolidation repo and we plan to publish this second generation prototype in the near future. The new prototype presents a more faithful view of the sources between tags for promoted builds and provides a cleaner overall file layout. The corresponding JEP [3] will be updated to reflect the details of the new prototype in due course. Cheers, -Joe [1] "Looking ahead: proposed Hg forest consolidation for JDK 10," http://mail.openjdk.java.net/pipermail/jdk9-dev/2016-October/004987.html [2] http://hg.openjdk.java.net/jdk9/consol-proto/ [3] JEP 296: Consolidate the JDK Forest into a Single Repository http://openjdk.java.net/jeps/296 From jonathan.gibbons at oracle.com Wed Apr 5 18:38:58 2017 From: jonathan.gibbons at oracle.com (Jonathan Gibbons) Date: Wed, 05 Apr 2017 11:38:58 -0700 Subject: Looking ahead: proposed Hg forest consolidation for JDK 10 -- prototype repo now on hg.openjdk.java.net In-Reply-To: <407a62cd-1bd8-2a96-6ae5-3ec5d88ec5af@oracle.com> References: <4ea8f2e7-7a10-e949-d920-81ae5f610f24@oracle.com> <e01b1f53-3bf6-1786-f4af-b89271868c90@oracle.com> <407a62cd-1bd8-2a96-6ae5-3ec5d88ec5af@oracle.com> Message-ID: <58E539C2.7020100@oracle.com> The consol-proto seems to have separate jtreg test suites (i.e. separate TEST.ROOT files) for test/{jdk,langtools,...} Is that intentional, or just waiting to be fixed? -- Jon On 04/05/2017 09:51 AM, joe darcy wrote: > FYI, follow-up discussions on this topic now occurring on jdk10-dev: > > "Coming soon: second generation prototype of Hg forest > consolidation," > http://mail.openjdk.java.net/pipermail/jdk10-dev/2017-April/000155.html > > -Joe > > > On 10/14/2016 3:40 PM, joe darcy wrote: >> On 10/10/2016 7:11 PM, joe darcy wrote: >>> Hello, >>> >>> Looking ahead to JDK 10, a group of JDK engineers have been >>> exploring consolidating the large number of Hg repositories in an >>> open JDK forest to a single one with the goal of using the >>> consolidated arrangement for JDK 10. >>> >>> This message is being sent to jdk9-dev since a jdk10-dev alias to >>> discuss JDK 10 doesn't exist yet. >>> >>> A JEP describing the project has been submitted : >>> >>> JDK-8167368: Consolidate JDK 10 OpenJDK repositories to a single >>> repository >>> https://bugs.openjdk.java.net/browse/JDK-8167368 >>> >>> The text of the JEP describes the motivation and current state of >>> the work in more detail, including proposed changes to the file >>> layout. Publication of the prototype consolidated repository is >>> planned, but not done yet. >> >> [snip] >> >> The prototype is now available from >> >> http://hg.openjdk.java.net/jdk9/consol-proto/ >> >> As implied by the tags, at present the prototype should be >> functionally equivalent to jdk-9+138. >> >> Enjoy, >> >> -Joe > From joe.darcy at oracle.com Wed Apr 5 23:40:30 2017 From: joe.darcy at oracle.com (Joseph D. Darcy) Date: Wed, 05 Apr 2017 16:40:30 -0700 Subject: Looking ahead: proposed Hg forest consolidation for JDK 10 -- prototype repo now on hg.openjdk.java.net In-Reply-To: <58E539C2.7020100@oracle.com> References: <4ea8f2e7-7a10-e949-d920-81ae5f610f24@oracle.com> <e01b1f53-3bf6-1786-f4af-b89271868c90@oracle.com> <407a62cd-1bd8-2a96-6ae5-3ec5d88ec5af@oracle.com> <58E539C2.7020100@oracle.com> Message-ID: <58E5806E.3030004@oracle.com> Hi Jon, The second generation prototype is also currently using that structure for the tests. However, they may be combined to a single TEST.ROOT later on. HTH, -Joe On 4/5/2017 11:38 AM, Jonathan Gibbons wrote: > The consol-proto seems to have separate jtreg test suites (i.e. > separate TEST.ROOT files) for test/{jdk,langtools,...} > > Is that intentional, or just waiting to be fixed? > > -- Jon > > On 04/05/2017 09:51 AM, joe darcy wrote: >> FYI, follow-up discussions on this topic now occurring on jdk10-dev: >> >> "Coming soon: second generation prototype of Hg forest >> consolidation," >> http://mail.openjdk.java.net/pipermail/jdk10-dev/2017-April/000155.html >> >> -Joe >> >> >> On 10/14/2016 3:40 PM, joe darcy wrote: >>> On 10/10/2016 7:11 PM, joe darcy wrote: >>>> Hello, >>>> >>>> Looking ahead to JDK 10, a group of JDK engineers have been >>>> exploring consolidating the large number of Hg repositories in an >>>> open JDK forest to a single one with the goal of using the >>>> consolidated arrangement for JDK 10. >>>> >>>> This message is being sent to jdk9-dev since a jdk10-dev alias to >>>> discuss JDK 10 doesn't exist yet. >>>> >>>> A JEP describing the project has been submitted : >>>> >>>> JDK-8167368: Consolidate JDK 10 OpenJDK repositories to a >>>> single repository >>>> https://bugs.openjdk.java.net/browse/JDK-8167368 >>>> >>>> The text of the JEP describes the motivation and current state of >>>> the work in more detail, including proposed changes to the file >>>> layout. Publication of the prototype consolidated repository is >>>> planned, but not done yet. >>> >>> [snip] >>> >>> The prototype is now available from >>> >>> http://hg.openjdk.java.net/jdk9/consol-proto/ >>> >>> As implied by the tags, at present the prototype should be >>> functionally equivalent to jdk-9+138. >>> >>> Enjoy, >>> >>> -Joe >> > From erik.joelsson at oracle.com Thu Apr 6 07:53:27 2017 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Thu, 6 Apr 2017 09:53:27 +0200 Subject: Looking ahead: proposed Hg forest consolidation for JDK 10 -- prototype repo now on hg.openjdk.java.net In-Reply-To: <58E5806E.3030004@oracle.com> References: <4ea8f2e7-7a10-e949-d920-81ae5f610f24@oracle.com> <e01b1f53-3bf6-1786-f4af-b89271868c90@oracle.com> <407a62cd-1bd8-2a96-6ae5-3ec5d88ec5af@oracle.com> <58E539C2.7020100@oracle.com> <58E5806E.3030004@oracle.com> Message-ID: <f100c8d9-75b1-80e1-ec89-fcbdadc80238@oracle.com> Hello, Correct. For the conversion, I'm trying to keep changes other than file moves to a minimum since it will get complicated enough as it is. I definitely think we should unify the test roots in a follow up change, along with several cleanups and improvements to the build and test logic. /Erik On 2017-04-06 01:40, Joseph D. Darcy wrote: > Hi Jon, > > The second generation prototype is also currently using that structure > for the tests. However, they may be combined to a single TEST.ROOT > later on. > > HTH, > > -Joe > > On 4/5/2017 11:38 AM, Jonathan Gibbons wrote: >> The consol-proto seems to have separate jtreg test suites (i.e. >> separate TEST.ROOT files) for test/{jdk,langtools,...} >> >> Is that intentional, or just waiting to be fixed? >> >> -- Jon >> >> On 04/05/2017 09:51 AM, joe darcy wrote: >>> FYI, follow-up discussions on this topic now occurring on jdk10-dev: >>> >>> "Coming soon: second generation prototype of Hg forest >>> consolidation," >>> http://mail.openjdk.java.net/pipermail/jdk10-dev/2017-April/000155.html >>> >>> -Joe >>> >>> >>> On 10/14/2016 3:40 PM, joe darcy wrote: >>>> On 10/10/2016 7:11 PM, joe darcy wrote: >>>>> Hello, >>>>> >>>>> Looking ahead to JDK 10, a group of JDK engineers have been >>>>> exploring consolidating the large number of Hg repositories in an >>>>> open JDK forest to a single one with the goal of using the >>>>> consolidated arrangement for JDK 10. >>>>> >>>>> This message is being sent to jdk9-dev since a jdk10-dev alias to >>>>> discuss JDK 10 doesn't exist yet. >>>>> >>>>> A JEP describing the project has been submitted : >>>>> >>>>> JDK-8167368: Consolidate JDK 10 OpenJDK repositories to a >>>>> single repository >>>>> https://bugs.openjdk.java.net/browse/JDK-8167368 >>>>> >>>>> The text of the JEP describes the motivation and current state of >>>>> the work in more detail, including proposed changes to the file >>>>> layout. Publication of the prototype consolidated repository is >>>>> planned, but not done yet. >>>> >>>> [snip] >>>> >>>> The prototype is now available from >>>> >>>> http://hg.openjdk.java.net/jdk9/consol-proto/ >>>> >>>> As implied by the tags, at present the prototype should be >>>> functionally equivalent to jdk-9+138. >>>> >>>> Enjoy, >>>> >>>> -Joe >>> >> > From mikael.vidstedt at oracle.com Fri Apr 7 16:45:39 2017 From: mikael.vidstedt at oracle.com (Mikael Vidstedt) Date: Fri, 7 Apr 2017 09:45:39 -0700 Subject: How to handle future backports from JDK 10 into JDK 9? In-Reply-To: <58E2E404.3020901@oracle.com> References: <49f8daf7-6c15-dec9-92e3-ef76dc6f2afb@oracle.com> <58db6d43-3457-8bd9-bb04-3ab01aeb64e7@oracle.com> <5df4217f-0a88-4938-a06f-e00176a5153b@oracle.com> <3729188d-aa28-25bf-efaf-e74acc19437a@oracle.com> <c3a49adf-7746-8883-1544-267e51ea637c@oracle.com> <a1844d9b-eeba-8f09-4b95-645284333719@oracle.com> <a89154ec-64db-1718-67de-de5bfb8af0f9@oracle.com> <e833b500-e77e-e5d1-8406-08bfdf2006a0@oracle.com> <3815dda4-c612-dd5a-547f-553477fad5d7@oracle.com> <2a244a55-3576-1c69-b3c5-f0331df20f6c@oracle.com> <77bbab8f-854a-e718-8d5c-e85faa8cc4f0@oracle.com> <e5bf529f-7803-1ce6-64f5-cc02199712fa@oracle.com> <58E2E404.3020901@oracle.com> Message-ID: <8191D9AE-0F63-4395-8D41-724BA1AA5EB8@oracle.com> Joe, Please go ahead with the suggested change. Let?s keep our eyes open to see what kinds of problems we run into and course correct if needed! Cheers, Mikael > On Apr 3, 2017, at 5:08 PM, Joseph D. Darcy <joe.darcy at oracle.com> wrote: > > Hello, > > Last call for objections to disabling the unique bug id check in JDK 10. > > Thanks, > > -Joe > > On 3/27/2017 10:11 AM, joe darcy wrote: >> Hello David and others, >> >> Returning to this topic, I concede there are exceptional cases where backporting some functionality under a different bug id may be reasonable. However, I don't think such rare cases should drive larger decisions of handling forward and backports in 9 and 10 and whether or not the duplicate bug id check should be disabled in JDK 10. >> >> While the bug id check does prevent the error of accidentally reusing a bug id, it does not prevent many other classes of errors around bug ids, such as swapped digit typos. (Sharing of scripts to do such checks pre-push welcome.) Additionally, the duplicate bug id check causes complications, including the topic under discussion now, as well as for the possible repository consolidation. That check has been disabled in the update releases for years without problems. >> >> Therefore, on the whole, I think it would be a net benefit to disable the duplicate bug id check for JDK 10 too. >> >> Cheers, >> >> -Joe >> >> >> On 2/21/2017 7:05 PM, David Holmes wrote: >>> Hi Joe, >>> >>> From my own observation/experience the "why" we would create a new bug to "backport" something is when the something is not neatly packaged and obtainable through direct backports of specific issues. Take an example of an issue that is fixed but is buggy and has quite a lengthy bugtail - once it is reliable you want to backport it to an earlier release. Do you backport each individual bug (some of which may not even apply to the earlier release) or do you backport the resulting functionality that was finally obtained? There are pros and cons to both approaches - neither is clean nor ideal. Such is life. >>> >>> Cheers, >>> David >>> ----- > > [snip] From joe.darcy at oracle.com Mon Apr 10 16:42:56 2017 From: joe.darcy at oracle.com (joe darcy) Date: Mon, 10 Apr 2017 09:42:56 -0700 Subject: Coming soon: second generation prototype of Hg forest consolidation In-Reply-To: <732ba4ba-5538-9afb-8d29-24d7911d1baf@oracle.com> References: <732ba4ba-5538-9afb-8d29-24d7911d1baf@oracle.com> Message-ID: <504a500e-f913-627d-b642-c02e88c22292@oracle.com> Hello, Second generation prototype now available from http://hg.openjdk.java.net/jdk10/consol-proto/ Sources equivalent to JDK 9 b161. Thanks, -Joe On 4/5/2017 9:44 AM, joe darcy wrote: > Hello, > > As previously discussed [1], we've been exploring consolidating the > many repositories in an OpenJDK Hg forest (jdk, langtools, hotspot, > ...) into a single repository for JDK 10. The initial prototype of a > consolidated repo [2], equivalent to JDK 9 build 138, was published in > October 2016. > > Erik Joelsson has been working on a refined version of the > consolidation repo and we plan to publish this second generation > prototype in the near future. The new prototype presents a more > faithful view of the sources between tags for promoted builds and > provides a cleaner overall file layout. > > The corresponding JEP [3] will be updated to reflect the details of > the new prototype in due course. > > Cheers, > > -Joe > > [1] "Looking ahead: proposed Hg forest consolidation for JDK 10," > http://mail.openjdk.java.net/pipermail/jdk9-dev/2016-October/004987.html > > [2] http://hg.openjdk.java.net/jdk9/consol-proto/ > > [3] JEP 296: Consolidate the JDK Forest into a Single Repository > http://openjdk.java.net/jeps/296 > From stefan.karlsson at oracle.com Mon Apr 10 17:47:26 2017 From: stefan.karlsson at oracle.com (Stefan Karlsson) Date: Mon, 10 Apr 2017 19:47:26 +0200 Subject: Coming soon: second generation prototype of Hg forest consolidation In-Reply-To: <504a500e-f913-627d-b642-c02e88c22292@oracle.com> References: <732ba4ba-5538-9afb-8d29-24d7911d1baf@oracle.com> <504a500e-f913-627d-b642-c02e88c22292@oracle.com> Message-ID: <fe23f156-86ca-b272-4b5f-b981edd7cc00@oracle.com> Hi all, Great to see that the consolidation work is going forward! I have comment specific to the HotSpot code layout: We previously had this layout (using a small set of directories as an example): hotspot/src/share/vm hotspot/src/os/linux/vm hotspot/src/os/solaris/vm hotspot/src/os/solaris/dtrace hotspot/src/os/bsd/launcher hotspot/src/share/tools/hsdis and this is the new layout: src/hotspot/share/vm src/hotspot/os/linux/vm src/hotspot/os/solaris/vm src/hotspot/os/solaris/dtrace src/hotspot/os/bsd/launcher src/hotspot/share/tools/hsdis should we consider changing the layout of the HotSpot code so that we don't mix the source code for the vm, tools, launcher? For example: src/hotspot/vm/share src/hotspot/vm/os/linux src/hotspot/vm/os/solaris src/hotspot/launcher/os/bsd src/hotspot/tools/hsdis src/hotspot/dtrace/os/solaris I'm not sure that we would want to include such a change in the consolidation effort, but we are changing all file paths so maybe it's the right time to think about this. Cheers, StefanK On 10/04/17 18:42, joe darcy wrote: > Hello, > > Second generation prototype now available from > > http://hg.openjdk.java.net/jdk10/consol-proto/ > > Sources equivalent to JDK 9 b161. > > Thanks, > > -Joe > > > On 4/5/2017 9:44 AM, joe darcy wrote: >> Hello, >> >> As previously discussed [1], we've been exploring consolidating the >> many repositories in an OpenJDK Hg forest (jdk, langtools, hotspot, >> ...) into a single repository for JDK 10. The initial prototype of a >> consolidated repo [2], equivalent to JDK 9 build 138, was published >> in October 2016. >> >> Erik Joelsson has been working on a refined version of the >> consolidation repo and we plan to publish this second generation >> prototype in the near future. The new prototype presents a more >> faithful view of the sources between tags for promoted builds and >> provides a cleaner overall file layout. >> >> The corresponding JEP [3] will be updated to reflect the details of >> the new prototype in due course. >> >> Cheers, >> >> -Joe >> >> [1] "Looking ahead: proposed Hg forest consolidation for JDK 10," >> http://mail.openjdk.java.net/pipermail/jdk9-dev/2016-October/004987.html >> >> [2] http://hg.openjdk.java.net/jdk9/consol-proto/ >> >> [3] JEP 296: Consolidate the JDK Forest into a Single Repository >> http://openjdk.java.net/jeps/296 >> > From erik.joelsson at oracle.com Tue Apr 11 09:35:08 2017 From: erik.joelsson at oracle.com (Erik Joelsson) Date: Tue, 11 Apr 2017 11:35:08 +0200 Subject: Coming soon: second generation prototype of Hg forest consolidation In-Reply-To: <fe23f156-86ca-b272-4b5f-b981edd7cc00@oracle.com> References: <732ba4ba-5538-9afb-8d29-24d7911d1baf@oracle.com> <504a500e-f913-627d-b642-c02e88c22292@oracle.com> <fe23f156-86ca-b272-4b5f-b981edd7cc00@oracle.com> Message-ID: <332f9add-fbc6-001d-cdf8-40580d4282c1@oracle.com> Hello, We could certainly take this opportunity to do so. Moving all the files around has a pretty big cost in history size in the repository, so when doing large moves like this, it's good to get things as right as possible in one go. (Will talk to you about details offline) /Erik On 2017-04-10 19:47, Stefan Karlsson wrote: > Hi all, > > Great to see that the consolidation work is going forward! > > I have comment specific to the HotSpot code layout: > > We previously had this layout (using a small set of directories as an > example): > hotspot/src/share/vm > hotspot/src/os/linux/vm > hotspot/src/os/solaris/vm > hotspot/src/os/solaris/dtrace > hotspot/src/os/bsd/launcher > hotspot/src/share/tools/hsdis > > and this is the new layout: > src/hotspot/share/vm > src/hotspot/os/linux/vm > src/hotspot/os/solaris/vm > src/hotspot/os/solaris/dtrace > src/hotspot/os/bsd/launcher > src/hotspot/share/tools/hsdis > > should we consider changing the layout of the HotSpot code so that we > don't mix the source code for the vm, tools, launcher? For example: > src/hotspot/vm/share > src/hotspot/vm/os/linux > src/hotspot/vm/os/solaris > src/hotspot/launcher/os/bsd > src/hotspot/tools/hsdis > src/hotspot/dtrace/os/solaris > > I'm not sure that we would want to include such a change in the > consolidation effort, but we are changing all file paths so maybe it's > the right time to think about this. > > Cheers, > StefanK > > On 10/04/17 18:42, joe darcy wrote: >> Hello, >> >> Second generation prototype now available from >> >> http://hg.openjdk.java.net/jdk10/consol-proto/ >> >> Sources equivalent to JDK 9 b161. >> >> Thanks, >> >> -Joe >> >> >> On 4/5/2017 9:44 AM, joe darcy wrote: >>> Hello, >>> >>> As previously discussed [1], we've been exploring consolidating the >>> many repositories in an OpenJDK Hg forest (jdk, langtools, hotspot, >>> ...) into a single repository for JDK 10. The initial prototype of a >>> consolidated repo [2], equivalent to JDK 9 build 138, was published >>> in October 2016. >>> >>> Erik Joelsson has been working on a refined version of the >>> consolidation repo and we plan to publish this second generation >>> prototype in the near future. The new prototype presents a more >>> faithful view of the sources between tags for promoted builds and >>> provides a cleaner overall file layout. >>> >>> The corresponding JEP [3] will be updated to reflect the details of >>> the new prototype in due course. >>> >>> Cheers, >>> >>> -Joe >>> >>> [1] "Looking ahead: proposed Hg forest consolidation for JDK 10," >>> http://mail.openjdk.java.net/pipermail/jdk9-dev/2016-October/004987.html >>> >>> >>> [2] http://hg.openjdk.java.net/jdk9/consol-proto/ >>> >>> [3] JEP 296: Consolidate the JDK Forest into a Single Repository >>> http://openjdk.java.net/jeps/296 >>> >> > From david.holmes at oracle.com Tue Apr 11 09:48:12 2017 From: david.holmes at oracle.com (David Holmes) Date: Tue, 11 Apr 2017 19:48:12 +1000 Subject: Coming soon: second generation prototype of Hg forest consolidation In-Reply-To: <fe23f156-86ca-b272-4b5f-b981edd7cc00@oracle.com> References: <732ba4ba-5538-9afb-8d29-24d7911d1baf@oracle.com> <504a500e-f913-627d-b642-c02e88c22292@oracle.com> <fe23f156-86ca-b272-4b5f-b981edd7cc00@oracle.com> Message-ID: <41a5a3d8-e867-c92a-5654-703dc19a397f@oracle.com> Hi Stefan, On 11/04/2017 3:47 AM, Stefan Karlsson wrote: > Hi all, > > Great to see that the consolidation work is going forward! > > I have comment specific to the HotSpot code layout: > > We previously had this layout (using a small set of directories as an > example): > hotspot/src/share/vm > hotspot/src/os/linux/vm > hotspot/src/os/solaris/vm > hotspot/src/os/solaris/dtrace > hotspot/src/os/bsd/launcher > hotspot/src/share/tools/hsdis > > and this is the new layout: > src/hotspot/share/vm > src/hotspot/os/linux/vm > src/hotspot/os/solaris/vm > src/hotspot/os/solaris/dtrace > src/hotspot/os/bsd/launcher > src/hotspot/share/tools/hsdis > > should we consider changing the layout of the HotSpot code so that we > don't mix the source code for the vm, tools, launcher? For example: > src/hotspot/vm/share > src/hotspot/vm/os/linux > src/hotspot/vm/os/solaris > src/hotspot/launcher/os/bsd > src/hotspot/tools/hsdis > src/hotspot/dtrace/os/solaris > > I'm not sure that we would want to include such a change in the > consolidation effort, but we are changing all file paths so maybe it's > the right time to think about this. Not sure what you mean about "mix the source code" but I much prefer the familiar hotspot layout: - share - os - os_cpu etc Cheers, David > Cheers, > StefanK > > On 10/04/17 18:42, joe darcy wrote: >> Hello, >> >> Second generation prototype now available from >> >> http://hg.openjdk.java.net/jdk10/consol-proto/ >> >> Sources equivalent to JDK 9 b161. >> >> Thanks, >> >> -Joe >> >> >> On 4/5/2017 9:44 AM, joe darcy wrote: >>> Hello, >>> >>> As previously discussed [1], we've been exploring consolidating the >>> many repositories in an OpenJDK Hg forest (jdk, langtools, hotspot, >>> ...) into a single repository for JDK 10. The initial prototype of a >>> consolidated repo [2], equivalent to JDK 9 build 138, was published >>> in October 2016. >>> >>> Erik Joelsson has been working on a refined version of the >>> consolidation repo and we plan to publish this second generation >>> prototype in the near future. The new prototype presents a more >>> faithful view of the sources between tags for promoted builds and >>> provides a cleaner overall file layout. >>> >>> The corresponding JEP [3] will be updated to reflect the details of >>> the new prototype in due course. >>> >>> Cheers, >>> >>> -Joe >>> >>> [1] "Looking ahead: proposed Hg forest consolidation for JDK 10," >>> http://mail.openjdk.java.net/pipermail/jdk9-dev/2016-October/004987.html >>> >>> [2] http://hg.openjdk.java.net/jdk9/consol-proto/ >>> >>> [3] JEP 296: Consolidate the JDK Forest into a Single Repository >>> http://openjdk.java.net/jeps/296 >>> >> > From magnus.ihse.bursie at oracle.com Tue Apr 11 10:24:43 2017 From: magnus.ihse.bursie at oracle.com (Magnus Ihse Bursie) Date: Tue, 11 Apr 2017 12:24:43 +0200 Subject: Coming soon: second generation prototype of Hg forest consolidation In-Reply-To: <fe23f156-86ca-b272-4b5f-b981edd7cc00@oracle.com> References: <732ba4ba-5538-9afb-8d29-24d7911d1baf@oracle.com> <504a500e-f913-627d-b642-c02e88c22292@oracle.com> <fe23f156-86ca-b272-4b5f-b981edd7cc00@oracle.com> Message-ID: <77f64312-85e3-ecc3-6efe-371e343844f0@oracle.com> I think it sounds like a good idea to refresh the hotspot source structure. However, I think we can be much more radical. :-) If hotspot were to fully fold into the rest of the source structure, the majority of the source code would end up in: src/java.base/share/native/libjvm (and src/java.base/solaris/native/libjvm, src/java.base/x86/native/libjvm, etc...) I realize that might be a bit hard to swallow :-). With that in mind however, let's consider "src/hotspot" a shortcut for "src/java.base/*/native/libjvm", and create: * src/hotspot/share, * src/hotspot/solaris * src/hotspot/x86 * src/hotspot/linux_aarch64 * etc... which then would just contain the libjvm sources. That would create succinct paths to all vm source code, and let "hotspot" be synonymous with "libjvm" in this new source structure. As for the rest of the "non-vm" directories in the current structure, they are not too many and can easily be relocated to better homes. Let's break it down! * launcher: It's just a single file, bsd/launcher/Info-privileged.plist. It's not even used in the build. It is (or at least should be) identical to jdk/src/java.base/macosx/native/launcher/Info-privileged.plist, which *is* used in the build. Just remove it. * os/posix/dtrace: Three *.d files, used in the gensrc stage of hotspot compilation. Their presence is essential for hotspot compilation to succeed if dtrace is enabled, so they should not be considered separate from the VM. They could move to for instance src/hotspot/posix, or possibly src/hotspot/share/utilities, next to dtrace.hpp. * os/bsd/dtrace: Is not used. This is just remnants of the old macosx port from solaris. Can be safely deleted. * os/solaris/dtrace: Here are four C/C++ files. Two of them are used to create a build helper, and should move to make/hotspot/src/native. One is used to build libjvm_dtrace and one to build libjvm_db. According to the standard used elsewhere, they should reside in separate directories named after the resulting library. If "src/hotspot" is used as a shortcut for "src/java.base/*/native/libjvm", then, these files should move to "src/java.base/solaris/native/libjvm_dtrace" and "src/java.base/*/native/libjvm_db". Alternatively, let "src/hotspot" be used just as an alias for "src/java.base/*/native", and put them in "src/hotspot/solaris/libjvm_db", and the VM sources in "src/hotspot/*/libjvm" instead. * hsdis, IdealGraphVisualizer and LogCompilation These are stand-alone utilities that are not built as part of the normal build process. "Co-located tools", if you want. We have a couple of similar tools in jdk/make/non-build-utils (or make/jdk/non-build-utils in the proposed new layout). Perhaps all of those deserve a better home, like "src/utils" or "src/stand-alone-tools"? If that's not acceptable, I suggest crammingthe hotspot/share/tools into jdk/hotspot/non-build-utils, analog to the jdk tools. And then finally we have: * jsig.c: This is a file that currently resides in ./src/os/*/vm/jsig.c, but shouldn't be. It's explicitly excluded from all hotspot builds, and instead used to build libjsig. It should reside in "src/java.base/*/native/libjsig" (or "src/hotspot/*/libjsig"). /Magnus On 2017-04-10 19:47, Stefan Karlsson wrote: > Hi all, > > Great to see that the consolidation work is going forward! > > I have comment specific to the HotSpot code layout: > > We previously had this layout (using a small set of directories as an > example): > hotspot/src/share/vm > hotspot/src/os/linux/vm > hotspot/src/os/solaris/vm > hotspot/src/os/solaris/dtrace > hotspot/src/os/bsd/launcher > hotspot/src/share/tools/hsdis > > and this is the new layout: > src/hotspot/share/vm > src/hotspot/os/linux/vm > src/hotspot/os/solaris/vm > src/hotspot/os/solaris/dtrace > src/hotspot/os/bsd/launcher > src/hotspot/share/tools/hsdis > > should we consider changing the layout of the HotSpot code so that we > don't mix the source code for the vm, tools, launcher? For example: > src/hotspot/vm/share > src/hotspot/vm/os/linux > src/hotspot/vm/os/solaris > src/hotspot/launcher/os/bsd > src/hotspot/tools/hsdis > src/hotspot/dtrace/os/solaris > > I'm not sure that we would want to include such a change in the > consolidation effort, but we are changing all file paths so maybe it's > the right time to think about this. > > Cheers, > StefanK > > On 10/04/17 18:42, joe darcy wrote: >> Hello, >> >> Second generation prototype now available from >> >> http://hg.openjdk.java.net/jdk10/consol-proto/ >> >> Sources equivalent to JDK 9 b161. >> >> Thanks, >> >> -Joe >> >> >> On 4/5/2017 9:44 AM, joe darcy wrote: >>> Hello, >>> >>> As previously discussed [1], we've been exploring consolidating the >>> many repositories in an OpenJDK Hg forest (jdk, langtools, hotspot, >>> ...) into a single repository for JDK 10. The initial prototype of a >>> consolidated repo [2], equivalent to JDK 9 build 138, was published >>> in October 2016. >>> >>> Erik Joelsson has been working on a refined version of the >>> consolidation repo and we plan to publish this second generation >>> prototype in the near future. The new prototype presents a more >>> faithful view of the sources between tags for promoted builds and >>> provides a cleaner overall file layout. >>> >>> The corresponding JEP [3] will be updated to reflect the details of >>> the new prototype in due course. >>> >>> Cheers, >>> >>> -Joe >>> >>> [1] "Looking ahead: proposed Hg forest consolidation for JDK 10," >>> http://mail.openjdk.java.net/pipermail/jdk9-dev/2016-October/004987.html >>> >>> >>> [2] http://hg.openjdk.java.net/jdk9/consol-proto/ >>> >>> [3] JEP 296: Consolidate the JDK Forest into a Single Repository >>> http://openjdk.java.net/jeps/296 >>> >> > From claes.redestad at oracle.com Tue Apr 11 10:45:05 2017 From: claes.redestad at oracle.com (Claes Redestad) Date: Tue, 11 Apr 2017 12:45:05 +0200 Subject: Coming soon: second generation prototype of Hg forest consolidation In-Reply-To: <41a5a3d8-e867-c92a-5654-703dc19a397f@oracle.com> References: <732ba4ba-5538-9afb-8d29-24d7911d1baf@oracle.com> <504a500e-f913-627d-b642-c02e88c22292@oracle.com> <fe23f156-86ca-b272-4b5f-b981edd7cc00@oracle.com> <41a5a3d8-e867-c92a-5654-703dc19a397f@oracle.com> Message-ID: <db359f1f-20bb-5afc-25b1-3888434f7659@oracle.com> On 04/11/2017 11:48 AM, David Holmes wrote: > Hi Stefan, > > On 11/04/2017 3:47 AM, Stefan Karlsson wrote: >> Hi all, >> >> Great to see that the consolidation work is going forward! >> >> I have comment specific to the HotSpot code layout: >> >> We previously had this layout (using a small set of directories as an >> example): >> hotspot/src/share/vm >> hotspot/src/os/linux/vm >> hotspot/src/os/solaris/vm >> hotspot/src/os/solaris/dtrace >> hotspot/src/os/bsd/launcher >> hotspot/src/share/tools/hsdis >> >> and this is the new layout: >> src/hotspot/share/vm >> src/hotspot/os/linux/vm >> src/hotspot/os/solaris/vm >> src/hotspot/os/solaris/dtrace >> src/hotspot/os/bsd/launcher >> src/hotspot/share/tools/hsdis >> >> should we consider changing the layout of the HotSpot code so that we >> don't mix the source code for the vm, tools, launcher? For example: >> src/hotspot/vm/share >> src/hotspot/vm/os/linux >> src/hotspot/vm/os/solaris >> src/hotspot/launcher/os/bsd >> src/hotspot/tools/hsdis >> src/hotspot/dtrace/os/solaris >> >> I'm not sure that we would want to include such a change in the >> consolidation effort, but we are changing all file paths so maybe it's >> the right time to think about this. > > Not sure what you mean about "mix the source code" but I much prefer > the familiar hotspot layout: > - share > - os > - os_cpu > etc Familiar isn't necessarily good - my outsider perspective is that the layout that Stefan proposes seems the more natural grouping when exploring the code: hotspot is built up of vm, launcher, tools, dtrace, each of which *can* have shared and specialized implementations. The current structure requires a newbie to look in four or more seemingly unrelated trees to even start getting a grasp on where the meat is at, while the proposal would make it immediately obvious that, say, hsdis is all just in one place, which is a big win when on-boarding developers to a code base that is already quite challenging to get familiar with. $.02 /Claes From magnus.ihse.bursie at oracle.com Tue Apr 11 10:55:22 2017 From: magnus.ihse.bursie at oracle.com (Magnus Ihse Bursie) Date: Tue, 11 Apr 2017 12:55:22 +0200 Subject: Coming soon: second generation prototype of Hg forest consolidation In-Reply-To: <db359f1f-20bb-5afc-25b1-3888434f7659@oracle.com> References: <732ba4ba-5538-9afb-8d29-24d7911d1baf@oracle.com> <504a500e-f913-627d-b642-c02e88c22292@oracle.com> <fe23f156-86ca-b272-4b5f-b981edd7cc00@oracle.com> <41a5a3d8-e867-c92a-5654-703dc19a397f@oracle.com> <db359f1f-20bb-5afc-25b1-3888434f7659@oracle.com> Message-ID: <32dedf6b-48a4-1051-6e39-6b1af67cbbc9@oracle.com> On 2017-04-11 12:45, Claes Redestad wrote: > > On 04/11/2017 11:48 AM, David Holmes wrote: >> Hi Stefan, >> >> On 11/04/2017 3:47 AM, Stefan Karlsson wrote: >>> Hi all, >>> >>> Great to see that the consolidation work is going forward! >>> >>> I have comment specific to the HotSpot code layout: >>> >>> We previously had this layout (using a small set of directories as an >>> example): >>> hotspot/src/share/vm >>> hotspot/src/os/linux/vm >>> hotspot/src/os/solaris/vm >>> hotspot/src/os/solaris/dtrace >>> hotspot/src/os/bsd/launcher >>> hotspot/src/share/tools/hsdis >>> >>> and this is the new layout: >>> src/hotspot/share/vm >>> src/hotspot/os/linux/vm >>> src/hotspot/os/solaris/vm >>> src/hotspot/os/solaris/dtrace >>> src/hotspot/os/bsd/launcher >>> src/hotspot/share/tools/hsdis >>> >>> should we consider changing the layout of the HotSpot code so that we >>> don't mix the source code for the vm, tools, launcher? For example: >>> src/hotspot/vm/share >>> src/hotspot/vm/os/linux >>> src/hotspot/vm/os/solaris >>> src/hotspot/launcher/os/bsd >>> src/hotspot/tools/hsdis >>> src/hotspot/dtrace/os/solaris >>> >>> I'm not sure that we would want to include such a change in the >>> consolidation effort, but we are changing all file paths so maybe it's >>> the right time to think about this. >> >> Not sure what you mean about "mix the source code" but I much prefer >> the familiar hotspot layout: >> - share >> - os >> - os_cpu >> etc > > Familiar isn't necessarily good - my outsider perspective is that the > layout that > Stefan proposes seems the more natural grouping when exploring the code: > hotspot is built up of vm, launcher, tools, dtrace, each of which > *can* have > shared and specialized implementations. Which really is completely misleading. Hotspot is made up of the libjvm. Period. The rest is just small, more or less irrelevant utilities, or misplaced/forgotten code. I think a new code structure which does not give this fact proper weight would be unfortunate. (Just to be clear, I agree with you but think you must go one step further.) /Magnus > > The current structure requires a newbie to look in four or more seemingly > unrelated trees to even start getting a grasp on where the meat is at, > while the > proposal would make it immediately obvious that, say, hsdis is all > just in one place, > which is a big win when on-boarding developers to a code base that is > already > quite challenging to get familiar with. > > $.02 > > /Claes > From igor.ignatyev at oracle.com Mon Apr 10 18:55:13 2017 From: igor.ignatyev at oracle.com (Igor Ignatyev) Date: Mon, 10 Apr 2017 11:55:13 -0700 Subject: Coming soon: second generation prototype of Hg forest consolidation In-Reply-To: <504a500e-f913-627d-b642-c02e88c22292@oracle.com> References: <732ba4ba-5538-9afb-8d29-24d7911d1baf@oracle.com> <504a500e-f913-627d-b642-c02e88c22292@oracle.com> Message-ID: <BCEC5221-3E73-49A2-870E-C3E5E20DDF73@oracle.com> (moved to hotspot-dev alias) Hi Erik, I have a question about test/hotspot layout. when we started jep 281[1], we deliberately selected not to use harness/framework names in directory and the proposed the following layout for hotspot tests was > For clarity the tests should not be mixed with existing jtreg tests; instead, they should be split in two directories. We propose to split the current jdk9/hotspot/test directory into two subdirectories: > ? jdk9/hotspot/test/java > ? jdk9/hotspot/test/native now the consolidated repo[2] has test/hotspot/jtreg and test/hotspot/gtest and directories. hence I'm wondering why you have renamed the directories, there were any problems w/ the originally proposed layout? Thanks, -- Igor [1] JEP 281: HotSpot C++ Unit-Test Framework http://openjdk.java.net/jeps/281 <http://openjdk.java.net/jeps/281> [2] http://hg.openjdk.java.net/jdk10/consol-proto/file/9ea8bfbbe49b/test/hotspot > On Apr 10, 2017, at 9:42 AM, joe darcy <joe.darcy at oracle.com> wrote: > > Hello, > > Second generation prototype now available from > > http://hg.openjdk.java.net/jdk10/consol-proto/ > > Sources equivalent to JDK 9 b161. > > Thanks, > > -Joe > > > On 4/5/2017 9:44 AM, joe darcy wrote: >> Hello, >> >> As previously discussed [1], we've been exploring consolidating the many repositories in an OpenJDK Hg forest (jdk, langtools, hotspot, ...) into a single repository for JDK 10. The initial prototype of a consolidated repo [2], equivalent to JDK 9 build 138, was published in October 2016. >> >> Erik Joelsson has been working on a refined version of the consolidation repo and we plan to publish this second generation prototype in the near future. The new prototype presents a more faithful view of the sources between tags for promoted builds and provides a cleaner overall file layout. >> >> The corresponding JEP [3] will be updated to reflect the details of the new prototype in due course. >> >> Cheers, >> >> -Joe >> >> [1] "Looking ahead: proposed Hg forest consolidation for JDK 10," >> http://mail.openjdk.java.net/pipermail/jdk9-dev/2016-October/004987.html >> >> [2] http://hg.openjdk.java.net/jdk9/consol-proto/ >> >> [3] JEP 296: Consolidate the JDK Forest into a Single Repository >> http://openjdk.java.net/jeps/296 >> > From ramkri123 at gmail.com Wed Apr 12 21:55:54 2017 From: ramkri123 at gmail.com (Ram Krishnan) Date: Wed, 12 Apr 2017 14:55:54 -0700 Subject: linux os processor optimizations for OpenJDK performance enhancement Message-ID: <CAKOuegA3cPEUni=NXo9hLLg=D6nq8+mFYeWAJpxtoBYdCC=6Hg@mail.gmail.com> We are working on linux os processor specific optimizations centered around cache partitioning and better processor core thread(s) affinity for OpenJDK GC performance enhancement with the following benefits - throughput increase - minimizing tail latency for latency sensitive applications - superior isolation in a multi-tenant environment ?We have been looking at the G1GC code/documentation and performed some initial experiments. Based on this, what we understand is that STW events pause all application threads independent of which regions are being impacted by garbage collection. For example, if application thread "x" uses regions 1, 4, 5 and garbage collection is working on regions 2 and 11, application thread "x" is paused during the STW event. Your expert opinion on this topic is much appreciated. -- Thanks ? in advance, Ramki From ramkri123 at gmail.com Wed Apr 12 23:39:26 2017 From: ramkri123 at gmail.com (Ram Krishnan) Date: Wed, 12 Apr 2017 16:39:26 -0700 Subject: linux os processor optimizations for OpenJDK performance enhancement Message-ID: <CAKOuegADN34Qpgs0Ycpe4zPt4qwHi3oi4VZffx6WcXw1ZeqkyQ@mail.gmail.com> We are working on linux os processor specific optimizations centered around cache partitioning and better processor core thread(s) affinity for OpenJDK GC performance enhancement with the following benefits - throughput increase - minimizing tail latency for latency sensitive applications - superior isolation in a multi-tenant environment ?We have been looking at the G1GC code/documentation and performed some initial experiments. Based on this, what we understand is that STW events pause all application threads independent of which regions are being impacted by garbage collection. For example, if application thread "x" uses regions 1, 4, 5 and garbage collection is working on regions 2 and 11, application thread "x" is paused during the STW event. Your expert opinion on this topic is much appreciated. -- Thanks ? in advance? , Ramki From david.holmes at oracle.com Thu Apr 13 01:26:11 2017 From: david.holmes at oracle.com (David Holmes) Date: Thu, 13 Apr 2017 11:26:11 +1000 Subject: linux os processor optimizations for OpenJDK performance enhancement In-Reply-To: <CAKOuegADN34Qpgs0Ycpe4zPt4qwHi3oi4VZffx6WcXw1ZeqkyQ@mail.gmail.com> References: <CAKOuegADN34Qpgs0Ycpe4zPt4qwHi3oi4VZffx6WcXw1ZeqkyQ@mail.gmail.com> Message-ID: <86d58d9d-ea45-6732-370f-413ff1b4e8f4@oracle.com> Redirecting to hotspot-dev mailing list, please drop jdk10-dev on future replies. On 13/04/2017 9:39 AM, Ram Krishnan wrote: > We are working on linux os processor specific optimizations centered around > cache partitioning and better processor core thread(s) affinity for OpenJDK > GC performance enhancement with the following benefits > - throughput increase > - minimizing tail latency for latency sensitive applications > - superior isolation in a multi-tenant environment > > ?We have been looking at the G1GC code/documentation and performed some > initial experiments. Based on this, what we understand is that STW events > pause all application threads independent of which regions are being > impacted by garbage collection. For example, if application thread "x" uses > regions 1, 4, 5 and garbage collection is working on regions 2 and 11, > application thread "x" is paused during the STW event. A stop-the-world event does stop all application threads (all JavaThreads in VM terminology) by using a safepoint. I'll let the GC folks comment on the details wrt. G1 region management. Cheers, David > Your expert opinion on this topic is much appreciated. > From igor.ignatyev at oracle.com Thu Apr 13 04:24:59 2017 From: igor.ignatyev at oracle.com (Igor Ignatyev) Date: Wed, 12 Apr 2017 21:24:59 -0700 Subject: CFV: New JDK 10 Reviewer: Kirill Zhaldybin Message-ID: <0AE012D4-578F-4308-A0B1-F96DA99E0909@oracle.com> I hereby nominate Kirill Zhaldybin (kzhaldyb) to JDK 10 Reviewer. Kirill is a member of VM SQE team. He led and implemented JEP 278 'Additional Tests for Humongous Objects in G1'. He also played significant role in JEP 281 'HotSpot C++ Unit-Test Framework' converting and improving existing internal VM tests to figure out and solve existing GTest problems. His work put basis in the future GTest guidelines. Besides mentioned projects, Kirill also did some other contributions in gc, runtime, compiler and serviceability. He contributed 57 changesets across hotspot[3], jdk[4] and root[5] repos. Votes are due by 26 April 2017, 22:00 PT. Only current JDK 10 Reviewers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Three-Vote Consensus voting instructions, see [2]. Igor Ignatyev [1] http://openjdk.java.net/census [2] http://openjdk.java.net/projects/#reviewer-vote [3] http://hg.openjdk.java.net/jdk10/hs/hotspot/log?revcount=2000&rev=%28%28author%28%22kzhaldyb%22%29+or+desc%28%22Contributed-by%3A+Kirill+Zhaldybin+%3Ckirill.zhaldybin%40oracle.com%3E%22%29%29%29+and+not+merge%28%29+and+not+desc%28%22Quarantine%22%29 [4] http://hg.openjdk.java.net/jdk10/hs/jdk/log?revcount=2000&rev=%28%28author%28%22kzhaldyb%22%29+or+desc%28%22Contributed-by%3A+Kirill+Zhaldybin+%3Ckirill.zhaldybin%40oracle.com%3E%22%29%29%29+and+not+merge%28%29+and+not+desc%28%22Quarantine%22%29 [5] http://hg.openjdk.java.net/jdk10/hs/log?revcount=2000&rev=%28%28author%28%22kzhaldyb%22%29+or+desc%28%22Contributed-by%3A+Kirill+Zhaldybin+%3Ckirill.zhaldybin%40oracle.com%3E%22%29%29%29+and+not+merge%28%29+and+not+desc%28%22Quarantine%22%29 From igor.ignatyev at oracle.com Thu Apr 13 04:31:38 2017 From: igor.ignatyev at oracle.com (Igor Ignatyev) Date: Wed, 12 Apr 2017 21:31:38 -0700 Subject: CFV: New JDK 10 Reviewer: Kirill Zhaldybin In-Reply-To: <0AE012D4-578F-4308-A0B1-F96DA99E0909@oracle.com> References: <0AE012D4-578F-4308-A0B1-F96DA99E0909@oracle.com> Message-ID: <981BA114-3CDC-4ECD-9A0C-F5ADF8388A5B@oracle.com> Vote: yes -- Igor > On Apr 12, 2017, at 9:24 PM, Igor Ignatyev <igor.ignatyev at oracle.com> wrote: > > I hereby nominate Kirill Zhaldybin (kzhaldyb) to JDK 10 Reviewer. > > Kirill is a member of VM SQE team. He led and implemented JEP 278 'Additional Tests for Humongous Objects in G1'. He also played significant role in JEP 281 'HotSpot C++ Unit-Test Framework' converting and improving existing internal VM tests to figure out and solve existing GTest problems. His work put basis in the future GTest guidelines. Besides mentioned projects, Kirill also did some other contributions in gc, runtime, compiler and serviceability. He contributed 57 changesets across hotspot[3], jdk[4] and root[5] repos. > > Votes are due by 26 April 2017, 22:00 PT. > > Only current JDK 10 Reviewers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > For Three-Vote Consensus voting instructions, see [2]. > > Igor Ignatyev > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#reviewer-vote > [3] http://hg.openjdk.java.net/jdk10/hs/hotspot/log?revcount=2000&rev=%28%28author%28%22kzhaldyb%22%29+or+desc%28%22Contributed-by%3A+Kirill+Zhaldybin+%3Ckirill.zhaldybin%40oracle.com%3E%22%29%29%29+and+not+merge%28%29+and+not+desc%28%22Quarantine%22%29 > [4] http://hg.openjdk.java.net/jdk10/hs/jdk/log?revcount=2000&rev=%28%28author%28%22kzhaldyb%22%29+or+desc%28%22Contributed-by%3A+Kirill+Zhaldybin+%3Ckirill.zhaldybin%40oracle.com%3E%22%29%29%29+and+not+merge%28%29+and+not+desc%28%22Quarantine%22%29 > [5] http://hg.openjdk.java.net/jdk10/hs/log?revcount=2000&rev=%28%28author%28%22kzhaldyb%22%29+or+desc%28%22Contributed-by%3A+Kirill+Zhaldybin+%3Ckirill.zhaldybin%40oracle.com%3E%22%29%29%29+and+not+merge%28%29+and+not+desc%28%22Quarantine%22%29 > From david.holmes at oracle.com Thu Apr 13 07:01:26 2017 From: david.holmes at oracle.com (David Holmes) Date: Thu, 13 Apr 2017 17:01:26 +1000 Subject: CFV: New JDK 10 Reviewer: Kirill Zhaldybin In-Reply-To: <0AE012D4-578F-4308-A0B1-F96DA99E0909@oracle.com> References: <0AE012D4-578F-4308-A0B1-F96DA99E0909@oracle.com> Message-ID: <f16fd7de-7176-2bec-11cc-fbabad2c1049@oracle.com> Vote: yes David On 13/04/2017 2:24 PM, Igor Ignatyev wrote: > I hereby nominate Kirill Zhaldybin (kzhaldyb) to JDK 10 Reviewer. > > Kirill is a member of VM SQE team. He led and implemented JEP 278 'Additional Tests for Humongous Objects in G1'. He also played significant role in JEP 281 'HotSpot C++ Unit-Test Framework' converting and improving existing internal VM tests to figure out and solve existing GTest problems. His work put basis in the future GTest guidelines. Besides mentioned projects, Kirill also did some other contributions in gc, runtime, compiler and serviceability. He contributed 57 changesets across hotspot[3], jdk[4] and root[5] repos. > > Votes are due by 26 April 2017, 22:00 PT. > > Only current JDK 10 Reviewers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > For Three-Vote Consensus voting instructions, see [2]. > > Igor Ignatyev > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#reviewer-vote > [3] http://hg.openjdk.java.net/jdk10/hs/hotspot/log?revcount=2000&rev=%28%28author%28%22kzhaldyb%22%29+or+desc%28%22Contributed-by%3A+Kirill+Zhaldybin+%3Ckirill.zhaldybin%40oracle.com%3E%22%29%29%29+and+not+merge%28%29+and+not+desc%28%22Quarantine%22%29 > [4] http://hg.openjdk.java.net/jdk10/hs/jdk/log?revcount=2000&rev=%28%28author%28%22kzhaldyb%22%29+or+desc%28%22Contributed-by%3A+Kirill+Zhaldybin+%3Ckirill.zhaldybin%40oracle.com%3E%22%29%29%29+and+not+merge%28%29+and+not+desc%28%22Quarantine%22%29 > [5] http://hg.openjdk.java.net/jdk10/hs/log?revcount=2000&rev=%28%28author%28%22kzhaldyb%22%29+or+desc%28%22Contributed-by%3A+Kirill+Zhaldybin+%3Ckirill.zhaldybin%40oracle.com%3E%22%29%29%29+and+not+merge%28%29+and+not+desc%28%22Quarantine%22%29 > From serguei.spitsyn at oracle.com Thu Apr 13 09:12:58 2017 From: serguei.spitsyn at oracle.com (serguei.spitsyn at oracle.com) Date: Thu, 13 Apr 2017 02:12:58 -0700 Subject: CFV: New JDK 10 Reviewer: Kirill Zhaldybin In-Reply-To: <0AE012D4-578F-4308-A0B1-F96DA99E0909@oracle.com> References: <0AE012D4-578F-4308-A0B1-F96DA99E0909@oracle.com> Message-ID: <5f851e1d-f6fc-3802-789f-e40f2e145522@oracle.com> Vote: yes From vladimir.x.ivanov at oracle.com Thu Apr 13 09:44:25 2017 From: vladimir.x.ivanov at oracle.com (Vladimir Ivanov) Date: Thu, 13 Apr 2017 12:44:25 +0300 Subject: CFV: New JDK 10 Reviewer: Kirill Zhaldybin In-Reply-To: <0AE012D4-578F-4308-A0B1-F96DA99E0909@oracle.com> References: <0AE012D4-578F-4308-A0B1-F96DA99E0909@oracle.com> Message-ID: <eec68887-aea5-8b30-9c19-8ae70a55fed4@oracle.com> Vote: yes Best regards, Vladimir Ivanov On 4/13/17 7:24 AM, Igor Ignatyev wrote: > I hereby nominate Kirill Zhaldybin (kzhaldyb) to JDK 10 Reviewer. From zoltan.majo at oracle.com Thu Apr 13 12:02:25 2017 From: zoltan.majo at oracle.com (=?UTF-8?B?Wm9sdMOhbiBNYWrDsw==?=) Date: Thu, 13 Apr 2017 14:02:25 +0200 Subject: CFV: New JDK 10 Reviewer: Kirill Zhaldybin In-Reply-To: <0AE012D4-578F-4308-A0B1-F96DA99E0909@oracle.com> References: <0AE012D4-578F-4308-A0B1-F96DA99E0909@oracle.com> Message-ID: <faf26565-74bf-5e19-b3f8-5a9bf546aa66@oracle.com> Vote: yes. Best regards, Zolt?n From vladimir.kozlov at oracle.com Thu Apr 13 17:19:06 2017 From: vladimir.kozlov at oracle.com (Vladimir Kozlov) Date: Thu, 13 Apr 2017 10:19:06 -0700 Subject: CFV: New JDK 10 Reviewer: Kirill Zhaldybin In-Reply-To: <0AE012D4-578F-4308-A0B1-F96DA99E0909@oracle.com> References: <0AE012D4-578F-4308-A0B1-F96DA99E0909@oracle.com> Message-ID: <95d56490-abde-9238-1d58-74be41d44b3e@oracle.com> Vote: yes On 4/12/17 9:24 PM, Igor Ignatyev wrote: > I hereby nominate Kirill Zhaldybin (kzhaldyb) to JDK 10 Reviewer. > > Kirill is a member of VM SQE team. He led and implemented JEP 278 'Additional Tests for Humongous Objects in G1'. He also played significant role in JEP 281 'HotSpot C++ Unit-Test Framework' converting and improving existing internal VM tests to figure out and solve existing GTest problems. His work put basis in the future GTest guidelines. Besides mentioned projects, Kirill also did some other contributions in gc, runtime, compiler and serviceability. He contributed 57 changesets across hotspot[3], jdk[4] and root[5] repos. > > Votes are due by 26 April 2017, 22:00 PT. > > Only current JDK 10 Reviewers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > For Three-Vote Consensus voting instructions, see [2]. > > Igor Ignatyev > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#reviewer-vote > [3] http://hg.openjdk.java.net/jdk10/hs/hotspot/log?revcount=2000&rev=%28%28author%28%22kzhaldyb%22%29+or+desc%28%22Contributed-by%3A+Kirill+Zhaldybin+%3Ckirill.zhaldybin%40oracle.com%3E%22%29%29%29+and+not+merge%28%29+and+not+desc%28%22Quarantine%22%29 > [4] http://hg.openjdk.java.net/jdk10/hs/jdk/log?revcount=2000&rev=%28%28author%28%22kzhaldyb%22%29+or+desc%28%22Contributed-by%3A+Kirill+Zhaldybin+%3Ckirill.zhaldybin%40oracle.com%3E%22%29%29%29+and+not+merge%28%29+and+not+desc%28%22Quarantine%22%29 > [5] http://hg.openjdk.java.net/jdk10/hs/log?revcount=2000&rev=%28%28author%28%22kzhaldyb%22%29+or+desc%28%22Contributed-by%3A+Kirill+Zhaldybin+%3Ckirill.zhaldybin%40oracle.com%3E%22%29%29%29+and+not+merge%28%29+and+not+desc%28%22Quarantine%22%29 > From artem.smotrakov at oracle.com Thu Apr 13 18:13:47 2017 From: artem.smotrakov at oracle.com (Artem Smotrakov) Date: Thu, 13 Apr 2017 11:13:47 -0700 Subject: CFV: New JDK 10 Reviewer: Kirill Zhaldybin In-Reply-To: <0AE012D4-578F-4308-A0B1-F96DA99E0909@oracle.com> References: <0AE012D4-578F-4308-A0B1-F96DA99E0909@oracle.com> Message-ID: <39d7176a-22c9-7116-17cf-088656a6fb17@oracle.com> Vote: yes Artem On 04/12/2017 09:24 PM, Igor Ignatyev wrote: > I hereby nominate Kirill Zhaldybin (kzhaldyb) to JDK 10 Reviewer. > > Kirill is a member of VM SQE team. He led and implemented JEP 278 'Additional Tests for Humongous Objects in G1'. He also played significant role in JEP 281 'HotSpot C++ Unit-Test Framework' converting and improving existing internal VM tests to figure out and solve existing GTest problems. His work put basis in the future GTest guidelines. Besides mentioned projects, Kirill also did some other contributions in gc, runtime, compiler and serviceability. He contributed 57 changesets across hotspot[3], jdk[4] and root[5] repos. > > Votes are due by 26 April 2017, 22:00 PT. > > Only current JDK 10 Reviewers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > For Three-Vote Consensus voting instructions, see [2]. > > Igor Ignatyev > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#reviewer-vote > [3] http://hg.openjdk.java.net/jdk10/hs/hotspot/log?revcount=2000&rev=%28%28author%28%22kzhaldyb%22%29+or+desc%28%22Contributed-by%3A+Kirill+Zhaldybin+%3Ckirill.zhaldybin%40oracle.com%3E%22%29%29%29+and+not+merge%28%29+and+not+desc%28%22Quarantine%22%29 > [4] http://hg.openjdk.java.net/jdk10/hs/jdk/log?revcount=2000&rev=%28%28author%28%22kzhaldyb%22%29+or+desc%28%22Contributed-by%3A+Kirill+Zhaldybin+%3Ckirill.zhaldybin%40oracle.com%3E%22%29%29%29+and+not+merge%28%29+and+not+desc%28%22Quarantine%22%29 > [5] http://hg.openjdk.java.net/jdk10/hs/log?revcount=2000&rev=%28%28author%28%22kzhaldyb%22%29+or+desc%28%22Contributed-by%3A+Kirill+Zhaldybin+%3Ckirill.zhaldybin%40oracle.com%3E%22%29%29%29+and+not+merge%28%29+and+not+desc%28%22Quarantine%22%29 > From volker.simonis at gmail.com Thu Apr 13 18:55:03 2017 From: volker.simonis at gmail.com (Volker Simonis) Date: Thu, 13 Apr 2017 20:55:03 +0200 Subject: CFV: New JDK 10 Reviewer: Kirill Zhaldybin In-Reply-To: <0AE012D4-578F-4308-A0B1-F96DA99E0909@oracle.com> References: <0AE012D4-578F-4308-A0B1-F96DA99E0909@oracle.com> Message-ID: <CA+3eh12-PPY2DEmjZ=fe7LXYQ6ZuN3_9jM9ZxU3DvHhbcee1zA@mail.gmail.com> Vote: yes On Thu, Apr 13, 2017 at 6:24 AM, Igor Ignatyev <igor.ignatyev at oracle.com> wrote: > I hereby nominate Kirill Zhaldybin (kzhaldyb) to JDK 10 Reviewer. > > Kirill is a member of VM SQE team. He led and implemented JEP 278 'Additional Tests for Humongous Objects in G1'. He also played significant role in JEP 281 'HotSpot C++ Unit-Test Framework' converting and improving existing internal VM tests to figure out and solve existing GTest problems. His work put basis in the future GTest guidelines. Besides mentioned projects, Kirill also did some other contributions in gc, runtime, compiler and serviceability. He contributed 57 changesets across hotspot[3], jdk[4] and root[5] repos. > > Votes are due by 26 April 2017, 22:00 PT. > > Only current JDK 10 Reviewers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > For Three-Vote Consensus voting instructions, see [2]. > > Igor Ignatyev > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#reviewer-vote > [3] http://hg.openjdk.java.net/jdk10/hs/hotspot/log?revcount=2000&rev=%28%28author%28%22kzhaldyb%22%29+or+desc%28%22Contributed-by%3A+Kirill+Zhaldybin+%3Ckirill.zhaldybin%40oracle.com%3E%22%29%29%29+and+not+merge%28%29+and+not+desc%28%22Quarantine%22%29 > [4] http://hg.openjdk.java.net/jdk10/hs/jdk/log?revcount=2000&rev=%28%28author%28%22kzhaldyb%22%29+or+desc%28%22Contributed-by%3A+Kirill+Zhaldybin+%3Ckirill.zhaldybin%40oracle.com%3E%22%29%29%29+and+not+merge%28%29+and+not+desc%28%22Quarantine%22%29 > [5] http://hg.openjdk.java.net/jdk10/hs/log?revcount=2000&rev=%28%28author%28%22kzhaldyb%22%29+or+desc%28%22Contributed-by%3A+Kirill+Zhaldybin+%3Ckirill.zhaldybin%40oracle.com%3E%22%29%29%29+and+not+merge%28%29+and+not+desc%28%22Quarantine%22%29 > From tobias.hartmann at oracle.com Thu Apr 13 18:59:14 2017 From: tobias.hartmann at oracle.com (Tobias Hartmann) Date: Thu, 13 Apr 2017 20:59:14 +0200 Subject: CFV: New JDK 10 Reviewer: Kirill Zhaldybin In-Reply-To: <0AE012D4-578F-4308-A0B1-F96DA99E0909@oracle.com> References: <0AE012D4-578F-4308-A0B1-F96DA99E0909@oracle.com> Message-ID: <41337fd9-6701-2608-68b2-009be3fbe61d@oracle.com> Vote: yes Best regards, Tobias On 13.04.2017 06:24, Igor Ignatyev wrote: > I hereby nominate Kirill Zhaldybin (kzhaldyb) to JDK 10 Reviewer. > > Kirill is a member of VM SQE team. He led and implemented JEP 278 'Additional Tests for Humongous Objects in G1'. He also played significant role in JEP 281 'HotSpot C++ Unit-Test Framework' converting and improving existing internal VM tests to figure out and solve existing GTest problems. His work put basis in the future GTest guidelines. Besides mentioned projects, Kirill also did some other contributions in gc, runtime, compiler and serviceability. He contributed 57 changesets across hotspot[3], jdk[4] and root[5] repos. > > Votes are due by 26 April 2017, 22:00 PT. > > Only current JDK 10 Reviewers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > For Three-Vote Consensus voting instructions, see [2]. > > Igor Ignatyev > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#reviewer-vote > [3] http://hg.openjdk.java.net/jdk10/hs/hotspot/log?revcount=2000&rev=%28%28author%28%22kzhaldyb%22%29+or+desc%28%22Contributed-by%3A+Kirill+Zhaldybin+%3Ckirill.zhaldybin%40oracle.com%3E%22%29%29%29+and+not+merge%28%29+and+not+desc%28%22Quarantine%22%29 > [4] http://hg.openjdk.java.net/jdk10/hs/jdk/log?revcount=2000&rev=%28%28author%28%22kzhaldyb%22%29+or+desc%28%22Contributed-by%3A+Kirill+Zhaldybin+%3Ckirill.zhaldybin%40oracle.com%3E%22%29%29%29+and+not+merge%28%29+and+not+desc%28%22Quarantine%22%29 > [5] http://hg.openjdk.java.net/jdk10/hs/log?revcount=2000&rev=%28%28author%28%22kzhaldyb%22%29+or+desc%28%22Contributed-by%3A+Kirill+Zhaldybin+%3Ckirill.zhaldybin%40oracle.com%3E%22%29%29%29+and+not+merge%28%29+and+not+desc%28%22Quarantine%22%29 > From volker.simonis at gmail.com Tue Apr 18 13:03:18 2017 From: volker.simonis at gmail.com (Volker Simonis) Date: Tue, 18 Apr 2017 15:03:18 +0200 Subject: Result: New JDK 9/10 Reviewer: Thomas Stuefe Message-ID: <CA+3eh13AAZOe5cu7wSuV0_e_dModvpDU8FQLd42E7x-Q0vfK-Q@mail.gmail.com> Voting for Thomas Stuefe [1] is now closed. Yes: 20 Veto: 0 Abstain: 0 According to the Bylaws definition of Three-Vote Consensus, this is sufficient to approve the nomination. Regards, Volker [1] http://mail.openjdk.java.net/pipermail/jdk9-dev/2017-March/thread.html#5639 From volker.simonis at gmail.com Tue Apr 18 13:03:23 2017 From: volker.simonis at gmail.com (Volker Simonis) Date: Tue, 18 Apr 2017 15:03:23 +0200 Subject: Result: New JDK 9/10 Reviewer: Martin Doerr Message-ID: <CA+3eh10jXDpdF4KjbnWb-zxYu2ZdTL-TfgtWGDFWNKMXBtSw-g@mail.gmail.com> Voting for Martin Doerr [1] is now closed. Yes: 21 Veto: 0 Abstain: 0 According to the Bylaws definition of Three-Vote Consensus, this is sufficient to approve the nomination. Regards, Volker [1] http://mail.openjdk.java.net/pipermail/jdk9-dev/2017-March/thread.html#5640 From jesper.wilhelmsson at oracle.com Tue Apr 18 21:07:24 2017 From: jesper.wilhelmsson at oracle.com (jesper.wilhelmsson at oracle.com) Date: Tue, 18 Apr 2017 23:07:24 +0200 Subject: CFV: New JDK 10 Reviewer: Kirill Zhaldybin In-Reply-To: <0AE012D4-578F-4308-A0B1-F96DA99E0909@oracle.com> References: <0AE012D4-578F-4308-A0B1-F96DA99E0909@oracle.com> Message-ID: <3378B555-C414-4ACC-8629-B1C55C11147D@oracle.com> Vote: Yes /Jesper > On 13 Apr 2017, at 06:24, Igor Ignatyev <igor.ignatyev at oracle.com> wrote: > > I hereby nominate Kirill Zhaldybin (kzhaldyb) to JDK 10 Reviewer. > > Kirill is a member of VM SQE team. He led and implemented JEP 278 'Additional Tests for Humongous Objects in G1'. He also played significant role in JEP 281 'HotSpot C++ Unit-Test Framework' converting and improving existing internal VM tests to figure out and solve existing GTest problems. His work put basis in the future GTest guidelines. Besides mentioned projects, Kirill also did some other contributions in gc, runtime, compiler and serviceability. He contributed 57 changesets across hotspot[3], jdk[4] and root[5] repos. > > Votes are due by 26 April 2017, 22:00 PT. > > Only current JDK 10 Reviewers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. > For Three-Vote Consensus voting instructions, see [2]. > > Igor Ignatyev > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#reviewer-vote > [3] http://hg.openjdk.java.net/jdk10/hs/hotspot/log?revcount=2000&rev=%28%28author%28%22kzhaldyb%22%29+or+desc%28%22Contributed-by%3A+Kirill+Zhaldybin+%3Ckirill.zhaldybin%40oracle.com%3E%22%29%29%29+and+not+merge%28%29+and+not+desc%28%22Quarantine%22%29 > [4] http://hg.openjdk.java.net/jdk10/hs/jdk/log?revcount=2000&rev=%28%28author%28%22kzhaldyb%22%29+or+desc%28%22Contributed-by%3A+Kirill+Zhaldybin+%3Ckirill.zhaldybin%40oracle.com%3E%22%29%29%29+and+not+merge%28%29+and+not+desc%28%22Quarantine%22%29 > [5] http://hg.openjdk.java.net/jdk10/hs/log?revcount=2000&rev=%28%28author%28%22kzhaldyb%22%29+or+desc%28%22Contributed-by%3A+Kirill+Zhaldybin+%3Ckirill.zhaldybin%40oracle.com%3E%22%29%29%29+and+not+merge%28%29+and+not+desc%28%22Quarantine%22%29 > From mark.reinhold at oracle.com Tue Apr 18 21:14:26 2017 From: mark.reinhold at oracle.com (mark.reinhold at oracle.com) Date: Tue, 18 Apr 2017 14:14:26 -0700 Subject: JEP proposed to target JDK 10 (2017/4/18) Message-ID: <20170418141426.928357691@eggemoggin.niobe.net> The following JEP has been placed into the "Proposed to Target" state by its owner after discussion and review: 296: Consolidate the JDK Forest into a Single Repository http://openjdk.java.net/jeps/296 Feedback on this proposal is welcome, as are reasoned objections. If no such objections are raised by 23:00 UTC next Tuesday, 25 April, or if they're raised and then satisfactorily answered, then per the JEP 2.0 process proposal [1] I'll target this JEP to JDK 10. - Mark [1] http://cr.openjdk.java.net/~mr/jep/jep-2.0-02.html From christoph.langer at sap.com Wed Apr 19 12:06:51 2017 From: christoph.langer at sap.com (Langer, Christoph) Date: Wed, 19 Apr 2017 12:06:51 +0000 Subject: New JDK 10 Reviewer: Kirill Zhaldybin In-Reply-To: <0AE012D4-578F-4308-A0B1-F96DA99E0909@oracle.com> References: <0AE012D4-578F-4308-A0B1-F96DA99E0909@oracle.com> Message-ID: <3a0932ebfd6b4458b13dcf8ea75199ec@sap.com> Vote:Yes > -----Original Message----- > From: jdk10-dev [mailto:jdk10-dev-bounces at openjdk.java.net] On Behalf > Of Igor Ignatyev > Sent: Donnerstag, 13. April 2017 06:25 > To: jdk10-dev at openjdk.java.net > Subject: CFV: New JDK 10 Reviewer: Kirill Zhaldybin > > I hereby nominate Kirill Zhaldybin (kzhaldyb) to JDK 10 Reviewer. > > Kirill is a member of VM SQE team. He led and implemented JEP 278 > 'Additional Tests for Humongous Objects in G1'. He also played significant > role in JEP 281 'HotSpot C++ Unit-Test Framework' converting and improving > existing internal VM tests to figure out and solve existing GTest problems. His > work put basis in the future GTest guidelines. Besides mentioned projects, > Kirill also did some other contributions in gc, runtime, compiler and > serviceability. He contributed 57 changesets across hotspot[3], jdk[4] and > root[5] repos. > > Votes are due by 26 April 2017, 22:00 PT. > > Only current JDK 10 Reviewers [1] are eligible to vote on this nomination. > Votes must be cast in the open by replying to this mailing list. > For Three-Vote Consensus voting instructions, see [2]. > > Igor Ignatyev > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#reviewer-vote > [3] > http://hg.openjdk.java.net/jdk10/hs/hotspot/log?revcount=2000&rev=%28 > %28author%28%22kzhaldyb%22%29+or+desc%28%22Contributed- > by%3A+Kirill+Zhaldybin+%3Ckirill.zhaldybin%40oracle.com%3E%22%29%29% > 29+and+not+merge%28%29+and+not+desc%28%22Quarantine%22%29 > [4] > http://hg.openjdk.java.net/jdk10/hs/jdk/log?revcount=2000&rev=%28%28a > uthor%28%22kzhaldyb%22%29+or+desc%28%22Contributed- > by%3A+Kirill+Zhaldybin+%3Ckirill.zhaldybin%40oracle.com%3E%22%29%29% > 29+and+not+merge%28%29+and+not+desc%28%22Quarantine%22%29 > [5] > http://hg.openjdk.java.net/jdk10/hs/log?revcount=2000&rev=%28%28auth > or%28%22kzhaldyb%22%29+or+desc%28%22Contributed- > by%3A+Kirill+Zhaldybin+%3Ckirill.zhaldybin%40oracle.com%3E%22%29%29% > 29+and+not+merge%28%29+and+not+desc%28%22Quarantine%22%29 From rahul.v.raghavan at oracle.com Fri Apr 21 03:22:15 2017 From: rahul.v.raghavan at oracle.com (Rahul Raghavan) Date: Thu, 20 Apr 2017 20:22:15 -0700 (PDT) Subject: CFV: New JDK 9/10 Committer: Srinivas Dama In-Reply-To: <6E354E60-2931-452B-BADE-381486501B31@oracle.com> References: <6E354E60-2931-452B-BADE-381486501B31@oracle.com> Message-ID: <933edd88-ef04-44fd-b0a6-db76915f48b8@default> Vote: yes -Rahul > -----Original Message----- > From: Jim Laskey (Oracle) > Sent: Friday, April 21, 2017 1:41 AM > To: jdk9-dev > Subject: CFV: New JDK 9/10 Committer: Srinivas Dama > > I hereby nominate Srinivas Dama to JDK 9 and JDK 10 Committer. > > Srini is part of the Langtools team since August 2015 and has made many contributions to JDK 9. > I have included 8 of the the most significant change sets. > > Votes are due by May 5, 2017. > > Only current JDK 9/10 Committers [1] are eligible to vote on this nomination. > Votes must be cast in the open by replying to this mailing list. > > For Lazy Consensus voting instructions, see [2]. > > ? Jim > > [1] http://openjdk.java.net/census <http://openjdk.java.net/census> > [2] http://openjdk.java.net/bylaws#lazy-consensus <http://openjdk.java.net/bylaws#lazy-consensus> > > > Contributions > > 8138906: Test test/script/trusted/JDK-8087292.js intermittently fails. > https://bugs.openjdk.java.net/browse/JDK-8138906 > http://hg.openjdk.java.net/jdk9/dev/nashorn/rev/9937077e48f1 > > 8156743: ES6 for..of should work for Java Maps and Sets > https://bugs.openjdk.java.net/browse/JDK-8156743 > http://hg.openjdk.java.net/jdk9/dev/nashorn/rev/4561f9afd9bd > > 8144113: Implement new tests to cover jjs functionality > https://bugs.openjdk.java.net/browse/JDK-8144113 > http://hg.openjdk.java.net/jdk9/dev/nashorn/rev/086c19a36be6 > > 8147591: Revisit Collection.toArray(new T[size]) calls in nashorn and dynalink code > https://bugs.openjdk.java.net/browse/JDK-8147591 > http://hg.openjdk.java.net/jdk9/dev/nashorn/rev/0da44ab8c417 > > 8147613: enable jjs tests on Windows > https://bugs.openjdk.java.net/browse/JDK-8147613 > http://hg.openjdk.java.net/jdk9/dev/nashorn/rev/25b13597ea73 > > 8156615: Catch parameter can be a BindingPattern in ES6 mode > https://bugs.openjdk.java.net/browse/JDK-8156615 > http://hg.openjdk.java.net/jdk9/dev/nashorn/rev/4a68dd740be8 > > 8139255: javac reports "cannot override" messages instead of "cannot hide" messages for static methods > https://bugs.openjdk.java.net/browse/JDK-8139255 > http://hg.openjdk.java.net/jdk9/dev/langtools/rev/fdfaa0e5c8c0 > > 8134304: NPE in initialization of OptimisticTypesPersistence > https://bugs.openjdk.java.net/browse/JDK-8134304 > http://hg.openjdk.java.net/jdk9/dev/nashorn/rev/3487086f145a > From igor.ignatyev at oracle.com Thu Apr 27 05:45:23 2017 From: igor.ignatyev at oracle.com (Igor Ignatyev) Date: Wed, 26 Apr 2017 22:45:23 -0700 Subject: Result: New JDK 10 Reviewer: Kirill Zhaldybin Message-ID: <51C867A4-F2B9-472C-BE22-C0B46F21C6A1@oracle.com> Voting for Kirill Zhaldybin [1] is now closed. Yes: 11 Veto: 0 Abstain: 0 According to the Bylaws definition of Three-Vote Consensus, this is sufficient to approve the nomination. Igor Ignatyev [1] http://mail.openjdk.java.net/pipermail/jdk10-dev/2017-April/000171.html From joe.darcy at oracle.com Thu Apr 27 23:21:37 2017 From: joe.darcy at oracle.com (Joseph D. Darcy) Date: Thu, 27 Apr 2017 16:21:37 -0700 Subject: Tagging JDK 10 forests and filtering JDK 10 bugs Message-ID: <59027D01.9080406@oracle.com> Hello, As you may have seen, Lana has started tagging the JDK 10 forests to mark promotion candidates. These roughly correspond to sync points of fixes from JDK 9 promoted builds into JDK 10. As discussed previously, the "hgupdate-sync" label is being applied to bugs synced over from JDK 9 into JDK 10. Therefore, as done for the update releases, queries and filters for JDK 10 need to screen out bugs with "hgupdate-sync" to isolate the fixes unique to the release. A query like project = JDK AND fixVersion = 10 AND resolution = Fixed AND "Resolved In Build" = b01 and (labels is empty or labels != hgupdate-sync) find the 17 fixes unique to JDK 10 in b01, while without the checks on the labels, the query returns 415 issues, reflecting several weeks of bug fixes in JDK 9. Thanks, -Joe