Subject: CFV: New JDK 10 Committer: Erik Österlund

[Thomas Schatzl]

Vote: veto

Justification:

I looked through the changes and I do not believe they meet the
(informal?) goal of having eight significant commits.

Here is an overview of the contents of these changes. Feel free to
correct me.

trivial:
http://hg.openjdk.java.net/jdk10/hs/hotspot/rev/f1ad14991f86 (add
volatile + fix compilation)
http://hg.openjdk.java.net/jdk10/hs/hotspot/rev/c2ecbb9ee746 (add
volatile + fix compilation)
http://hg.openjdk.java.net/jdk10/hs/hotspot/rev/4d009502987b (add
volatile + fix compilation)
http://hg.openjdk.java.net/jdk10/hs/hotspot/rev/bbf76069d7fc (remove
obsolete code)

borderline:
http://hg.openjdk.java.net/jdk10/hs/hotspot/rev/bb5c32e2d31a (fix
compilation)
http://hg.openjdk.java.net/jdk10/hs/hotspot/rev/8fcdd3cc8da0 (add
volatile + fix compilation, this one is a bit larger than the others)

significant:
http://hg.openjdk.java.net/jdk10/hs/hotspot/rev/5793813a17dd (build
changes)
http://hg.openjdk.java.net/jdk10/hs/rev/55bf5464b0e6 (build changes)
http://hg.openjdk.java.net/jdk10/hs/hotspot/rev/8a4e011d99be
http://hg.openjdk.java.net/jdk10/hs/hotspot/rev/5398ffa1a419

I counted the build changes as significant because I feel unable to
judge them. That sums up to, including the ones I considered
borderline, as six significant commits.

I do know Erik, and I know that he is trustworthy to be committer, and
I know that he has lots of good changes about to be committed, but in
addition to this understanding some formal requirements must be met (or
at least very close to) at the time of nomination.

This is, in my view not the case here at this time.

We have in the past also been pretty strict about getting the Committer
role, and I think it would devalue every others' hard work to attain
that goal. I also, just a few months ago, privately looked through
commits of somebody else as trustworthy in the same situation, and I
asked him to come back after another two commits. I would like to ask
the same in this case.

Thanks,
  Thomas


On Thu, 2017-06-22 at 09:51 +0200, Stefan Karlsson wrote:
> I hereby nominate Erik Österlund to JDK 10 Committer.
> 
> Erik is a member of the Garbage Collection team in Oracle. He likes
> to 
> rewrite  and fix bugs in the OrderAccess and Atomics layers, loves 
> template metaprogramming, and is currently working on creating a GC 
> Barrier Interface as a part of JEP 304 - Garbage-Collector Interface
> [3][4]
> 
> Votes are due by 2017-07-06T09:50+02:00.
> 
> Only current JDK 10 Committers [1] are eligible to vote
> on this nomination.  Votes must be cast in the open by replying
> to this mailing list.
> 
> For Lazy Consensus voting instructions, see [2].
> 
> Stefan Karlsson
> 
> Contributions:
>   http://hg.openjdk.java.net/jdk10/hs/hotspot/rev/bb5c32e2d31a
>   http://hg.openjdk.java.net/jdk10/hs/hotspot/rev/5793813a17dd
>   http://hg.openjdk.java.net/jdk10/hs/hotspot/rev/f1ad14991f86
>   http://hg.openjdk.java.net/jdk10/hs/hotspot/rev/c2ecbb9ee746
>   http://hg.openjdk.java.net/jdk10/hs/hotspot/rev/8fcdd3cc8da0
>   http://hg.openjdk.java.net/jdk10/hs/hotspot/rev/4d009502987b
>   http://hg.openjdk.java.net/jdk10/hs/hotspot/rev/8a4e011d99be
>   http://hg.openjdk.java.net/jdk10/hs/hotspot/rev/5398ffa1a419
>   http://hg.openjdk.java.net/jdk10/hs/hotspot/rev/bbf76069d7fc
> (missing 
> attribution)
>   http://hg.openjdk.java.net/jdk10/hs/rev/55bf5464b0e6
> 
> 
> [1] http://openjdk.java.net/census
> [2] http://openjdk.java.net/projects/#committer-vote
> [3] http://openjdk.java.net/jeps/304
> [4] 
> http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2017-April/0197
> 41.html