Subject: CFV: New JDK 10 Committer: Erik Österlund

[mark.reinhold at oracle.com]

2017/6/22 11:26:16 +0200, thomas.schatzl at oracle.com:
> Vote: veto
> 
> Justification:
> 
> I looked through the changes and I do not believe they meet the
> (informal?) goal of having eight significant commits.
> 
> ...
> 
> I do know Erik, and I know that he is trustworthy to be committer, and
> I know that he has lots of good changes about to be committed, but in
> addition to this understanding some formal requirements must be met (or
> at least very close to) at the time of nomination.
> 
> This is, in my view not the case here at this time.

The "eight significant contributions" threshold is not a hard-and-fast
rule -- it's just a rough guideline, as stated [1].

The key question to answer when someone is nominated to a Committer role
is: Do you trust them to use their push access in a responsible fashion?

If someone has contributed eight significant changesets then chances are
pretty good that they've learned how things work, what to watch out for,
and when to ask for help, and so they can be trusted with push access.

If someone hasn't yet contributed eight significant changesets then that
doesn't mean that they're not qualified to be a Committer.  If they've
demonstrated in other ways that they have the requisite knowledge,
skills, and judgement then a smaller number of contributions should not
be a barrier.

Speaking for myself, I've seen enough of Erik's work that I think he can
be trusted, so I'm going to vote "yes".

- Mark


[1] http://openjdk.java.net/projects/#project-committer