RFR: 8181085: Race condition in method resolution may produce spurious NullPointerException

David Holmes david.holmes at oracle.com
Wed May 31 00:49:07 UTC 2017


Correction and apology ...

On 31/05/2017 7:33 AM, David Holmes wrote:
> <trimming>
> 
> On 30/05/2017 10:45 PM, Andrew Haley wrote:
>> You have to remember where this discussion started, which was a
>> proposed use of volatile to fix a bug where a barrier was needed.
> 
> No that was not the case, as has been pointed out numerous times. There 
> were two bugs:
> 
> 1. Incorrect placement of volatile in a declaration
> 2. Need to backport the compiler_barrier changes for OrderAccess.
> 
> No one suggested doing #1 in lieu of #2. We wanted #1 as well as #2.

My apologies, the very original proposal was just to fix #1 without any 
apparent knowledge of #2. When #2 was pointed out it was then proposed 
to drop #1. Paul and I then chimed in that #1 still needed to be fixed 
to follow lets say "hotspot style", even if, in the presence of correct 
(and correctly used) compiler-barriers the volatile should not be needed.

David

> David
> 


More information about the jdk10-dev mailing list