splashscreen.so is missing pnggccrd.c

[Anthony Petrov]

Hi Mark,

Thanks for pointing this. Actually, the patch existing in the IcedTea 
seems to have two potential issues that we at Sun are worried about:

1. The patch cuts off the embedded versions of these libraries from 
OpenJDK source code. In fact, there may exist systems where these 
libraries are not installed. And currently OpenJDK runs perfectly on 
these systems since it have the libraries compiled in.

2. The system libraries may contain issues/errors/bugs/whatever which 
our code cannot deal with (I think Java2D folks may collaborate on 
this). Throwing the libraries away from the OpenJDK code may reveal some 
of the issues, but we obviously can't fix the libraries as fast as our 
code. And also, we do guarantee some behavior (like understanding file 
format versions or whatever) that we wouldn't be able to guarantee if we 
can't ship our copies of the libraries.

So, it seems that a better patch would allow choosing whether the user 
wants to build the OpenJDK using the embedded versions of the libraries 
(with which the OpenJDK is guaranteed to behave as it should), or the 
user is brave enough to dynamically link to the system copies and the 
user is not going to redistribute the OpenJDK to systems that do not 
have these libraries installed.

That actually was the main idea of the patch for 
http://bugs.sun.com/view_bug.do?bug_id=6565114. Could the IcedTea 
maintainers do some similar stuff and provide us with the patch? Thanks 
in advance!

--
best regards,
Anthony


On 08/28/2008 12:51 PM Mark Wielaard wrote:
> Hi,
> 
> On Wed, 2008-08-27 at 15:34 -0700, Martin Buchholz wrote:
>> Adding options to use the system versions of these graphics libraries
>> is integrated into IcedTea already.  IcedTea and Sun AWT engineers
>> should work together to put such changes into OpenJDK7.
> 
> Yes, this would be great so we don't have to maintain so many extra
> external patches. The patch to do this in icedtea6 is at:
> http://icedtea.classpath.org/hg/icedtea6/file/tip/patches/icedtea-libraries.patch
> That makes sure the system versions of the png, jpeg and zlib libraries
> are used.
> 
> Cheers,
> 
> Mark
> 
>