OpenJDK 6 b10 source posted
Karl Helgason
kalli at midverk.is
Tue Jun 3 18:09:55 PDT 2008
Mark Wielaard wrote:
> It wasn't clear precisely which upstream version of Gervill you are
> including. It does look like you are missing some fixes Karl and I made
> since it got integrated into icedtea. For example you miss the sample
> rate conversion support. But it is somewhat hard to see because all the
> files got completely reformatted from the upstream sources.
They are using Gervill 0.9 source dump with these fixes (which are also in current cvs):
- Fix: Default tempo in SoftMidiFileReader was supposed to be 500000 mpq or 120 bpm
- Fix: Change type of info variable in SoftSynthesize into MidiDevice.Info
- Fix: Fix instanceof check of p1 variable in ModelInstrumentComparator
- Fix: Remove redundant constant variable in ModelByteBufferWaveTable
The code was also slightly reformatted:
a) lines "* @version %I%, %E%" was removed (such lines was removed from all JDK
sources);
b) line indention (to make lines no longer than 80 symbols);
c) tabs to spaces conversion;
I will look into to reformat newest Gervill CVS code the same way.
Regards,
Karl
More information about the jdk6-dev
mailing list