SV: OpenJDK 6 b10 source posted

[Karl Helgason]

Hi Mark,

I have reformatted the Gervill CVS code.
It should be possible now to make diffs between them easily.

cheers,
Karl

________________________________________
Frá: Mark Wielaard [mark at klomp.org]
Sent: 4. júní 2008 09:25
Viðtakandi: Karl Helgason
Afrit: jdk6-dev at openjdk.java.net; distro-pkg-dev at openjdk.java.net
Efni: Re: OpenJDK 6 b10 source posted

Hi Karl,

On Wed, 2008-06-04 at 01:09 +0000, Karl Helgason wrote:
> Mark Wielaard wrote:
> > It wasn't clear precisely which upstream version of Gervill you are
> > including. It does look like you are missing some fixes Karl and I made
> > since it got integrated into icedtea. For example you miss the sample
> > rate conversion support. But it is somewhat hard to see because all the
> > files got completely reformatted from the upstream sources.
>
> They are using Gervill 0.9 source dump with these fixes (which are also in current cvs):
>   - Fix: Default tempo in SoftMidiFileReader was supposed to be 500000 mpq or 120 bpm
>   - Fix: Change type of info variable in SoftSynthesize into MidiDevice.Info
>   - Fix: Fix instanceof check of p1 variable in ModelInstrumentComparator
>   - Fix: Remove redundant constant variable in ModelByteBufferWaveTable

Thanks for checking. These are all in the icedtea gervill overlay also.
I'll make sure to upgrade to the latest CVS version in which I see you
fixed some of the other issues I reported.

> The code was also slightly reformatted:
> a) lines "* @version %I%, %E%" was removed (such lines was removed from all JDK
> sources);
> b) line indention (to make lines no longer than 80 symbols);
> c) tabs to spaces conversion;
>
> I will look into to reformat newest Gervill CVS code the same way.

That would be great. Since 0.9 there have been lots of changes and fixes
(which is why icedtea tracks your CVS tree and didn't use the old 0.9
code). Would it be a good idea to do a new version upgrade after syncing
the sources and reformatting to celebrate the inclusion?

Cheers,

Mark



No virus found in this incoming message.
Checked by AVG.
Version: 7.5.524 / Virus Database: 269.24.6/1480 - Release Date: 3.6.2008 07:00