ChunkedInputStream/test.txt

[Kelly O'Hair]

Probably true that the test can be re-written, and you are right, a 500K
binary file is not something I want in the repository either.
Unfortunately, some engineers have the historical and bad habit of just
adding in files to workspaces and repositories without thinking about it
much, especially with tests. This habit must stop now, hopefully we can
catch this during the code review phase.

-kto

Mark Wielaard wrote:
> Hi Kelly,
> 
> On Wed, 2008-09-17 at 09:29 -0700, Kelly O'Hair wrote:
>> This binary file has a %[A-Z]% byte pattern in it, and when it gets
>> processed by sccs, those bytes get turned into an SCCS keyword value.
>>
>> This problem was found when I did the Mercurial conversion, which gets
>> the SCCS 'pre-keyword' file contents.
>>
>> I'd ignore this one, except for the fact that is is a binary file. :^(
> 
> Maybe we should just rewrite the test. The contents of test.txt seems to
> not really matter. And in fact the way it is read in ChunkedEncodingTest
> doesn't even guarantee that it is fully read in. So it seems to make
> sense to rewrite the test in a way that it just uses (random) data made
> up at runtime instead of having to 500K file in te repository. Or am I
> missing something subtle here?
> 
> Cheers,
> 
> Mark
>