Code review request for 4891262 "API spec, javax/accessibility: few invalid javadoc tags"

Joseph D. Darcy Joe.Darcy at Sun.COM
Mon Dec 21 17:37:56 PST 2009


Andrew John Hughes wrote:
> 2009/12/21 Joseph D. Darcy <Joe.Darcy at sun.com>:
>   
>> Andrew John Hughes wrote:
>>     
>>> 2009/12/15 Joseph D. Darcy <Joe.Darcy at sun.com>:
>>>
>>>
>>>       

[snip]
>>>>
>>>>
>>>>         
>>> Two more:
>>>
>>> changeset:   1624:f1eb4c28b313
>>> user:        lancea
>>> date:        Wed Sep 09 20:15:22 2009 -0400
>>> summary:     6737212: Fixed javadoc warning messages in RowSet classes
>>> http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f1eb4c28b313
>>>
>>>       
>> Approved to be pushed.
>>
>>     
>>> changeset:   1969:3267ca7afe95
>>> user:        darcy
>>> date:        Fri Dec 11 10:40:14 2009 -0800
>>> summary:     6909563: Javadoc build warnings in rmi, security, management
>>> http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3267ca7afe95
>>>
>>> Ok to go back?
>>>
>>>       
>> I also approve this one going back with the condition that any unneeded
>> changes to JDK 7-only files are removed.
>>
>> Cheers,
>>
>> -Joe
>>
>>
>>     
>
> Both done.  The changes that were to JDK7-only classes simply didn't apply.
> Next one:
>
> changeset:   1572:196c7bb551e7
> user:        darcy
> date:        Tue Aug 25 18:58:26 2009 -0700
> summary:     6875861: javadoc build warning on java.util.Properites
> from unconventional @see ordering
> http://hg.openjdk.java.net/jdk7/tl/jdk/rev/196c7bb551e7
>   
Approved to go back.

Thanks,

-Joe


More information about the jdk6-dev mailing list