From langel at redhat.com Wed Jul 8 20:47:39 2009 From: langel at redhat.com (langel at redhat.com) Date: Wed, 08 Jul 2009 20:47:39 -0700 Subject: hg: jdk6/jdk6/jdk: 6852607: MessageUtils JVM crash Message-ID: <20090709034752.DCC06EDC1@hg.openjdk.java.net> Changeset: 1661d42b1c09 Author: langel Date: 2009-06-25 17:15 -0400 URL: http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/1661d42b1c09 6852607: MessageUtils JVM crash Summary: Fixes crash by checking null field Reviewed-by: alanb ! src/share/native/sun/misc/MessageUtils.c From mr at sun.com Wed Jul 8 20:53:39 2009 From: mr at sun.com (Mark Reinhold) Date: Wed, 08 Jul 2009 20:53:39 -0700 Subject: hg: jdk6/jdk6/jdk: 6852607: MessageUtils JVM crash In-Reply-To: langel@redhat.com; Wed, 08 Jul 2009 20:47:39 PDT; <20090709034752.DCC06EDC1@hg.openjdk.java.net> Message-ID: <20090709035339.1DBECA2BE@callebaut.niobe.net> In case you're wondering ... this is only showing up now because Lillian's changeset was stuck in jdk6-gate/jdk. The gate auto-push mechanism fails -- rarely -- for reasons yet to be determined. I'll be setting up a cron job to detect and correct this problem. - Mark -------------- next part -------------- An embedded message was scrubbed... From: langel at redhat.com Subject: hg: jdk6/jdk6/jdk: 6852607: MessageUtils JVM crash Date: Wed, 08 Jul 2009 20:47:39 -0700 Size: 1945 Url: http://mail.openjdk.java.net/pipermail/jdk6-dev/attachments/20090708/37be28ff/attachment.mht From martinrb at google.com Thu Jul 9 14:46:45 2009 From: martinrb at google.com (martinrb at google.com) Date: Thu, 09 Jul 2009 21:46:45 +0000 Subject: hg: jdk6/jdk6/jdk: 6854795: Miscellaneous improvements to "jar"; ... Message-ID: <20090709214703.BC40AEDFB@hg.openjdk.java.net> Changeset: b35f1e5075a4 Author: martin Date: 2009-07-06 13:53 -0700 URL: http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/b35f1e5075a4 6854795: Miscellaneous improvements to "jar" 6834805: Improve jar -C performance 6332094: "jar t" and "jar x" should use ZipFile, not ZipInputStream 6496274: jar seems to use more CPU than it should Summary: backport jdk7 jar command (remove use of nio2) Reviewed-by: sherman, darcy ! src/share/classes/sun/tools/jar/Main.java ! test/tools/jar/index/MetaInf.java From gnu_andrew at member.fsf.org Wed Jul 15 13:23:22 2009 From: gnu_andrew at member.fsf.org (Andrew John Hughes) Date: Wed, 15 Jul 2009 21:23:22 +0100 Subject: Switching to HotSpot 14 on OpenJDK6 Message-ID: <17c6771e0907151323q1725f046laf0182502f75a22e@mail.gmail.com> We discussed this a while back, but discussions seem to have come to a halt. Using the rebase extension to hg, I've succeeded in producing a version of the OpenJDK6 repository based on the same 0 revision as the hs14 master: http://fuseyism.com/hg/hotspot This means that pulls from the hs14 master can be used to update this repository, which isn't the case with the current OpenJDK6 repository as they have no common parent. However, unlike hs14, it does include all the history and fixes from OpenJDK6 (some of which don't seem to have made the HS7 repos, such as deleting binary jar files). Does this look ok? If so, can someone with ssh access to hg.openjdk.java.net please replace the current hotspot repository with this one, so we can update it to the current hs14 revision and add any other pending changes? It would be nice to finally let HotSpot development in OpenJDK6 move on! Thanks, -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From kalli at midverk.is Thu Jul 16 18:29:07 2009 From: kalli at midverk.is (Karl Helgason) Date: Fri, 17 Jul 2009 01:29:07 +0000 Subject: [Request for review] 6833357: Improve time-stamp support in Gervill to reduce jitter. Message-ID: <36EC82E93EB0AD40A4301DAD65432386F5BA863E2A@mail.midverk.is> Hi, I need code review for the fix: http://cr.openjdk.java.net/~kalli/6833357/webrev/ This fix adds support for zero-jitter playback when using time-stamped MIDI events. Full potential of this fix won't come until time-stamp support has been added to RealTimeSequencer. see: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6833358 Here is a overview of changes made: SoftLimiter.java - Fix NullPointerException when in mono mode SoftChannel.java - Add note on int delay parameter SoftReceiver - Add getMidiDevice method and fix midi activity detection SoftAudioBuffer - Add swap method SoftMainMixer, SoftSynthesizer, SoftVoice - Add delay logic regards, Karl From Joe.Darcy at Sun.COM Fri Jul 17 11:43:15 2009 From: Joe.Darcy at Sun.COM (Joseph D. Darcy) Date: Fri, 17 Jul 2009 11:43:15 -0700 Subject: Switching to HotSpot 14 on OpenJDK6 In-Reply-To: <17c6771e0907151323q1725f046laf0182502f75a22e@mail.gmail.com> References: <17c6771e0907151323q1725f046laf0182502f75a22e@mail.gmail.com> Message-ID: <4A60C643.3090306@sun.com> Andrew John Hughes wrote: > We discussed this a while back, but discussions seem to have come to a halt. > > Using the rebase extension to hg, I've succeeded in producing a > version of the OpenJDK6 repository based on the same 0 revision as the > hs14 master: > > http://fuseyism.com/hg/hotspot > > This means that pulls from the hs14 master can be used to update this > repository, which isn't the case with the current OpenJDK6 repository > as they have no common parent. However, unlike hs14, it does include > all the history and fixes from OpenJDK6 (some of which don't seem to > have made the HS7 repos, such as deleting binary jar files). > > Does this look ok? If so, can someone with ssh access to > hg.openjdk.java.net please replace the current hotspot repository with > this one, so we can update it to the current hs14 revision and add any > other pending changes? > > It would be nice to finally let HotSpot development in OpenJDK6 move on! > > Thanks, > Hi Andrew. I'll discuss this matter with Kelly when we are both not on vacation. Thanks, -Joe From gertjanvinkje at gmail.com Fri Jul 17 12:31:20 2009 From: gertjanvinkje at gmail.com (GerardJan) Date: Fri, 17 Jul 2009 21:31:20 +0200 Subject: 32 bit fonts on 64 bits machines (AMD) en (Intel) Message-ID: <4A60D188.6060404@gmail.com> Hi, I am looking for a font in 32 bits, for i have a sempron-like 68_32 cpu thanks in advance GJ -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/jdk6-dev/attachments/20090717/be0c410b/attachment.html From martinrb at google.com Fri Jul 17 15:36:44 2009 From: martinrb at google.com (Martin Buchholz) Date: Fri, 17 Jul 2009 15:36:44 -0700 Subject: 6693490: (se) select throws "File exists" IOException under load (lnx) Message-ID: <1ccfd1c10907171536s64aa7ff6vfcb55db0e81c0ffa@mail.gmail.com> Google thinks it would be good to backport fix for 6693490. http://cr.openjdk.java.net/~martin/webrevs/openjdk6/select/ # HG changeset patch # User alanb # Date 1238167477 0 # Node ID 2d1be7e79df15188e2100268c33d8f682858430d # Parent b35f1e5075a42030e8624459b13daa45ffc834f8 6693490: (se) select throws "File exists" IOException under load (lnx) Reviewed-by: sherman The only slightly non-trivial part of backport was *EPollSelectorImpl.java. * Martin -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/jdk6-dev/attachments/20090717/844d886c/attachment.html From Joe.Darcy at Sun.COM Fri Jul 17 15:42:44 2009 From: Joe.Darcy at Sun.COM (Joe Darcy) Date: Fri, 17 Jul 2009 15:42:44 -0700 Subject: 6693490: (se) select throws "File exists" IOException under load (lnx) In-Reply-To: <1ccfd1c10907171536s64aa7ff6vfcb55db0e81c0ffa@mail.gmail.com> References: <1ccfd1c10907171536s64aa7ff6vfcb55db0e81c0ffa@mail.gmail.com> Message-ID: <4A60FE64.7050008@sun.com> On 07/17/09 03:36 PM, Martin Buchholz wrote: > Google thinks it would be good to backport fix for 6693490. > > http://cr.openjdk.java.net/~martin/webrevs/openjdk6/select/ > > > # HG changeset patch > # User alanb > # Date 1238167477 0 > # Node ID 2d1be7e79df15188e2100268c33d8f682858430d > # Parent b35f1e5075a42030e8624459b13daa45ffc834f8 > 6693490: (se) select throws "File exists" IOException under load (lnx) > Reviewed-by: sherman > > The only slightly non-trivial part of backport was > *EPollSelectorImpl.java. > > * > Martin > Sounds like a fine backport to me :-) I took a quick look and didn't see anything obviously wrong, but I'd prefer if Alan, Sherman, or someone else more familiar with this code than I did a quick review before it went into OpenJDK 6. Thanks, -Joe -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/jdk6-dev/attachments/20090717/628cf613/attachment.html From franklynding at gmail.com Sat Jul 18 23:55:57 2009 From: franklynding at gmail.com (Franklyn Ding) Date: Sun, 19 Jul 2009 14:55:57 +0800 Subject: What's wrong with openjdk make file? Message-ID: Hi I am a fan of Java and I tried to build openjdk6 on my Linux. I came across a weird error when issuing "make sanity". Here are the details. The openjdk source is from openjdk-6-src-b16-24_apr_2009.tar.gz My env vars are: declare -x ALT_BINARY_PLUGS_PATH="/root/buildjdk/openjdk-binary-plugs" declare -x ALT_BOOTDIR="/usr/local/jdk1.6.0_14" declare -x ALT_JIBX_LIBS_PATH="/root/buildjdk/jibx/lib" declare -x ANT_HOME="/opt/ant" declare -x BOOTDIR="/usr/local/jdk1.6.0_14" After I issued "make sanity" I got the some error messages: ERROR: Your BOOTDIR environment variable does not point to a valid JDK for bootstrapping this build. A JDK 6 build must be bootstrapped using JDK 1.6.0 fcs (or later). Apparently, your bootstrap JDK is version Please update your ALT_BOOTDIR setting and start your build again. ERROR: You do not have access to valid Motif 2.1 header files. Please check your access to (for example) /usr/include/Xm/AtomMgr.h and/or check your value of ALT_MOTIF_DIR. ERROR: You do not have access to valid Cups header files. Please check your access to /usr/include/cups/cups.h and/or check your value of ALT_CUPS_HEADERS_PATH, CUPS is frequently pre-installed on many systems, or may be downloaded from http://www.cups.org Exiting because of the above error(s). The whole output can be found from my attached file. The first ERROR is weird. And I checked makefile script. I found it is generated from file jdk/make/common/shared/Sanity.gmk ###################################################### # BOOTDIR must point to a valid JDK. ###################################################### BOOT_CHECK :=$(call CheckVersions,$(BOOT_VER),$(REQUIRED_BOOT_VER)) sane-bootdir: @if [ "$(BOOT_CHECK)" != "same" -a "$(BOOT_CHECK)" != "newer" ]; then \ $(ECHO) "ERROR: Your BOOTDIR environment variable does not point \n" \ " to a valid JDK for bootstrapping this build. \n" \ " A JDK $(JDK_MINOR_VERSION) $(MARKET_NAME) build must be bootstrapped using \n" \ " JDK $(PREVIOUS_JDK_VERSION) fcs (or later). \n" \ " Apparently, your bootstrap JDK is version $(BOOT_VER) \n" \ " Please update your ALT_BOOTDIR setting and start your build again. \n" \ "" >> $(ERROR_FILE) ; \ fi It seems BOOT_VER is empty. This can be confirmed by one line from the output. make[1]: Entering directory `/root/buildjdk/openjdk6/jdk/make' */root/buildjdk/openjdk6/jdk/make/common/shared/Sanity-Settings.gmk:72: WARNING: BOOT_VER should not be empty [Sanity-Settings.gmk]* /root/buildjdk/openjdk6/jdk/make/common/shared/Sanity-Settings.gmk:119: WARNING: ZIP_VER should not be empty [Sanity-Settings.gmk] /root/buildjdk/openjdk6/jdk/make/common/shared/Sanity-Settings.gmk:120: WARNING: UNZIP_VER should not be empty [Sanity-Settings.gmk] /root/buildjdk/openjdk6/jdk/make/common/shared/Sanity-Settings.gmk:125: WARNING: FINDBUGS_VER should not be empty [Sanity-Settings.gmk] /root/buildjdk/openjdk6/jdk/make/common/shared/Sanity-Settings.gmk:201: WARNING: MAKE_VER should not be empty [Sanity-Settings.gmk] make[2]: Entering directory `/root/buildjdk/openjdk6/jdk/make/tools/ Note MAKE_VER, ZIP_VER and UNZIP_VER are also empty. Then I tried to figure out why BOOT_VER is empty during make sanity. I found BOOT_VER is init-ed in jdk/make/common/shared/Sanity.gmk # Get the version numbers of what we are using _MAKE_VER :=$(shell $(MAKE) --version 2>&1 | $(HEAD) -n 1) _ZIP_VER :=$(shell $(ZIPEXE) -help 2>&1 | $(HEAD) -n 4 | $(EGREP) '^Zip') _UNZIP_VER :=$(shell $(UNZIP) -help 2>&1 | $(HEAD) -n 4 | $(EGREP) '^UnZip') _BOOT_VER :=$(shell $(BOOTDIR)/bin/java -version 2>&1 | $(HEAD) -n 1) MAKE_VER :=$(call GetVersion,"$(_MAKE_VER)") ZIP_VER :=$(call GetVersion,"$(_ZIP_VER)") UNZIP_VER :=$(call GetVersion,"$(_UNZIP_VER)") BOOT_VER :=$(call GetVersion,"$(_BOOT_VER)") and GetVersion is defined in ./jdk/make/common/shared/Defs.gmk as follows # Given a line of text, get the major.minor version number from it define GetVersion $(shell echo $1 | sed -e 's@[^1-9]*\([1-9][0-9]*\.[0-9][0-9]*\).*@\1@' ) endef I tested the commands combined above, and got the corrent result root:~/buildjdk/openjdk6# $BOOTDIR/bin/java -version 2>&1 | head -n 1 | sed -e 's@[^1-9]*\([1-9][0-9]*\.[0-9][0-9]*\).*@\1@' 1.6 So anybody has any hints? Best regards, Frank -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/jdk6-dev/attachments/20090719/fe162c4f/attachment.html -------------- next part -------------- A non-text attachment was scrubbed... Name: result.log Type: application/octet-stream Size: 9488 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/jdk6-dev/attachments/20090719/fe162c4f/attachment.obj From Joe.Darcy at Sun.COM Sun Jul 19 16:26:43 2009 From: Joe.Darcy at Sun.COM (Joseph D. Darcy) Date: Sun, 19 Jul 2009 16:26:43 -0700 Subject: What's wrong with openjdk make file? In-Reply-To: References: Message-ID: <4A63ABB3.7000103@sun.com> Franklyn Ding wrote: > Hi > I am a fan of Java and I tried to build openjdk6 on my Linux. I > came across a weird error when issuing "make sanity". Follow the directions in the build readme file and see Dalibor's blog entry for guidance: http://robilad.livejournal.com/41303.html -Joe From Alan.Bateman at Sun.COM Mon Jul 20 07:19:59 2009 From: Alan.Bateman at Sun.COM (Alan Bateman) Date: Mon, 20 Jul 2009 15:19:59 +0100 Subject: 6693490: (se) select throws "File exists" IOException under load (lnx) In-Reply-To: <1ccfd1c10907171536s64aa7ff6vfcb55db0e81c0ffa@mail.gmail.com> References: <1ccfd1c10907171536s64aa7ff6vfcb55db0e81c0ffa@mail.gmail.com> Message-ID: <4A647D0F.6020901@sun.com> Martin Buchholz wrote: > Google thinks it would be good to backport fix for 6693490. > > http://cr.openjdk.java.net/~martin/webrevs/openjdk6/select/ > > > # HG changeset patch > # User alanb > # Date 1238167477 0 > # Node ID 2d1be7e79df15188e2100268c33d8f682858430d > # Parent b35f1e5075a42030e8624459b13daa45ffc834f8 > 6693490: (se) select throws "File exists" IOException under load (lnx) > Reviewed-by: sherman > > The only slightly non-trivial part of backport was > *EPollSelectorImpl.java. > > * > Martin > Sorry for the late reply, I've been on vacation. I agree this is a good candidate to back-port. The webrev looks good to me (the changes to EPollSelectorImpl seem to be the same as the jdk7 changes, it's just that jdk7 has some additional fixes and also uses of the Integer constructor were previously changed to use Integer.valueOf). -Alan. From alex.menkov at sun.com Tue Jul 21 08:36:58 2009 From: alex.menkov at sun.com (Alex Menkov) Date: Tue, 21 Jul 2009 19:36:58 +0400 Subject: [Request for review] 6833357: Improve time-stamp support in Gervill to reduce jitter. In-Reply-To: <36EC82E93EB0AD40A4301DAD65432386F5BA863E2A@mail.midverk.is> References: <36EC82E93EB0AD40A4301DAD65432386F5BA863E2A@mail.midverk.is> Message-ID: <4A65E09A.6080405@sun.com> Hi Karl, Looks good for me. The only note is about something strange with SoftSynthesizer.java (open method): your patch reapply a fix which is already in the repo. Looks like you have inconsistent repository. Regards Alex Karl Helgason wrote: > Hi, > > I need code review for the fix: > http://cr.openjdk.java.net/~kalli/6833357/webrev/ > > This fix adds support for zero-jitter playback when using time-stamped MIDI events. > > Full potential of this fix won't come until time-stamp support has been added to RealTimeSequencer. > see: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6833358 > > Here is a overview of changes made: > SoftLimiter.java - Fix NullPointerException when in mono mode > SoftChannel.java - Add note on int delay parameter > SoftReceiver - Add getMidiDevice method and fix midi activity detection > SoftAudioBuffer - Add swap method > SoftMainMixer, SoftSynthesizer, SoftVoice - Add delay logic > > regards, > Karl From Joe.Darcy at Sun.COM Tue Jul 21 13:30:25 2009 From: Joe.Darcy at Sun.COM (Joe Darcy) Date: Tue, 21 Jul 2009 13:30:25 -0700 Subject: Switching to HotSpot 14 on OpenJDK6 In-Reply-To: <4A60C643.3090306@sun.com> References: <17c6771e0907151323q1725f046laf0182502f75a22e@mail.gmail.com> <4A60C643.3090306@sun.com> Message-ID: <4A662561.8040707@sun.com> Joseph D. Darcy wrote: > Andrew John Hughes wrote: >> We discussed this a while back, but discussions seem to have come to a >> halt. >> >> Using the rebase extension to hg, I've succeeded in producing a >> version of the OpenJDK6 repository based on the same 0 revision as the >> hs14 master: >> >> http://fuseyism.com/hg/hotspot >> >> This means that pulls from the hs14 master can be used to update this >> repository, which isn't the case with the current OpenJDK6 repository >> as they have no common parent. However, unlike hs14, it does include >> all the history and fixes from OpenJDK6 (some of which don't seem to >> have made the HS7 repos, such as deleting binary jar files). >> >> Does this look ok? If so, can someone with ssh access to >> hg.openjdk.java.net please replace the current hotspot repository with >> this one, so we can update it to the current hs14 revision and add any >> other pending changes? >> >> It would be nice to finally let HotSpot development in OpenJDK6 move on! >> >> Thanks, >> > > Hi Andrew. > > I'll discuss this matter with Kelly when we are both not on vacation. > > Thanks, > > -Joe Hello. I've discussed the rebasing with Mark R. and we've agreed to go forward with it. Mark has offered to do the actual replacing of the repository contents. Thanks, -Joe From gnu_andrew at member.fsf.org Tue Jul 21 13:44:45 2009 From: gnu_andrew at member.fsf.org (Andrew John Hughes) Date: Tue, 21 Jul 2009 21:44:45 +0100 Subject: Switching to HotSpot 14 on OpenJDK6 In-Reply-To: <4A662561.8040707@sun.com> References: <17c6771e0907151323q1725f046laf0182502f75a22e@mail.gmail.com> <4A60C643.3090306@sun.com> <4A662561.8040707@sun.com> Message-ID: <17c6771e0907211344y1518bcd3w76b71eb005249aa2@mail.gmail.com> 2009/7/21 Joe Darcy : > Joseph D. Darcy wrote: >> >> Andrew John Hughes wrote: >>> >>> We discussed this a while back, but discussions seem to have come to a >>> halt. >>> >>> Using the rebase extension to hg, I've succeeded in producing a >>> version of the OpenJDK6 repository based on the same 0 revision as the >>> hs14 master: >>> >>> http://fuseyism.com/hg/hotspot >>> >>> This means that pulls from the hs14 master can be used to update this >>> repository, which isn't the case with the current OpenJDK6 repository >>> as they have no common parent. ?However, unlike hs14, it does include >>> all the history and fixes from OpenJDK6 (some of which don't seem to >>> have made the HS7 repos, such as deleting binary jar files). >>> >>> Does this look ok? If so, can someone with ssh access to >>> hg.openjdk.java.net please replace the current hotspot repository with >>> this one, so we can update it to the current hs14 revision and add any >>> other pending changes? >>> >>> It would be nice to finally let HotSpot development in OpenJDK6 move on! >>> >>> Thanks, >>> >> >> Hi Andrew. >> >> I'll discuss this matter with Kelly when we are both not on vacation. >> >> Thanks, >> >> -Joe > > Hello. > > I've discussed the rebasing with Mark R. and we've agreed to go forward with > it. ?Mark has offered to do the actual replacing of the repository contents. > > Thanks, > > -Joe > Thanks. That's great news :) -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From martinrb at google.com Tue Jul 21 15:23:55 2009 From: martinrb at google.com (martinrb at google.com) Date: Tue, 21 Jul 2009 22:23:55 +0000 Subject: hg: jdk6/jdk6/jdk: 6693490: (se) select throws "File exists" IOException under load (lnx) Message-ID: <20090721222412.5DB24EA98@hg.openjdk.java.net> Changeset: 1eb1bc59578f Author: alanb Date: 2009-03-27 15:24 +0000 URL: http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/1eb1bc59578f 6693490: (se) select throws "File exists" IOException under load (lnx) Reviewed-by: sherman, darcy Contributed-by: Backport by Igor Chernyshev ! src/share/classes/sun/nio/ch/SelChImpl.java ! src/solaris/classes/sun/nio/ch/EPollArrayWrapper.java ! src/solaris/classes/sun/nio/ch/EPollSelectorImpl.java + test/java/nio/channels/Selector/RegAfterPreClose.java From kalli at midverk.is Tue Jul 21 15:25:32 2009 From: kalli at midverk.is (Karl Helgason) Date: Tue, 21 Jul 2009 22:25:32 +0000 Subject: SV: [Request for review] 6833357: Improve time-stamp support in Gervill to reduce jitter. In-Reply-To: <4A65E09A.6080405@sun.com> References: <36EC82E93EB0AD40A4301DAD65432386F5BA863E2A@mail.midverk.is>, <4A65E09A.6080405@sun.com> Message-ID: <36EC82E93EB0AD40A4301DAD65432386F5BA863E2D@mail.midverk.is> Hi Alex, This was my fault. My patch isn't reapplying that fix, it is reverting it. Here is a new and improved webrev: http://cr.openjdk.java.net/~kalli/6833357/webrev.02/ regards, Karl ________________________________________ Fr?: Alexey.Menkov at Sun.COM [Alexey.Menkov at Sun.COM] Fyrir hönd Alex Menkov [alex.menkov at Sun.COM] Sent: 21. j?l? 2009 15:36 Vi?takandi: Karl Helgason Afrit: jdk6-dev at openjdk.java.net; Dalibor.Topic at Sun.COM Efni: Re: [Request for review] 6833357: Improve time-stamp support in Gervill to reduce jitter. Hi Karl, Looks good for me. The only note is about something strange with SoftSynthesizer.java (open method): your patch reapply a fix which is already in the repo. Looks like you have inconsistent repository. Regards Alex Karl Helgason wrote: > Hi, > > I need code review for the fix: > http://cr.openjdk.java.net/~kalli/6833357/webrev/ > > This fix adds support for zero-jitter playback when using time-stamped MIDI events. > > Full potential of this fix won't come until time-stamp support has been added to RealTimeSequencer. > see: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6833358 > > Here is a overview of changes made: > SoftLimiter.java - Fix NullPointerException when in mono mode > SoftChannel.java - Add note on int delay parameter > SoftReceiver - Add getMidiDevice method and fix midi activity detection > SoftAudioBuffer - Add swap method > SoftMainMixer, SoftSynthesizer, SoftVoice - Add delay logic > > regards, > Karl From mr at sun.com Wed Jul 22 14:48:10 2009 From: mr at sun.com (Mark Reinhold) Date: Wed, 22 Jul 2009 14:48:10 -0700 Subject: Switching to HotSpot 14 on OpenJDK6 In-Reply-To: gnu_andrew@member.fsf.org; Wed, 15 Jul 2009 21:23:22 BST; <17c6771e0907151323q1725f046laf0182502f75a22e@mail.gmail.com> Message-ID: <20090722214810.175B451B@eggemoggin.niobe.net> > Date: Wed, 15 Jul 2009 21:23:22 +0100 > From: Andrew John Hughes > Using the rebase extension to hg, I've succeeded in producing a > version of the OpenJDK6 repository based on the same 0 revision as the > hs14 master: > > http://fuseyism.com/hg/hotspot > > This means that pulls from the hs14 master can be used to update this > repository, which isn't the case with the current OpenJDK6 repository > as they have no common parent. However, unlike hs14, it does include > all the history and fixes from OpenJDK6 (some of which don't seem to > have made the HS7 repos, such as deleting binary jar files). > > Does this look ok? If so, can someone with ssh access to > hg.openjdk.java.net please replace the current hotspot repository with > this one, so we can update it to the current hs14 revision and add any > other pending changes? Your repo looks fine to me -- thanks for creating it. Shall I go ahead and replace the current jdk6/hotspot repo with this? (That is, does anyone have any concerns?) > It would be nice to finally let HotSpot development in OpenJDK6 move on! Indeed! - Mark From mr at sun.com Thu Jul 23 08:26:50 2009 From: mr at sun.com (Mark Reinhold) Date: Thu, 23 Jul 2009 08:26:50 -0700 Subject: Switching to HotSpot 14 on OpenJDK6 In-Reply-To: mr@sun.com; Wed, 22 Jul 2009 14:48:10 PDT; <20090722214810.175B451B@eggemoggin.niobe.net> Message-ID: <20090723152650.1C8206F6@eggemoggin.niobe.net> > From: Mark Reinhold > Date: Wed, 22 Jul 2009 14:48:10 -0700 > ... > > Your repo looks fine to me -- thanks for creating it. > > Shall I go ahead and replace the current jdk6/hotspot repo with this? > (That is, does anyone have any concerns?) Here's something (perhaps) to be concerned about: A recently-reported regression in Sun's proprietary 6u14 (and hence also in hsx14) causes debugging breakpoints to be ignored in some circumstances. The bug is reproducible with both the client and server VMs, but only using the serial GC. The primary Sun bugid is 6862295 [1]; see also the downstream bug first reported in Eclipse [2]. Dan Daugherty is working on a fix, which we'll publish when available, but in the meantime hsx14 has this bug. Is the existence of this bug in hsx14 a reason to delay replacing the current jdk6/hotspot repo with Andrew's newer version? Let me know. - Mark [1] http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6862295 [2] https://bugs.eclipse.org/bugs/show_bug.cgi?id=279137 From gnu_andrew at member.fsf.org Thu Jul 23 08:36:48 2009 From: gnu_andrew at member.fsf.org (Andrew John Hughes) Date: Thu, 23 Jul 2009 16:36:48 +0100 Subject: Switching to HotSpot 14 on OpenJDK6 In-Reply-To: <20090723152650.1C8206F6@eggemoggin.niobe.net> References: <20090722214810.175B451B@eggemoggin.niobe.net> <20090723152650.1C8206F6@eggemoggin.niobe.net> Message-ID: <17c6771e0907230836u3f76c6f3j6112c22e015494d5@mail.gmail.com> 2009/7/23 Mark Reinhold : >> From: Mark Reinhold >> Date: Wed, 22 Jul 2009 14:48:10 -0700 > >> ... >> >> Your repo looks fine to me -- thanks for creating it. >> >> Shall I go ahead and replace the current jdk6/hotspot repo with this? >> (That is, does anyone have any concerns?) > > Here's something (perhaps) to be concerned about: A recently-reported > regression in Sun's proprietary 6u14 (and hence also in hsx14) causes > debugging breakpoints to be ignored in some circumstances. ?The bug is > reproducible with both the client and server VMs, but only using the > serial GC. > > The primary Sun bugid is 6862295 [1]; see also the downstream bug first > reported in Eclipse [2]. ?Dan Daugherty is working on a fix, which we'll > publish when available, but in the meantime hsx14 has this bug. > > Is the existence of this bug in hsx14 a reason to delay replacing the > current jdk6/hotspot repo with Andrew's newer version? ?Let me know. > > - Mark > > > [1] http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6862295 > [2] https://bugs.eclipse.org/bugs/show_bug.cgi?id=279137 > It's a concern, no doubt about that, but not moving to hs14 because of it is a bit like shutting the stable door after the horse has bolted; both IcedTea and Sun's proprietary releases have been shipping hs14 for some time. I think the better course of action is to get the patch in as soon as it is available and then roll it out in new releases. Besides, the proposed update doesn't (yet) move OpenJDK6 to HotSpot 14. It rebases the repository so it's now at revision 0 of the current HotSpot7 repositories (plus the OpenJDK6 fixes), allowing changesets from the hs14 master and also the main HotSpot7 repository to be merged (as they all then have a common parent). This is actually hs12b0 I believe (from b24 of OpenJDK7). -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From aph at redhat.com Thu Jul 23 08:52:00 2009 From: aph at redhat.com (Andrew Haley) Date: Thu, 23 Jul 2009 17:52:00 +0200 Subject: Switching to HotSpot 14 on OpenJDK6 In-Reply-To: <17c6771e0907230836u3f76c6f3j6112c22e015494d5@mail.gmail.com> References: <20090722214810.175B451B@eggemoggin.niobe.net> <20090723152650.1C8206F6@eggemoggin.niobe.net> <17c6771e0907230836u3f76c6f3j6112c22e015494d5@mail.gmail.com> Message-ID: <4A688720.5090800@redhat.com> On 07/23/2009 05:36 PM, Andrew John Hughes wrote: > 2009/7/23 Mark Reinhold : >>> From: Mark Reinhold >>> Date: Wed, 22 Jul 2009 14:48:10 -0700 >>> ... >>> >>> Your repo looks fine to me -- thanks for creating it. >>> >>> Shall I go ahead and replace the current jdk6/hotspot repo with this? >>> (That is, does anyone have any concerns?) >> Here's something (perhaps) to be concerned about: A recently-reported >> regression in Sun's proprietary 6u14 (and hence also in hsx14) causes >> debugging breakpoints to be ignored in some circumstances. The bug is >> reproducible with both the client and server VMs, but only using the >> serial GC. >> >> The primary Sun bugid is 6862295 [1]; see also the downstream bug first >> reported in Eclipse [2]. Dan Daugherty is working on a fix, which we'll >> publish when available, but in the meantime hsx14 has this bug. >> >> Is the existence of this bug in hsx14 a reason to delay replacing the >> current jdk6/hotspot repo with Andrew's newer version? Let me know. >> >> [1] http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6862295 >> [2] https://bugs.eclipse.org/bugs/show_bug.cgi?id=279137 >> > > It's a concern, no doubt about that, but not moving to hs14 because of > it is a bit like shutting the stable door after the horse has bolted; > both IcedTea and Sun's proprietary releases have been shipping hs14 > for some time. I think the better course of action is to get the > patch in as soon as it is available and then roll it out in new > releases. That sounds right to me. > Besides, the proposed update doesn't (yet) move OpenJDK6 to HotSpot > 14. It rebases the repository so it's now at revision 0 of the > current HotSpot7 repositories (plus the OpenJDK6 fixes), allowing > changesets from the hs14 master and also the main HotSpot7 repository > to be merged (as they all then have a common parent). This is > actually hs12b0 I believe (from b24 of OpenJDK7). Do I take it that you intend soon to submit a patch that moves OpenJDK 6 to HS 14? Andrew. From gnu_andrew at member.fsf.org Thu Jul 23 09:17:11 2009 From: gnu_andrew at member.fsf.org (Andrew John Hughes) Date: Thu, 23 Jul 2009 17:17:11 +0100 Subject: Switching to HotSpot 14 on OpenJDK6 In-Reply-To: <4A688720.5090800@redhat.com> References: <20090722214810.175B451B@eggemoggin.niobe.net> <20090723152650.1C8206F6@eggemoggin.niobe.net> <17c6771e0907230836u3f76c6f3j6112c22e015494d5@mail.gmail.com> <4A688720.5090800@redhat.com> Message-ID: <17c6771e0907230917h59c26566hd72acffe44a23ddc@mail.gmail.com> 2009/7/23 Andrew Haley : > On 07/23/2009 05:36 PM, Andrew John Hughes wrote: >> 2009/7/23 Mark Reinhold : >>>> From: Mark Reinhold >>>> Date: Wed, 22 Jul 2009 14:48:10 -0700 >>>> ... >>>> >>>> Your repo looks fine to me -- thanks for creating it. >>>> >>>> Shall I go ahead and replace the current jdk6/hotspot repo with this? >>>> (That is, does anyone have any concerns?) >>> Here's something (perhaps) to be concerned about: A recently-reported >>> regression in Sun's proprietary 6u14 (and hence also in hsx14) causes >>> debugging breakpoints to be ignored in some circumstances. ?The bug is >>> reproducible with both the client and server VMs, but only using the >>> serial GC. >>> >>> The primary Sun bugid is 6862295 [1]; see also the downstream bug first >>> reported in Eclipse [2]. ?Dan Daugherty is working on a fix, which we'll >>> publish when available, but in the meantime hsx14 has this bug. >>> >>> Is the existence of this bug in hsx14 a reason to delay replacing the >>> current jdk6/hotspot repo with Andrew's newer version? ?Let me know. > >>> >>> [1] http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6862295 >>> [2] https://bugs.eclipse.org/bugs/show_bug.cgi?id=279137 >>> >> >> It's a concern, no doubt about that, but not moving to hs14 because of >> it is a bit like shutting the stable door after the horse has bolted; >> both IcedTea and Sun's proprietary releases have been shipping hs14 >> for some time. ?I think the better course of action is to get the >> patch in as soon as it is available and then roll it out in new >> releases. > > That sounds right to me. > >> Besides, the proposed update doesn't (yet) move OpenJDK6 to HotSpot >> 14. ?It rebases the repository so it's now at revision 0 of the >> current HotSpot7 repositories (plus the OpenJDK6 fixes), allowing >> changesets from the hs14 master and also the main HotSpot7 repository >> to be merged (as they all then have a common parent). ?This is >> actually hs12b0 I believe (from b24 of OpenJDK7). > > Do I take it that you intend soon to submit a patch that moves OpenJDK 6 > to HS 14? > Indeed, that's the intention. I wanted to do as little as possible by replacing directories on the server side, leaving the actual merge to hs14 itself to the usual webrev-and-push process. So expect one mega-patch to update to hs14 once OpenJDK6 is rebased. > Andrew. > Thanks, -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From mr at sun.com Thu Jul 23 12:12:25 2009 From: mr at sun.com (Mark Reinhold) Date: Thu, 23 Jul 2009 12:12:25 -0700 Subject: Switching to HotSpot 14 on OpenJDK6 In-Reply-To: gnu_andrew@member.fsf.org; Thu, 23 Jul 2009 16:36:48 BST; <17c6771e0907230836u3f76c6f3j6112c22e015494d5@mail.gmail.com> Message-ID: <20090723191225.1C96A8E7@eggemoggin.niobe.net> > Date: Thu, 23 Jul 2009 16:36:48 +0100 > From: Andrew John Hughes > ... > > Besides, the proposed update doesn't (yet) move OpenJDK6 to HotSpot > 14. It rebases the repository so it's now at revision 0 of the > current HotSpot7 repositories (plus the OpenJDK6 fixes), allowing > changesets from the hs14 master and also the main HotSpot7 repository > to be merged (as they all then have a common parent). This is > actually hs12b0 I believe (from b24 of OpenJDK7). Ah, okay, I hadn't realized that. I've blown away the current jdk6/hotspot repository in preparation for dropping in your new repo. I need to make a couple of adjustments on the server prior to doing that, most likely some time tonight PDT. - Mark From mr at sun.com Fri Jul 24 00:04:05 2009 From: mr at sun.com (Mark Reinhold) Date: Fri, 24 Jul 2009 00:04:05 -0700 Subject: Switching to HotSpot 14 on OpenJDK6 In-Reply-To: mr@sun.com; Thu, 23 Jul 2009 12:12:25 PDT; <20090723191225.1C96A8E7@eggemoggin.niobe.net> Message-ID: <20090724070405.54CAEE92@eggemoggin.niobe.net> > From: Mark Reinhold > Date: Thu, 23 Jul 2009 12:12:25 -0700 > ... > > I've blown away the current jdk6/hotspot repository in preparation for > dropping in your new repo. I need to make a couple of adjustments on > the server prior to doing that, most likely some time tonight PDT. Done. http://hg.openjdk.java.net/jdk6/jdk6/hotspot is now a clone of http://fuseyism.com/hg/hotspot, plus the addition of one tiny changeset so that the jcheck hook will allow lax comments. - Mark From mark at klomp.org Fri Jul 24 01:37:19 2009 From: mark at klomp.org (Mark Wielaard) Date: Fri, 24 Jul 2009 10:37:19 +0200 Subject: Switching to HotSpot 14 on OpenJDK6 In-Reply-To: <20090724070405.54CAEE92@eggemoggin.niobe.net> References: <20090724070405.54CAEE92@eggemoggin.niobe.net> Message-ID: <1248424639.3544.8.camel@springer.wildebeest.org> On Fri, 2009-07-24 at 00:04 -0700, Mark Reinhold wrote: > > From: Mark Reinhold > > Date: Thu, 23 Jul 2009 12:12:25 -0700 > > > I've blown away the current jdk6/hotspot repository in preparation for > > dropping in your new repo. I need to make a couple of adjustments on > > the server prior to doing that, most likely some time tonight PDT. > > Done. > > http://hg.openjdk.java.net/jdk6/jdk6/hotspot is now a clone of > http://fuseyism.com/hg/hotspot, plus the addition of one tiny > changeset so that the jcheck hook will allow lax comments. Thanks. For those doing their morning fpull, this means you will have to blow away your jdk6 forest jdk/hotspot subtree, or you will see: [hotspot] pulling from http://hg.openjdk.java.net/jdk6/jdk6/hotspot searching for changes skipped: repository is unrelated You can just move the jdk/hotpot dir away from under the jdk/ dir and a hg fpull will get you a completely new fresh copy. [hotspot] requesting all changes adding changesets adding manifests adding file changes added 58 changesets with 7893 changes to 3278 files Mirrors updated. For those interested in the old hotspot6 repo I kept a clone here: http://classpath.wildebeest.org/hg/hotspot6.old Cheers, Mark From alex.menkov at sun.com Fri Jul 24 07:12:29 2009 From: alex.menkov at sun.com (Alex Menkov) Date: Fri, 24 Jul 2009 18:12:29 +0400 Subject: APPROVED: SV: [Request for review] 6833357: Improve time-stamp support in Gervill to reduce jitter. In-Reply-To: <36EC82E93EB0AD40A4301DAD65432386F5BA863E2D@mail.midverk.is> References: <36EC82E93EB0AD40A4301DAD65432386F5BA863E2A@mail.midverk.is> <4A65E09A.6080405@sun.com> <36EC82E93EB0AD40A4301DAD65432386F5BA863E2D@mail.midverk.is> Message-ID: <4A69C14D.6090308@sun.com> Approved. Regards Alex Karl Helgason wrote: > Hi Alex, > > This was my fault. My patch isn't reapplying that fix, it is reverting it. > > Here is a new and improved webrev: > http://cr.openjdk.java.net/~kalli/6833357/webrev.02/ > > regards, > Karl > > ________________________________________ > Fr?: Alexey.Menkov at Sun.COM [Alexey.Menkov at Sun.COM] Fyrir hönd Alex Menkov [alex.menkov at Sun.COM] > Sent: 21. j?l? 2009 15:36 > Vi?takandi: Karl Helgason > Afrit: jdk6-dev at openjdk.java.net; Dalibor.Topic at Sun.COM > Efni: Re: [Request for review] 6833357: Improve time-stamp support in Gervill to reduce jitter. > > Hi Karl, > > Looks good for me. > The only note is about something strange with SoftSynthesizer.java (open > method): your patch reapply a fix which is already in the repo. > Looks like you have inconsistent repository. > > Regards > Alex > > Karl Helgason wrote: >> Hi, >> >> I need code review for the fix: >> http://cr.openjdk.java.net/~kalli/6833357/webrev/ >> >> This fix adds support for zero-jitter playback when using time-stamped MIDI events. >> >> Full potential of this fix won't come until time-stamp support has been added to RealTimeSequencer. >> see: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6833358 >> >> Here is a overview of changes made: >> SoftLimiter.java - Fix NullPointerException when in mono mode >> SoftChannel.java - Add note on int delay parameter >> SoftReceiver - Add getMidiDevice method and fix midi activity detection >> SoftAudioBuffer - Add swap method >> SoftMainMixer, SoftSynthesizer, SoftVoice - Add delay logic >> >> regards, >> Karl From gnu_andrew at member.fsf.org Fri Jul 24 08:31:27 2009 From: gnu_andrew at member.fsf.org (Andrew John Hughes) Date: Fri, 24 Jul 2009 16:31:27 +0100 Subject: Switching to HotSpot 14 on OpenJDK6 In-Reply-To: <20090724070405.54CAEE92@eggemoggin.niobe.net> References: <20090723191225.1C96A8E7@eggemoggin.niobe.net> <20090724070405.54CAEE92@eggemoggin.niobe.net> Message-ID: <17c6771e0907240831r45dc2114p433e8d4424e05d5e@mail.gmail.com> 2009/7/24 Mark Reinhold : >> From: Mark Reinhold >> Date: Thu, 23 Jul 2009 12:12:25 -0700 > >> ... >> >> I've blown away the current jdk6/hotspot repository in preparation for >> dropping in your new repo. ?I need to make a couple of adjustments on >> the server prior to doing that, most likely some time tonight PDT. > > Done. > > http://hg.openjdk.java.net/jdk6/jdk6/hotspot is now a clone of > http://fuseyism.com/hg/hotspot, plus the addition of one tiny > changeset so that the jcheck hook will allow lax comments. > > - Mark > Thanks. I'm guessing the changeset 'Remove old jdk6-b00.' needed the lax comments filter, so sorry about that. -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From kalli at midverk.is Fri Jul 24 18:39:37 2009 From: kalli at midverk.is (kalli at midverk.is) Date: Sat, 25 Jul 2009 01:39:37 +0000 Subject: hg: jdk6/jdk6/jdk: 6833357: Improve time-stamp support in Gervill to reduce jitter. Message-ID: <20090725013956.2A2ADE5F1@hg.openjdk.java.net> Changeset: ac4f0c58f4c7 Author: kalli Date: 2009-07-25 01:30 +0000 URL: http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/ac4f0c58f4c7 6833357: Improve time-stamp support in Gervill to reduce jitter. Reviewed-by: amenkov + src/share/classes/com/sun/media/sound/MidiDeviceReceiver.java ! src/share/classes/com/sun/media/sound/SoftAudioBuffer.java ! src/share/classes/com/sun/media/sound/SoftChannel.java ! src/share/classes/com/sun/media/sound/SoftLimiter.java ! src/share/classes/com/sun/media/sound/SoftMainMixer.java ! src/share/classes/com/sun/media/sound/SoftReceiver.java ! src/share/classes/com/sun/media/sound/SoftSynthesizer.java ! src/share/classes/com/sun/media/sound/SoftVoice.java + test/javax/sound/midi/Gervill/SoftReceiver/GetMidiDevice.java + test/javax/sound/midi/Gervill/SoftSynthesizer/TestPreciseTimestampRendering.java From Daniel.Daugherty at Sun.COM Wed Jul 29 08:11:46 2009 From: Daniel.Daugherty at Sun.COM (Daniel D. Daugherty) Date: Wed, 29 Jul 2009 09:11:46 -0600 Subject: Switching to HotSpot 14 on OpenJDK6 In-Reply-To: <17c6771e0907230836u3f76c6f3j6112c22e015494d5@mail.gmail.com> References: <20090722214810.175B451B@eggemoggin.niobe.net> <20090723152650.1C8206F6@eggemoggin.niobe.net> <17c6771e0907230836u3f76c6f3j6112c22e015494d5@mail.gmail.com> Message-ID: <4A7066B2.7050905@sun.com> An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/jdk6-dev/attachments/20090729/9c6f9bf6/attachment.html From gnu_andrew at member.fsf.org Wed Jul 29 08:14:34 2009 From: gnu_andrew at member.fsf.org (Andrew John Hughes) Date: Wed, 29 Jul 2009 16:14:34 +0100 Subject: Switching to HotSpot 14 on OpenJDK6 In-Reply-To: <4A7066B2.7050905@sun.com> References: <20090722214810.175B451B@eggemoggin.niobe.net> <20090723152650.1C8206F6@eggemoggin.niobe.net> <17c6771e0907230836u3f76c6f3j6112c22e015494d5@mail.gmail.com> <4A7066B2.7050905@sun.com> Message-ID: <17c6771e0907290814sa8aa2b7hf075217d0ca2c922@mail.gmail.com> 2009/7/29 Daniel D. Daugherty : > Andrew John Hughes wrote: > > 2009/7/23 Mark Reinhold : > > > From: Mark Reinhold > Date: Wed, 22 Jul 2009 14:48:10 -0700 > > > ... > > Your repo looks fine to me -- thanks for creating it. > > Shall I go ahead and replace the current jdk6/hotspot repo with this? > (That is, does anyone have any concerns?) > > > Here's something (perhaps) to be concerned about: A recently-reported > regression in Sun's proprietary 6u14 (and hence also in hsx14) causes > debugging breakpoints to be ignored in some circumstances. ?The bug is > reproducible with both the client and server VMs, but only using the > serial GC. > > The primary Sun bugid is 6862295 [1]; see also the downstream bug first > reported in Eclipse [2]. ?Dan Daugherty is working on a fix, which we'll > publish when available, but in the meantime hsx14 has this bug. > > Is the existence of this bug in hsx14 a reason to delay replacing the > current jdk6/hotspot repo with Andrew's newer version? ?Let me know. > > - Mark > > > [1] http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6862295 > [2] https://bugs.eclipse.org/bugs/show_bug.cgi?id=279137 > > > > It's a concern, no doubt about that, but not moving to hs14 because of > it is a bit like shutting the stable door after the horse has bolted; > both IcedTea and Sun's proprietary releases have been shipping hs14 > for some time. I think the better course of action is to get the > patch in as soon as it is available and then roll it out in new > releases. > > Besides, the proposed update doesn't (yet) move OpenJDK6 to HotSpot > 14. It rebases the repository so it's now at revision 0 of the > current HotSpot7 repositories (plus the OpenJDK6 fixes), allowing > changesets from the hs14 master and also the main HotSpot7 repository > to be merged (as they all then have a common parent). This is > actually hs12b0 I believe (from b24 of OpenJDK7). > > > The fix for 6862295 was pushed to the hotspot-rt repo for HSX-16 > last night; it should be integrated in HSX-16-B08. I have the > same fix queued up for HSX-14.1 or HSX-14.2 depending on whether > the fix is approved for 6u15 or 6u16. > > I also have the fix ready for the > http://hg.openjdk.java.net/jdk6/jdk6/hotspot repo. The only odd > thing I see is that the changeset ID is different for openjdk6 > version: > > changeset:?? 58:52f2c77b32e1 > tag:???????? tip > user:??????? dcubed > date:??????? Tue Jul 28 13:35:00 2009 -0600 > files:?????? src/share/vm/memory/genCollectedHeap.cpp > src/share/vm/prims/jvmtiExport.cpp src/share/vm/runtime/globals.hpp > description: > 6862295: JDWP threadid changes during debugging session (leading to ingored > breakpoints) > Summary: Correctly count full GC operations for framework collectors. Add > ForceFullGCJVMTIEpilogues as a future work around if needed. > Reviewed-by: jcoomes, alanb, ysr > > > Here is the changeset from the HSX-14.[12] and HSX-16 versions: > > changeset:?? 558:2b4230d1e589 > parent:????? 501:26bc4770e671 > user:??????? dcubed > date:??????? Tue Jul 28 13:35:00 2009 -0600 > files:?????? src/share/vm/memory/genCollectedHeap.cpp > src/share/vm/prims/jvmtiExport.cpp src/share/vm/runtime/globals.hpp > description: > 6862295: JDWP threadid changes during debugging session (leading to ingored > breakpoints) > Summary: Correctly count full GC operations for framework collectors. Add > ForceFullGCJVMTIEpilogues as a future work around if needed. > Reviewed-by: jcoomes, alanb, ysr > > > I used "hg export" from the HSX-14.1 version to generate the > patch for the openjdk6 version and I used "hg import" on the > patch file. I expected the changeset ID to be the same. > > For the HSX-14.[12] and HSX-16 versions, I found the common > ancestor changeset (501:26bc4770e671), made the changes > relative to that changeset and merged the changes forward > to each release's repo. The common changeset for HSX-14.1 > and openjdk6 goes all the way back to changeset 1. Ouch! > > Maybe there's a better way to do this... > > Dan > > P.S. > What's the process for getting the fix into openjdk6? > Hi Dan, As I mentioned in my last mail, OpenJDK6's repo is still as it was before: at hs12b0. It and the other HotSpot repositories now have a common ancestor, but it's not yet a copy of hs14. I plan to post a webrev moving it forward to hs14 (via a pull from hs14/master). It might be easier to just wait until this is applied, or, if the patch you mention is already in hs14/master it will get applied as part of this merge anyway. Hope that helps, -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From gnu_andrew at member.fsf.org Fri Jul 31 20:44:29 2009 From: gnu_andrew at member.fsf.org (Andrew John Hughes) Date: Sat, 1 Aug 2009 04:44:29 +0100 Subject: [FOR REVIEW] hs14 merge for OpenJDK6 Message-ID: <17c6771e0907312044q43080f55y3353927a57dca99f@mail.gmail.com> Here it is, the mother of all webrevs: http://cr.openjdk.java.net/~andrew/jdk6-hs14-merge/webrev.01/ with the patch itself being ~13mb. This takes OpenJDK6 up to HotSpot 14 build 16 (see http://hg.openjdk.java.net/hsx/hsx14/master/), incorporating 553 changesets from the hs14 repo. and one merge changeset. I'll shortly push this to http://fuseyism.com/hg/hotspot too. Ok to push? -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8 From Erik.Trimble at Sun.COM Fri Jul 31 23:49:51 2009 From: Erik.Trimble at Sun.COM (Erik Trimble) Date: Fri, 31 Jul 2009 23:49:51 -0700 Subject: [FOR REVIEW] hs14 merge for OpenJDK6 In-Reply-To: <17c6771e0907312044q43080f55y3353927a57dca99f@mail.gmail.com> References: <17c6771e0907312044q43080f55y3353927a57dca99f@mail.gmail.com> Message-ID: <4A73E58F.9020502@sun.com> Andrew John Hughes wrote: > Here it is, the mother of all webrevs: > > http://cr.openjdk.java.net/~andrew/jdk6-hs14-merge/webrev.01/ > > with the patch itself being ~13mb. > > This takes OpenJDK6 up to HotSpot 14 build 16 (see > http://hg.openjdk.java.net/hsx/hsx14/master/), incorporating 553 > changesets from the hs14 repo. and one merge changeset. > I'll shortly push this to http://fuseyism.com/hg/hotspot too. > > Ok to push? > I approve. -- Erik Trimble Java System Support Mailstop: usca22-123 Phone: x17195 Santa Clara, CA Timezone: US/Pacific (GMT-0800)