SV: [Request for review] 6833357: Improve time-stamp support in Gervill to reduce jitter.

[Karl Helgason]

Hi Alex,

This was my fault. My patch isn't reapplying that fix, it is reverting it.

Here is a new and improved webrev:
  http://cr.openjdk.java.net/~kalli/6833357/webrev.02/

regards,
Karl

________________________________________
Frá: Alexey.Menkov at Sun.COM [Alexey.Menkov at Sun.COM] Fyrir hönd Alex Menkov [alex.menkov at Sun.COM]
Sent: 21. júlí 2009 15:36
Viðtakandi: Karl Helgason
Afrit: jdk6-dev at openjdk.java.net; Dalibor.Topic at Sun.COM
Efni: Re: [Request for review] 6833357: Improve time-stamp support in Gervill to reduce jitter.

Hi Karl,

Looks good for me.
The only note is about something strange with SoftSynthesizer.java (open
method): your patch reapply a fix which is already in the repo.
Looks like you have inconsistent repository.

Regards
Alex

Karl Helgason wrote:
> Hi,
>
> I need code review for the fix:
>    http://cr.openjdk.java.net/~kalli/6833357/webrev/
>
> This fix adds support for zero-jitter playback when using time-stamped MIDI events.
>
> Full potential of this fix won't come until time-stamp support has been added to RealTimeSequencer.
>    see: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6833358
>
> Here is a overview of changes made:
>    SoftLimiter.java -  Fix NullPointerException when in mono mode
>    SoftChannel.java -  Add note on int delay parameter
>    SoftReceiver -  Add getMidiDevice method and fix midi activity detection
>    SoftAudioBuffer - Add swap method
>    SoftMainMixer, SoftSynthesizer, SoftVoice -  Add delay logic
>
> regards,
> Karl