hg: jdk6/jdk6/corba: 6746424: Remove build dependency on findbugs and FINDBUGS_HOME
Kelly O'Hair
Kelly.Ohair at Sun.COM
Thu May 7 09:03:20 PDT 2009
Andrew John Hughes wrote:
> 2009/5/6 <kelly.ohair at sun.com>:
>> Changeset: 452dfe027c41
>> Author: ohair
>> Date: 2009-05-05 16:58 -0700
>> URL: http://hg.openjdk.java.net/jdk6/jdk6/corba/rev/452dfe027c41
>>
>> 6746424: Remove build dependency on findbugs and FINDBUGS_HOME
>> Reviewed-by: robilad
>>
>> ! make/common/shared/Defs-utils.gmk
>>
>>
>
> Why the removal of the lines regarding Ant? This doesn't seem to be
> mentioned in this bug.
The corba builds never used ant, this was just carry over from these files
being copied from the jdk repository.
Ultimately these makefiles in corba will go away, or the whole thing
will change. So these lines being deleted in corba is just clean up.
>
> Note that last time I looked, you could just run FindBugs directly
> from its website via jaxws and that worked fine on GNU Classpath using
> IcedTea's jaxws implementation.
The removal of findbugs from the makefile and the build dependencies
is just a build simplification issue.
Initially I had hoped that running findbugs during the build would be
just part of the build, but it just isn't practical. It takes too long
to run on every build.
Don't get me wrong, I love findbugs, and want to use it regularly, it
just doesn't make sense to burden the build system with it.
I need a better way to get it run regularly, maybe with a separate
continuous job run on a regular basis, separate from the building.
-kto
More information about the jdk6-dev
mailing list