PING: Nimbus patch

[Andrew John Hughes]

2009/10/23 Joseph D. Darcy <Joe.Darcy at sun.com>:
> Andrew John Hughes wrote:
>>
>> 2009/10/22 Joseph D. Darcy <Joe.Darcy at sun.com>:
>>
>
> [snip]
>
>>
>> So here's a combined webrev for the bug fix changesets that occurred
>> between the initial import and the JIBX removal:
>>
>
> So JIBX removal will be in the next round of changes?
>

Yes; well it will actually be the next round on its own:

http://cr.openjdk.java.net/~andrew/6844267/webrev.01/

changeset:   1575:7e7153da24ef
user:        peterz
date:        Mon Aug 31 13:56:34 2009 +0400
summary:     6844267: Nimbus generator depends on JIBX

http://hg.openjdk.java.net/jdk7/jdk7/jdk/rev/7e7153da24ef

>> http://cr.openjdk.java.net/~andrew/nimbus/webrev.02/
>>
>> Relevant changesets:
>>
>> changeset:   1574:f7d606ca25a9
>> user:        peterz
>> date:        Mon Aug 31 13:46:24 2009 +0400
>> summary:     6802944: Nimbus initialization is too slow
>>
>> changeset:   1385:a2114bbf7f3e
>> user:        peterz
>> date:        Mon Jul 20 13:34:54 2009 +0400
>> summary:     6849331: Nimbus L&F: AbstractRegionPainter's paint
>> context is not initialized
>>
>> changeset:   1384:4575323d917c
>> user:        peterz
>> date:        Mon Jul 20 13:33:09 2009 +0400
>> summary:     6857360: NimbusLAF: Menu indicator looks ugly with RTL
>> orientation.
>>
>> changeset:   1297:95f3fb73cf60
>> user:        peterz
>> date:        Fri Jun 26 21:43:21 2009 +0400
>> summary:     6849805: Nimbus L&F: NimbusLookAndFeel.getDerivedColor()
>> not always returns color2 for 1.0 midPoint
>>
>> changeset:   1293:f1f9d228800e
>> user:        peterz
>> date:        Fri Jun 26 08:09:19 2009 +0400
>> summary:     6827032: NIMBUS: Drag and drop throws a NPE in SwingSet2
>> ColorChooser
>>
>> changeset:   1227:c06d30bd8c69
>> user:        andrew
>> date:        Thu May 21 16:29:58 2009 +0100
>> summary:     6841728: Make building the Nimbus L 'n' F optional (100054)
>>
>> changeset:   1212:ce347002bbd9
>> user:        peterz
>> date:        Tue Jun 23 12:24:11 2009 +0400
>> summary:     6844273: jdk/make/docs/CORE_PKGS.gmk does not list Nimbus
>>
>> changeset:   1211:743021a4938c
>> user:        peterz
>> date:        Mon Jun 22 18:08:50 2009 +0400
>> summary:     6849277: Nimbus L&F: lots of painter classes were added
>> to JDK7 as public
>>
>> changeset:   1207:af491a9b7c1d
>> user:        peterz
>> date:        Fri May 15 12:06:22 2009 +0400
>> summary:     6827581: Contextkey does not work in Nimbus
>>
>> changeset:   1206:455b357442c7
>> user:        peterz
>> date:        Thu May 14 18:12:13 2009 +0400
>> summary:     6741426: ClassCastException from ComboBoxEditableState
>> (Nimbus LaF) in JDK 1.6.0_10 RC
>>
>> changeset:   916:8df0db057762
>> user:        peterz
>> date:        Tue Apr 28 21:41:04 2009 +0400
>> summary:     6835113: Nimbus Makefile issue
>>
>> changeset:   915:7f45fcc04f8e
>> user:        peterz
>> date:        Sat Apr 25 21:17:50 2009 +0400
>> summary:     6591875: Nimbus Swing Look and Feel
>>
>> changeset:   278:3f7b2ea2d611
>> user:        rupashka
>> date:        Mon Aug 11 16:39:17 2008 +0400
>> summary:     6604281: NimbusL&F :Regression in Focus traversal in
>> JFileChooser in pit build.
>>
>> The above are the original JDK7 changeset IDs so you can look up any
>> of them by going to e.g.
>> http://hg.openjdk.java.net/jdk7/jdk7/jdk/rev/3f7b2ea2d611
>> The only changes in the JDK6 version are again to change the
>> javax.swing.plaf.nimbus namespace to com.sun.java.swing.plaf.nimbus (a
>> simple find-and-replace operation on the patch).
>>
>> Ok to push?
>>
>
> In Sanity.gmk
>
> 1576 ifdef DISABLE_NIMBUS   1577         $(call SanityWarning,Disabling
> Nimbus will remove public API in javax.swing.plaf.nimbus.)
> 1578 else
> 1579         @if [ ! -r $(subst \,/,$(JIBX_LIBS_PATH))/jibx-run.jar ]; then
> \
> 1580           $(ECHO) "ERROR: You do not have access to valid JIBX library
> files. \n" \
> 1581             "      Please check your access to \n" \
> 1582             "          $(subst \,/,$(JIBX_LIBS_PATH))/jibx-run.jar \n"
> \
> 1583             "      and/or check your value of ALT_JDK_DEVTOOLS_DIR,
> ALT_JIBX_LIBS_PATH \n" \
> 1584             "" >> $(ERROR_FILE) ; \
> 1585         fi
> 1586 endif
>
> the package name in the warning is incorrect for OpenJDK 6, but since JIBX
> will be going away it doesn't matter that much if it is fixed or not.
>

Not only is the package wrong, it's not public API.  The new webrev
removes it anyway as you say.


> Approved to be committed.
>

Done; see http://hg.openjdk.java.net/jdk6/jdk6/jdk/shortlog

> Thanks,
>
> -Joe
>



-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8