PING: Nimbus patch

[Andrew John Hughes]

2009/10/27 Joseph D. Darcy <Joe.Darcy at sun.com>:
> Andrew John Hughes wrote:
>>
>> 2009/10/27 Joseph D. Darcy <Joe.Darcy at sun.com>:
>>
>>>
>>> Andrew John Hughes wrote:
>>>
>>>>
>>>> 2009/10/23 Joseph D. Darcy <Joe.Darcy at sun.com>:
>>>>
>>>>
>>>>>
>>>>> Andrew John Hughes wrote:
>>>>>
>>>>>
>
> [snip]
>>>
>>> Hello.
>>>
>>> The 1998-2005 copyright on
>>> make/tools/generate_nimbus/Makefile
>>> and similar ranges on other new files is a bit surprising, but since that
>>> is
>>> what appears to be on those files in JDK 7, c'est la vie (for now).
>>>
>>>
>>
>> Strange; I see quite a few of these changes and assume there is some
>> reasoning behind them.  Though what I have no idea...
>>
>>
>>>
>>> Approved to go back into OpenJDK 6.
>>>
>>>
>>
>> http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/ccbadda19345
>>
>> There's one final changeset:
>>
>> changeset:   1652:6115613a3386
>> user:        peterz
>> date:        Wed Sep 23 21:14:53 2009 +0400
>> summary:     6857888:
>> closed/javax/swing/JMenuItem/6458123/bug6458123.java fails with
>> InvocationTargetException.
>>
>> http://hg.openjdk.java.net/jdk7/jdk7/jdk/rev/6115613a3386
>>
>> but the changes to
>> src/share/classes/javax/swing/plaf/synth/SynthGraphicsUtils.java in
>> that patch won't apply without also applying an earlier fix.
>>
>> changeset:   277:7d45141e5d30
>> user:        mlapshin
>> date:        Fri Aug 08 20:49:26 2008 +0400
>> summary:     6584657: GTK Look and Feel: Bugs in menu item layout
>>
>> http://hg.openjdk.java.net/jdk7/jdk7/jdk/rev/7d45141e5d30
>>
>> Should I backport both?
>>
>
> The latter patch is large, but it has been in JDK 7 for a while and is
> targeted at Linux platforms.
>
> Please backport both changesets to OpenJDK 6.
>
> Thanks,
>
> -Joe
>

Ok, final webrev is here:

http://cr.openjdk.java.net/~andrew/nimbus/webrev.03/
-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8