Review request for 6881637: Remove references to unused build directory in hotspot makefiles

[Andrew John Hughes]

2009/9/15 Dalibor Topic <Dalibor.Topic at sun.com>:
> Thanks, pushed.
>
>
> Joseph D. Darcy wrote:
>> Looks good.
>>
>> -Joe
>>
>> Kelly O'Hair wrote:
>>> Looks fine with me.
>>>
>>> -kto
>>>
>>> Dalibor Topic wrote:
>>>> Hi,
>>>>
>>>> here's a request for review for the change bringing the hostpot
>>>> makefiles
>>>> in line with hsx14 master as suggested by Erik Trimble in
>>>> http://mail.openjdk.java.net/pipermail/jdk6-dev/2009-September/000780.html
>>>>
>>>>
>>>> The webrev is at:
>>>>
>>>> http://cr.openjdk.java.net/~robilad/6881637/webrev.00/
>>>>
>>>> cheers,
>>>> dalibor topic
>>
>
>
> --
> *******************************************************************
> Dalibor Topic                   Tel: (+49 40) 23 646 738
> Java F/OSS Ambassador           AIM: robiladonaim
> Sun Microsystems GmbH           Mobile: (+49 177) 2664 192
> Nagelsweg 55                    http://openjdk.java.net
> D-20097 Hamburg                 mailto:Dalibor.Topic at sun.com
> Sitz der Gesellschaft: Sonnenallee 1, D-85551 Kirchheim-Heimstetten
> Amtsgericht München: HRB 161028
> Geschäftsführer: Thomas Schröder, Wolfgang Engels, Wolf Frenkel
> Vorsitzender des Aufsichtsrates: Martin Häring
>
>
>

This is the right change to sync with hs14 (presumably it occurred in
the dead area between OpenJDK6 and b24), as the Queens build has been
integrated into the test_gamma target.  However, the overall change to
move it there makes things more complicated IMO; we now have one way
of building Java code generally (COMPILE.JAVAC) and a different one
for test_gamma (invoking $JAVA_HOME/bin/javac).  It would preferable
if COMPILE.JAVAC was still used so that changes to it propagate to the
Queens build.  Why was this changed?
-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8