[kelly.ohair at oracle.com: Re: Test Backports]

[Kelly O'Hair]

Sorry. My fault.

-kto

On Apr 8, 2010, at 12:57 PM, Andrew John Hughes wrote:

> This discussion seems to have moved off-list... :-(
>
> ----- Forwarded message from Kelly O'Hair <kelly.ohair at oracle.com>  
> -----
>
> Date: Thu, 8 Apr 2010 12:00:36 -0700
> From: Kelly O'Hair <kelly.ohair at oracle.com>
> To: Joe Darcy <joe.darcy at oracle.com>
> Subject: Re: Test Backports
>
>
> On Apr 8, 2010, at 11:21 AM, Joe Darcy wrote:
>
>> On 04/08/10 10:16 AM, Kelly O'Hair wrote:
>>>
>>> If there is something I need to do on this email thread, please
>>> let me know,
>>> I am unable to follow the discussion very well.
>>>
>>> -kto
>>
>> Kelly,
>>
>> Please review Andrew's backport of 6873059 "Explicitly use -source
>> 6 -target 6 when compiling with the boot jdk javac" to OpenJDK 6:
>>
>> http://cr.openjdk.java.net/~andrew/6873059/webrev.01/
>
> The jdk and corba changes look fine.
>
> For hotspot...
> I don't know what various javac's will do when the -source and -target
> options show up twice,
> and I think where the makefiles are using 1.4 settings, that will
> happen. Is that ok? Last setting wins?
>
> I'm kind of surprised that hotspot used javac -g all over the place,
> seems needless for
> normal builds. So I'm happy with the removals of the -g's, but wonder
> if the default
> should be no -g at all, or at least isolate the -g option and have it
> controlled by the
> same make variables that the jdk uses to control 'javac -g'?
> And there is still the outstanding issue that hotspot makefiles should
> really be using the
> langtools javac to do all it's java compilations, not the boot javac,
> but that's for another day.
>
> I've kind of distanced myself a bit from the hotspot makefiles
> recently, since they just added
> back all kinds of jdk5-isms (_g suffix etc.). They pretty much belong
> to the hotspot team now.
>
> -kto
>
>>
>> -Joe
>
>
> ----- End forwarded message -----
>
> -- 
> Andrew :)
>
> Free Java Software Engineer
> Red Hat, Inc. (http://www.redhat.com)
>
> Support Free Java!
> Contribute to GNU Classpath and the OpenJDK
> http://www.gnu.org/software/classpath
> http://openjdk.java.net
> PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
> Fingerprint = F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8