[Request for review and bugid] Gervill - ModelStandardIndexedDirector fails on invalid ranges.

Karl Helgason kalli at midverk.is
Mon Apr 12 12:04:02 PDT 2010


Hi,

I need code review and bugid for the fix:
  http://cr.openjdk.java.net/~kalli/gervill-update2/webrev.01/

This fixes two issues:

 * ModelStandardIndexedDirector fails on invalid ranges.
   This fix is very IMPORTANT!
   Some songs+soundfonts combinations fails playing without this fix.

 * Program change with 16-bit banks doesn't work correctly.
    This is a very minor fix.

JTreg tests have been created for both those issues.

I am also working on another fix (not included in this fix)

 * SoftAbstractResampler doesn't work correctly
    when using interpolation algorithms that requires
    large padding like sinc interpolation.

regards,
Karl





More information about the jdk6-dev mailing list