[Request for review and bugid] Gervill - ModelStandardIndexedDirector fails on invalid ranges.

[Andrew John Hughes]

On 12 April 2010 21:07, Joe Darcy <joe.darcy at oracle.com> wrote:
> Andrew John Hughes wrote:
>>
>> On 12 April 2010 20:04, Karl Helgason <kalli at midverk.is> wrote:
>>
>>>
>>> Hi,
>>>
>>> I need code review and bugid for the fix:
>>>  http://cr.openjdk.java.net/~kalli/gervill-update2/webrev.01/
>>>
>>> This fixes two issues:
>>>
>>>  * ModelStandardIndexedDirector fails on invalid ranges.
>>>  This fix is very IMPORTANT!
>>>  Some songs+soundfonts combinations fails playing without this fix.
>>>
>>>  * Program change with 16-bit banks doesn't work correctly.
>>>   This is a very minor fix.
>>>
>>> JTreg tests have been created for both those issues.
>>>
>>> I am also working on another fix (not included in this fix)
>>>
>>>  * SoftAbstractResampler doesn't work correctly
>>>   when using interpolation algorithms that requires
>>>   large padding like sinc interpolation.
>>>
>>> regards,
>>> Karl
>>>
>>>
>>>
>>>
>>>
>>
>> A slightly off-topic point, but it would be good if this fix had a
>> more descriptive summary than the last when pushed:
>>
>> http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/74e449a8c951
>>
>> Are these being pushed to JDK7 as well?
>>
>
> These Gervill fixes should also be pushed to JDK 7.
>

Which tree? I can forwardport the last one now.

> -Joe
>



-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8