[Request for review and bugid] Gervill - ModelStandardIndexedDirector fails on invalid ranges.

[joe.darcy at oracle.com]

Hello.

It would be preferable if this got back in the next day or two.

Thanks,

-Joe

On 4/13/2010 5:58 AM, Alex Menkov wrote:
> Hi Karl,
>
> The fix looks fine for me.
> Feel free to push.
>
> regards
> Alex
>
> Joe Darcy wrote:
>> Hello.
>>
>> Karl Helgason wrote:
>>> Hi,
>>>
>>> I need code review and bugid for the fix:
>>>   http://cr.openjdk.java.net/~kalli/gervill-update2/webrev.01/
>>>
>>> This fixes two issues:
>>>
>>>  * ModelStandardIndexedDirector fails on invalid ranges.
>>>    This fix is very IMPORTANT!
>>>    Some songs+soundfonts combinations fails playing without this fix.
>>>
>>>  * Program change with 16-bit banks doesn't work correctly.
>>>     This is a very minor fix.
>>>   
>>
>> I've created bug 6943053 "Gervill: failures on invalid ranges and 
>> 16-bit banks" for these issues.  Alexey will need to do the technical 
>> code review.
>>
>> Since the fix is near at hand, I'm willing to hold OpenJDK 6 b19 for 
>> a few days until this can get in.
>>
>>> JTreg tests have been created for both those issues.
>>>
>>> I am also working on another fix (not included in this fix)
>>>
>>>  * SoftAbstractResampler doesn't work correctly
>>>     when using interpolation algorithms that requires
>>>     large padding like sinc interpolation.
>>>   
>>
>> Unless I hear arguments otherwise, I do not plan to hold b19 for this 
>> fix; it can go into b20 after the fix is ready.
>>
>> -Joe