[Request for review and bugid] Gervill - ModelStandardIndexedDirector fails on invalid ranges.

Joe Darcy joe.darcy at oracle.com
Thu Apr 15 19:23:08 PDT 2010


Andrew John Hughes wrote:
> On 13 April 2010 17:29, Joe Darcy <joe.darcy at oracle.com> wrote:
>   
>> Alex Menkov wrote:
>>     
>>> Joe, Andrew,
>>>
>>> sound fixes have a bit tangled "patch logistics" :)
>>> Karl pushes changes into openjdk6, then I forwardport them into jdk7 (to
>>> minimize QE I push sound fixes in batches, so often fixes go to jdk7 with a
>>> delay).
>>> openjdk6 repo does not use jcheck extension, so I fix whitespace
>>> normalization issues only pushing changes into jdk7.
>>>       
>> About jcheck, OpenJDK 6 does use jcheck, but it is configured differently
>> than in JDK 7.  For OpenJDK 6, jcheck is lax on both repeated bug ids and
>> whitespace.  The former was necessary for some HotSpot merge issues and the
>> latter was necessary to capture the full public history of OpenJDK 6.
>>
>> -Joe
>>
>>     
>
> Any reason we can't enforce the whitespace check on new OpenJDK6
> patches?  This would help keep 6 & 7 in sync.
>   

I suppose it would just be a "small matter of programming" to have 
jcheck be lax in whitespace for older changesets but enforce the checks 
after a certain point...

-Joe


More information about the jdk6-dev mailing list