JTreg errors in OpenJDK6 - missing HTML files

[Andrew John Hughes]

On 29 April 2010 18:40, Joe Darcy <joe.darcy at oracle.com> wrote:
> Hello.
>
> On 04/28/10 06:14 AM, Andrew John Hughes wrote:
>
> On 28 April 2010 13:10, Pavel Tisnovsky <ptisnovs at redhat.com> wrote:
>
>
> Hi,
>
> I saw that some JTreg tests, specifically:
>
> java/awt/Focus/ActualFocusedWindowTest/ActualFocusedWindowBlockingTest.java
> java/awt/Focus/ActualFocusedWindowTest/ActualFocusedWindowRetaining.java
>  java/awt/Focus/NonFocusableWindowTest/NonfocusableOwnerTest.java
>
> fails due to absence of HTML files from which these tests are started as
> applets.
>
>
> I looked into those error messages a little bit; the corresponding tests
> pass fine on JDK 7 and JDK 7 doesn't have the *.html files reported as
> missing in OpenJDK 6.
>
> There are some error messages:
> Error. Can't find HTML file:
> /jck/icedtea6/openjdk/jdk/test/java/awt/Focus/ActualFocusedWindowTest/ActualFocusedWindowBlockingTest.html
> Error. Can't find HTML file:
> /jck/icedtea6/openjdk/jdk/test/java/awt/Focus/ActualFocusedWindowTest/ActualFocusedWindowRetaining.html
> Error. Can't find HTML file:
> /jck/icedtea6/openjdk/jdk/test/java/awt/Focus/NonFocusableWindowTest/NonfocusableOwnerTest.html
>
> May I write the required HTML files or are these files missing due to some
> improper commit?
>
> Cheers
> Pavel
>
>
>
> I think this fix needs to be backported:
>
> changeset:   202:4a6dd11fe9fc
> user:        ant
> date:        Wed Mar 26 17:38:26 2008 +0300
> summary:     6616792: five AWT focus regression tests should be fixed
> http://hg.openjdk.java.net/jdk7/jdk7/jdk/rev/4a6dd11fe9fc
>
> Joe, ok for OpenJDK6?
>
>
> If applying the patch resolves the test failures, I approve it going back
> now.

It syncs the tests with JDK7, removing the HTML file references.

Pushed: http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/4684c385160e

>
> I've been thinking a bit more about the changes to accept for this build.
> Other than the copyright changes (a general message about those coming
> soon), I think it would be helpful to also take back any fixes from JDK 7
> applied to IcedTea but not OpenJDK 6, etc., before the copyright swap
> occurs.
>

I'll take a look next week, though I think most IcedTea patches are in
neither version of OpenJDK at present (most backports have been pushed
upstream).

> -Joe
>



-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8