Request to backport 6438179 (fix XToolkit.isTraySupported)

[Phil Race]

Since it was a long time ago details are not very fresh in my mind but 
6438179
touched spec, implementation and compatibility. I believe both
the spec change portion and the code changes involved a lot of back and 
forth
over several months or maybe longer.

The key questions were how to most compatibly fix the problem that 
system tray
support was equated to a particular window manager and to further enable 
updated
participating applications to be informed when the system tray 
availability status changed.

The referenced patch includes a specification change, adding the new 
property used to
detect if the state of the systemTray has changed. That is not 
appropriate. Even if its
not detected by an extant JCK test, its a spec change which can't be in 6.

I think the part of this where the availability of the tray is 
determined by the system
tray protocol instead of the window manager should be OK.
That part was in fact backported to JDK 1.6 update 10.


-phil.


On 8/9/2010 11:03 AM, Dalibor Topic wrote:
> On 8/9/10 7:53 PM, Dalibor Topic wrote:
>    
>> On 8/9/10 6:17 PM, Omair Majid wrote:
>>      
>>> On 07/06/2010 01:37 PM, Omair Majid wrote:
>>>        
>>>> Hi,
>>>>
>>>> I am interested in backporting the fix for 6438179
>>>> "XToolkit.isTraySupported() result has nothing to do with the system
>>>> tray" from OpenJDK7 to OpenJDK6. This fix implements the System Tray
>>>> Protocol support in OpenJDK.
>>>>
>>>> The fix was implemented in OpenJDK7 in b21 - I can not find a changeset
>>>> version for this fix as this was before the mercurial repositories were
>>>> published. I have tried backporting this fix manually and I am attaching
>>>> the patch.
>>>>
>>>> Does this look like something OK to go into OpenJDK6?
>>>>
>>>>          
>>> Anyone? Any suggestions?
>>>        
>> I'd like to get Phil's opinion on this. Phil, the proposed patch is at
>> http://mail.openjdk.java.net/pipermail/jdk6-dev/attachments/20100706/97c6cf64/attachment-0001.ksh
>> OK to go back into OpenJDK 6?
>>      
> one more time with the correct e-mail address in the CC: ...
>