OpenJDK7 Backports

[Dr Andrew John Hughes]

On 28 July 2010 19:00, Joe Darcy <joe.darcy at oracle.com> wrote:
> Dr Andrew John Hughes wrote:
>>
>> Hi Joe,
>>
>> Can I have permission to backport the following to OpenJDK6:
>>
>> changeset:   1216:f62f7fcc9965
>> parent:      1198:b28b073e72b6
>> user:        art
>> date:        Fri May 15 15:40:35 2009 +0400
>> summary:     6678385: Random java.lang.StackOverflowError from various
>> JDKs
>> http://hg.openjdk.java.net/jdk7/jdk7/jdk/rev/f62f7fcc9965
>>
>> changeset:   159:df5d7e6ac15e
>> user:        xuelei
>> date:        Wed Apr 02 22:44:45 2008 -0400
>> summary:     6668231: Presence of a critical subjectAltName causes
>> JSSE's SunX509 to fail trusted checks
>> http://hg.openjdk.java.net/jdk7/jdk7/jdk/rev/df5d7e6ac15e
>>
>> changeset:   2527:f1bafc4f249d
>> user:        peterz
>> date:        Tue Jun 29 14:42:30 2010 +0400
>> summary:     6963870: NPE in CompoundBorder.getInsets()
>> http://hg.openjdk.java.net/jdk7/jdk7/jdk/rev/f1bafc4f249d
>>
>> Thanks,
>>
>
> Hi Andrew.
>
> I'll have to look into these changes in a bit more detail, but I'm leaning
> toward letting them in.  A quick general comment, with the Sun -> Oracle
> rebranding any new files introduced in OpenJDK 6 should have the current
> copyrights.  Looking at some of the files that would be newly introduced by
> this change, there may be other changesets that should be brought in to get
> the files more up to date, for example
>
> 6854898: Frame is located at the negative coordinates instead of origin for
> Solaris 10 CDE
>
> Thanks,
>
> -Joe
>


Good point.  I had a feeling these copyright changes were going to be
a continuous pain...

Here's a webrev for the first of these:

http://cr.openjdk.java.net/~andrew/6678385/webrev.01/

I agree following this with 6854898 seems appropriate, and I'll have a
look for relevant changesets for the other two when we get to them.

For now, does this look ok to push?

Thanks,
-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8