Request to backport 6438179 (fix XToolkit.isTraySupported)

Dr Andrew John Hughes ahughes at redhat.com
Tue Aug 10 10:44:18 PDT 2010


On 14:33 Tue 10 Aug     , Dalibor Topic wrote:
> On 8/9/10 9:17 PM, Phil Race wrote:
> > The referenced patch includes a specification change, adding the new property used to
> > detect if the state of the systemTray has changed. That is not appropriate. Even if its
> > not detected by an extant JCK test, its a spec change which can't be in 6.
> > 
> > I think the part of this where the availability of the tray is determined by the system
> > tray protocol instead of the window manager should be OK.
> > That part was in fact backported to JDK 1.6 update 10.
> 
> Thank you very much for the background and the quick review, Phil. 
> 
> Omar, would you like to take a shot at backporting just the part where the 
> availability of the tray is determined by the system tray protocol instead 
> of the window manager?
> 
> cheers,
> dalibor topic
> -- 
> <http://www.oracle.com/>
> Dalibor Topic
> Phone: +49 40 23646738
> Oracle
> 
> ORACLE Deutschland B.V. & Co. KG | Nagelsweg 55 | 20097 Hamburg
> 
> ORACLE Deutschland B.V. & Co. KG
> Hauptverwaltung: Riesstr. 25, D-80992 München
> Registergericht: Amtsgericht München, HRA 95603
> 
> Komplementärin: ORACLE Deutschland Verwaltung B.V.
> Rijnzathe 6, 3454PV De Meern, Niederlande
> Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697
> Geschäftsführer: Jürgen Kunz, Marcel van de Molen, Alexander van der Ven
> 
> <http://www.oracle.com/commitment>
> 
> 	
> 
> Oracle is committed to developing practices and products that help protect the environment
> 
> 
> 

Removing the:

+            firePropertyChange(SYSTEM_TRAY_PROPERTY_NAME, null, target);

lines, together with the SYSTEM_TRAY_PROPERTY_NAME variable, the firePropertyChange method
and variable and the additions to the addNotify documentation should be enough, as far as I can see.
-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net
PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint = F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8


More information about the jdk6-dev mailing list