Need reviewers for changes in java/net regression tests
Chris Hegarty
chris.hegarty at oracle.com
Wed Aug 18 02:05:52 PDT 2010
On 18/08/2010 00:41, joe.darcy at oracle.com wrote:
>
>
> On 8/17/2010 6:23 AM, Pavel Tisnovsky wrote:
>> Joe Darcy wrote:
>>
>>> Hello Pavel.
>>>
>>> In principle, I approve this sort of change, but I'd like some
>>> clarifications before granting final approval
>>>
>>> Pavel Tisnovsky wrote:
>>>
>>>> Hi,
>>>>
>>>> I tried to backport more regression tests from OpenJDK7 to OpenJDK6.
>>>> Webrev with changes is available at:
>>>> http://cr.openjdk.java.net/~ptisnovs/JavaNetJTregTests/
>>>>
>>>>
>>> It would be helpful to know what JDK 7 changesets these fixes came from
>>> and what the differences from the JDK 7 changes are in OpenJDK 6.
>>>
>>
>> Hi Joe,
>>
>> many of these fixes came from
>> http://hg.openjdk.java.net/jdk7/tl/jdk/rev/58f325ba3e27
>> which was made by Chris to fixe bug
>> http://bugs.sun.com/view_bug.do?bug_id=6969395
>>
>> Is it possible to push the fixes with this bug ID in case I didn't
>> included all changes because of differences between JDK6 and JDK7?
>>
>
> Yes, if the OpenJDK 6 version of the change is derived from the JDK 7
> version and substantially the same, the same bug id should be used if
> the fix is pushed to OpenJDK 6
Pavel already did a push of some of these test changes, not all. CR
6969395 was used as the bug number and is now already marked as Fixed in
6Open.
http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/13939cd62507
-Chris.
>
> -Joe
More information about the jdk6-dev
mailing list