<AWT Dev> Reviewer needed - fix for regression test java/awt/Insets/WindowWithWarningTest/WindowWithWarningTest

Dr Andrew John Hughes ahughes at redhat.com
Fri Dec 3 06:35:36 PST 2010


On 16:15 Fri 03 Dec     , Anthony Petrov wrote:
> On 12/3/2010 3:49 PM, Dr Andrew John Hughes wrote:
> >> OK, then the test really needs some change, and the proposed fix looks
> >> good to me.
> >>
> >> PS. Although if the enhanced security warning is backported to OpenJDK6,
> >> the test and the fix seem useless. And it's already useless in JDK7.
> >>
> >
> > Ok, well as both you and Joe
> > (http://mail.openjdk.java.net/pipermail/jdk6-dev/2010-December/002143.html)
> > have said that the warning fix is ok to backport, I'll post a webrev
> > for this either today or early next week.
> >
> > Then we can just remove the test from both 6&  7.
> 
> Sounds like a plan. Thank you.
> 
> --
> best regards,
> Anthony

Thanks for making us aware of these fixes!

The patch is heavily reliant on:

6797195: Forward-port enhancements for hw/lw mixing from 6u12 to 7
Reviewed-by: art, dcherepanov
http://hg.openjdk.java.net/jdk7/jdk7/jdk/rev/f36e9200cb85

So is it ok if I bring this one over to OpenJDK6 too?

Thanks,
-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint = F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8


More information about the jdk6-dev mailing list