HotSpot 16 on OpenJDK6 build failure (was hg: jdk6/jdk6/hotspot: 3 new changesets)

[Andrew John Hughes]

On 20 February 2010 16:17, Daniel D. Daugherty <Daniel.Daugherty at sun.com> wrote:
> Andrew John Hughes wrote:
>>
>> 2010/2/17 Andrew John Hughes <gnu_andrew at member.fsf.org>:
>>
>> Can we please have a solution for this?
>
> Actually, I've been working on getting this fix into HSX-16
> even though I'm on a road trip (and on vacation).
>

Ok.  I can't really tell this from my end when there is no response to
my e-mail.

>
>> This changeset is NOT in the
>> hs16 master and is causing the OpenJDK6 build to fail once the hs16
>> master is imported, thus blocking our progress on preparing b19.
>>
>
> I previously said that I pushed this fix to HSX-16.1 which is not
> the same as HSX-16. I never said that this fix is in the HSX-16
> master.
>

Right, now that makes more sense.  I have no idea what HSX-16.1 is, so
I'd assumed that it was shorthand for b01 of hs16 rather than some
other repository we can't see.  The only repositories I'm aware of, in
addition to the OpenJDK6 and 7 ones, are the hsx16 base and master
ones.

>
>> Using hs16 directly with OpenJDK6 works -- we have been doing this for
>> sometime.  As shown by the diff I posted, this conflicting changeset
>> is local to OpenJDK6.
>>
>
> Yup. I thought I was doing the "right thing" by fixing this bug
> in OpenJDK6 also in addition to HSX-16.1 and HSX-17. Now I'm
> starting to wonder why I bother doing things for OpenJDK6 at all.
>

I didn't say it was wrong to put it into OpenJDK6.  I merely wanted to
know how to fix the breakage that occurred when we updated OpenJDK6,
and was confused by what appeared to be a claim from you that the
patch was in the hs16 master when it clearly wasn't.

>
>> Is there a suitable default value for version so that we can
>> reintroduce the JvmtiEnv() constructor that was removed by your
>> changeset?
>>
>
> When I ported the changeset to HSX-16, there was no need for a
> no-args constructor. I previously asked why you needed one and
> I don't see that answer in this e-mail thread. Perhaps I missed
> your reasons.

I don't _need _ one.  I would have thought it was clear from the build
failure I posted in both the initial and last response.that another
part of the code is looking for the old no-args constructor i.e.

>> /home/andrew/projects/openjdk/upstream/jdk6/hotspot/src/share/vm/prims/jvmtiEnvThreadState.cpp
>> /home/andrew/projects/openjdk/upstream/jdk6/hotspot/src/share/vm/prims/jvmtiEnvBase.cpp:126:
>> error: prototype for 'JvmtiEnvBase::JvmtiEnvBase()' does not match any
>> in class 'JvmtiEnvBase'
>> /home/andrew/projects/openjdk/upstream/jdk6/hotspot/src/share/vm/prims/jvmtiEnvBase.hpp:44:
>> error: candidates are: JvmtiEnvBase::JvmtiEnvBase(const JvmtiEnvBase&)
>> /home/andrew/projects/openjdk/upstream/jdk6/hotspot/src/share/vm/prims/jvmtiEnvBase.hpp:95:
>> error:                 JvmtiEnvBase::JvmtiEnvBase(jint)

  Maybe this call was added after the version of hs16 you ported to...
it's still unclear what that version is and whether we actually have
access to it.

>
> I'll be pushing the ported changeset to HSX-16 baseline once I
> get back to Colorado. Right now I'm in New Mexico and expect to
> get home in 9-10 hours depending on the snow...

Ok, I'll be surprised if that builds as that's effectively how it's
being applied to cause this failure -- the patch you made for OpenJDK6
is already there and the repository has been updated to the level of
hs16 master.

>
> Dan
>
>



-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8