HotSpot 16 and OpenJDK6
Joseph D. Darcy
Joe.Darcy at Sun.COM
Tue Feb 23 12:10:08 PST 2010
Hello.
Andrew John Hughes wrote:
> Here's the merge:
>
> http://cr.openjdk.java.net/~andrew/jdk6-hs16-merge/webrev.01/
>
> which now builds, thanks to this additional changeset from Daniel
> Daugherty in baseline:
> http://hg.openjdk.java.net/hsx/hsx16/baseline/rev/c9740f5ed5b4
>
Good.
> It also includes an additional fix, also listed separately at:
>
> http://cr.openjdk.java.net/~andrew/jdk6-hs16-merge/webrev.02/
>
> which reverts an erroneous change from SIZE_FORMAT to %d in
>
> changeset: 734:dbbe28fc66b5
> user: twisti
> date: Fri Feb 27 03:35:40 2009 -0800
> summary: 6778669: Patch from Red Hat -- fixes compilation errors
>
> fixing the build on x86_64. We'll need a bug ID for this reversion.
>
The webrev generally looks good, but I have a few questions and comments
before this goes back.
Do you know why webrev shows so many files with zero changes? I assume
this is an artifact of the merge.
In hotspot_version, what are the semantics of JDK_PREVIOUS_VERSION?
In terms of fixing the %d vs SIZE_FORMAT in vmError.cpp, I've filed
6929005 "Fix format specifier in vmError.cpp." However, I notice that
the JDK 7 master still has %d in this location. I'll approve going back
from %d -> SIZE_FORMAT in OpenJDK 6 conditional on the review and
approval of a HotSpot engineer.
Thanks,
-Joe
More information about the jdk6-dev
mailing list