[Fwd: URGENT code review request for Win* UnhandledExceptionFilter fix (6918421)]

[Joseph D. Darcy]

Daniel D. Daugherty wrote:
> Joe,
>
> I think you might want this one in OpenJDK6...
>
>> changeset:   507:0fc941df6fb7
>> tag:         tip
>> user:        dcubed
>> date:        Tue Feb 02 10:37:32 2010 -0700
>> files:       src/os/windows/vm/os_windows.cpp
>> description:
>> 6918421: 1/1 in-process JVM now ignores preset Windows unhandled 
>> exception filter
>> Summary: Add support for chaining Windows UnhandledExceptionFilter 
>> handlers
>> Reviewed-by: kamg, dholmes, never, acorn, ikrylov
>
> This fix was pushed for JDK7-B83/HSX-17-B09 and JDK6_19-B03
> (in one of those HSX-16.X builds that we don't talk about :-))
>
> Let me know if you want this one in OpenJDK6 also...

Yes; that would be a fine fix to add to OpenJDK 6 -- I approve this 
changeset going back.

Thanks,

-Joe

>
> Dan
>
>
>
> -------- Original Message --------
> Subject:     URGENT code review request for Win* 
> UnhandledExceptionFilter fix (6918421)
> Date:     Mon, 01 Feb 2010 17:31:14 -0700
> From:     Daniel D. Daugherty <Daniel.Daugherty at Sun.COM>
> Reply-To:     Daniel.Daugherty at Sun.COM
> To:     hotspot-runtime-dev at openjdk.java.net, 
> "serviceability-dev at openjdk.java.net" 
> <serviceability-dev at openjdk.java.net>, Ivan Krylov <Ivan.Krylov at Sun.COM>
>
>
>
> Greetings,
>
> I have an urgent code review request for a Win* fix. Basically,
> I'm making a minor tweak to Ivan's original fix for the following
> bug:
>
>   6550813 5/3 Crash because of FPU control word being modified
>               by native code (win32)
>
> Here's the URL for my tweak:
>
>   http://cr.openjdk.java.net/~dcubed/6918421-webrev/0/
>
> The fix passes the customer test attached to 6918421 and
> it passes the test associated with Ivan's fix for 6550813.
>
> I'm targeting this fix for HSX-17-B09; since this is a P1 it
> will be backported to JDK6-UNN...
>
> Thanks, in advance, for any reviews.
>
> Dan
>
>
>