hg: jdk6/jdk6/jdk: 6888709: Change use of -DX=\""Y\"" to -DX='"Y"', consistently for all platforms

[Joseph D. Darcy]

Andrew John Hughes wrote:
> 2010/1/15 Jonathan Gibbons <Jonathan.Gibbons at sun.com>:
>   
>> Kelly O'Hair wrote:
>>     
>>> On 1/15/10 9:26 AM, Andrew John Hughes wrote:
>>>       
>>>> 2010/1/15<kelly.ohair at sun.com>:
>>>>         
>>>>> Changeset: 93c580ce5e88
>>>>> Author:    ohair
>>>>> Date:      2010-01-15 08:41 -0800
>>>>> URL:       http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/93c580ce5e88
>>>>>
>>>>> 6888709: Change use of -DX=\""Y\"" to -DX='"Y"', consistently for all
>>>>> platforms
>>>>> Reviewed-by: tbell, jjg
>>>>>
>>>>> ! make/common/Defs.gmk
>>>>> ! make/common/Program.gmk
>>>>> ! make/java/main/java/Makefile
>>>>> ! make/java/main/javaw/Makefile
>>>>> ! make/javax/sound/Makefile
>>>>> ! make/launchers/Makefile.launcher
>>>>>
>>>>>
>>>>>           
>>>> Again, where was this approved for OpenJDK6?  We're supposed to be
>>>> preparing for a release of b18!
>>>>         
>>> Sorry. Without these changes GNU make 3.81 can't be used on Windows/MKS
>>> systems, I jumped the gun on this push.
>>> I should have checked with Joe first.
>>>
>>> -kto
>>>       
>> Perhaps we need a different way of handling the repo nearer significant
>> milestones, such as forking a separate forest to be used as the build
>> candidate. We can then have tighter controls on who has access to that
>> forest.  In other words, much the same as we try and do for jdk7.
>>
>> -- Jon
>>
>>     
>
> I agree. I've been thinking something along the same lines myself.
>
> I thought the general policy for 6 was that even straight backports
> had to be approved by Joe, but this doesn't seem to be the case.  I
> only saw the earlier OCSP fix due to our nightly Hudson build failing
> to build.
>   

Review requests for OpenJDK 6 should all be sent to 
jdk6-dev at openjdk.java.net.  I'll blog about this in the near future.

Regards,

-Joe