<AWT Dev> Please review changes in regression test /java/awt/TestArea/UsingWithMouse.java (second version of patch)

Artem Ananiev Artem.Ananiev at Sun.COM
Tue Jan 26 03:25:39 PST 2010


Hi, Pavel,

On 1/26/2010 11:31 AM, Pavel Tisnovsky wrote:
> Hi,
>
> please review changes made in regression test
> /java/awt/TestArea/UsingWithMouse.java.
>
> Webrev is available at
> http://cr.openjdk.java.net/~ptisnovs/SelectionAutoscrollTest2/
>
> I've added synchronization of scrolling using method
> SunToolkit.realSync(), it seems to works perfectly on RHEL x86_64 +
> Gnome and Fedora 10 i386 + Gnome. Thanks Anthony Petrov for his tip!

the problem looks really, really strange... Util.waitForIdle() is 
implemented exactly the same way: as a call to realSync() - while you 
wrote that calling waitForIdle() didn't help.

Please, postpone your fix (don't integrate into AWT gate repository) and 
check if Util.waitForIdle() does the job. realSync() is a low-level and 
private Sun's API, so I'd prefer having it in a single place (in Util) 
so we can change it easily, if necessary (e.g. when realSync() becomes 
public).

Thanks,

Artem

> This patch can be applied to OpenJDK7 too.
>
> Thanks in advance
> Pavel Tisnovsky
> Red Hat QA
>
>


More information about the jdk6-dev mailing list