Need reviewers for changes in HttpServer regression tests

Pavel Tisnovsky ptisnovs at redhat.com
Thu Jul 22 09:11:44 PDT 2010


Hi Chris,

> I approve these source changes. The changes effectively take the JDK7 
> versions of these files, right? Obviously, Joe will need to approve the 
> 6Open integration.

Exactly, these changes just synchronizes the tests with JDK7 (which is 
IMHO good because it will be easier to check some future changes in 
JDK6/JDK7 test by using simple diff :-)

> 
> Out of interest, have you seen issues with these tests in 6, or are you 
> just trying to sync up the tests?

No, I have seen only three failures or errors in *net* regression tests:
java/net/InetAddress/CheckJNI.java
java/net/URL/TestHttps.java
java/net/ipv6tests/UdpTest.java

> 
> -Chris.
> 
> Pavel Tisnovsky wrote:
>> Hi,
>>
>> can anyone please review changes made in some HttpServer regression 
>> tests? Webrev is available at:
>> http://cr.openjdk.java.net/~ptisnovs/HttpServerJTregTests/
>>
>> The changes made in these test are really minor and they are based 
>> (but not equal) on changes done by Christopher Hegarthy in OpenJDK7:
>>
>> http://hg.openjdk.java.net/jdk7/tl/jdk/rev/58f325ba3e27
>> (these changes are reviewed by Alan Bateman)
>>
>> Cheers
>> Pavel Tisnovsky
>>
>> PS: I would like to synchronize more "network" tests between OpenJDK6 
>> and OpenJDK6.
>>



More information about the jdk6-dev mailing list