need a code review for a quick test fix (6971847)

Alan Bateman Alan.Bateman at oracle.com
Sat Jul 24 12:14:46 PDT 2010


Daniel D. Daugherty wrote:
> :
> The 'histo:live' check gives me a helpful usage message rather
> than a vague one. I would prefer to keep the check. Would you
> be okay with the fix as is?
I don't have a strong objection to the proposed change but the check 
seems to be only useful to catch the case where someone is running these 
jdk6 or jdk7 tests on jdk5. It was useful that it caught the problem 
with the usage message but I think the simplest fix is to just remove 
lines 55 and 58-65 from both tests.

-Alan.


More information about the jdk6-dev mailing list