Need reviewers for changes in java/net regression tests

Chris Hegarty chris.hegarty at oracle.com
Mon Jul 26 06:13:55 PDT 2010



On 07/26/10 14:00, Dr Andrew John Hughes wrote:
> .......
>
> I'm afraid I don't see the issue with bug IDs here.  Each OpenJDK7
> changeset already has an associated bug ID.  It should thus simply be
> a matter of backporting the relevant changesets and dropping any
> changes from them that should remain 7 only.

Some of the test changes have been made when fixing a bug in the JDK7 
source... Oh, I noticed that the test in this area is not sufficient or 
has issues. Some tests have been fixed as part of a general cleanup to 
remove them from the ProblemList. We don't want to backport all the 
implementation source changes, only test changes that improve the 
quality of the tests. So there is no one to one mapping here.

> It may be more expedient in the short term to do wholesale copying of
> files between trees, rather than using the changesets, but it then
> makes it a lot harder for someone else to determine what has been
> backported and what hasn't, because you can't do a lookup via the bug
> ID.

If it is just improvements in the tests themselves then I don't see any 
problem here. We could have one CR that covers backport of regression 
tests from JDK7. Most of the test we have today in the JDK7 networking 
area should not, we hope, have issues that will need fixed in the 
future, only additional tests/functionality added to cover new bug fixes.

-Chris.


More information about the jdk6-dev mailing list