Need reviewer: jaxp source drop update, a few fixes

[Jonathan Gibbons]

On 06/07/2010 09:33 AM, Kelly O'Hair wrote:
>
> On Jun 7, 2010, at 9:06 AM, Joe Darcy wrote:
>
>> Hi Kelly.
>>
>> Kelly O'Hair wrote:
>>>
>>> Need reviewer, 3 fixes here:
>>>
>>> 6955301: Update names and references to rebranded drop bundles 
>>> (jaxp, jaxws, jaf)
>>> 6940241: Change jaxp/jaxws so that the http downloads are not done 
>>> by default
>>> 6955292: Workaround ant 1.7.1 package-info.java issue in ant scripts
>>>
>>> http://cr.openjdk.java.net/~ohair/openjdk6/jaxp-b20-drop/webrev/ 
>>> <http://cr.openjdk.java.net/%7Eohair/openjdk6/jaxp-b20-drop/webrev/>
>>>
>>> The new jaxp drop file will be:
>>>   
>>> https://jaxp.dev.java.net/files/documents/913/150648/jaxp_src.bundle.name=jdk6-jaxp-b20.zip 
>>>
>>>
>>> On 6940241, by default, the source drop bundle will NOT be 
>>> downloaded unless the ant property
>>>   allow.downloads=true
>>> is defined, so you have to explicitly allow this.
>>>
>>> The env var ALT_DROPS_DIR or ant property drops.dir should refer to 
>>> the directory holding the
>>> downloaded jaxp/jaxws source drop bundles.
>>
>> Before approving this, I want to understand the impact on the build 
>> logistics with 6940241.  In particular, what happens if:
>>
>> * A fresh hg fclone is done and a "make" command is issued from the 
>> root directory?
>
> Same as before, but unless you somehow set allow.downloads=true  it 
> will never reach out via the website for a download.
>
>> * If allow.downloads is made true, do subsequent builds always 
>> download or do they first check for a matching file in the build 
>> directory?
>
> Regardless of the setting, priority is always given to the drops.dir 
> or ALT_DROPS_DIR setting, which defaults to
> /java/devtools/share/jdk6-drops. If it can find a copy on a file 
> system, that is always preferred.
> Only if the file system copy does not exist does it try to download 
> from the website.

This would be a good warning to give up front in "make sanity" if that 
is practical -- i.e. that a web download will be required.

-- Jon

>
> -kto
>
>>
>> -Joe
>