[Fwd: Request for change in JDK6 - proper ISO-8859-15 charset handling]
Andrew John Hughes
ahughes at redhat.com
Wed Jun 9 13:54:48 PDT 2010
On 9 June 2010 17:44, Xueming Shen <xueming.shen at oracle.com> wrote:
>
> The ISO-8859-1 is now being generated from
>
> make/tools/CharsetMapping/ISO_8859_15.map
>
> during build time, as part of the charset re-write "project".
>
> The new implementation of ISO-8859-15 does not take ISO-8859-1 as
> its subset, we then had 6798572 filed and then realized the old
> implementation
> is wrong.
>
Ah, so 6798572 was created for a JDK7 bug but never used until Pavel's
fix in OpenJDK6. Got it.
Just wanted to make sure I wasn't missing a fix.
> sherman
>
> Andrew John Hughes wrote:
>>
>> On 5 May 2010 16:52, Joe Darcy <joe.darcy at oracle.com> wrote:
>>
>>>
>>> Andrew John Hughes wrote:
>>>
>>>>
>>>> On 30 April 2010 18:06, Joe Darcy <joe.darcy at oracle.com> wrote:
>>>>
>>>>
>>>>>
>>>>> Pavel Tisnovsky wrote:
>>>>>
>>>>>
>>>>>>
>>>>>> Hi Xueming,
>>>>>>
>>>>>> may I use bug #6798572 to push changes to OpenJDK6? Only JDK7 is
>>>>>> mentioned
>>>>>> in this bug...
>>>>>>
>>>>>>
>>>>>
>>>>> Per the OpenJDK 6 processes (http://openjdk.java.net/projects/jdk6/),
>>>>> the
>>>>> approval of the release manager (currently me) is also needed for all
>>>>> changes before they go back.
>>>>>
>>>>> Given that Sherman has reviewed the technical contents of the change, I
>>>>> also
>>>>> approve it going back as long as the now-failing regression test
>>>>> java/nio/charset/Charset/Contains.java
>>>>> is updated to include 6798572 in its @bug line.
>>>>>
>>>>>
>>>>>
>>>>
>>>> It seems this change went back but without this addition. Do we still
>>>> want to add it?
>>>>
>>>>
>>>
>>> The bug id was actually there all along!
>>>
>>> -Joe
>>>
>>>
>>
>> If I look at the current jdk7 tree, I can't find this bug ID:
>>
>> $ hg -R ../upstream/jdk7/jdk log -k 6798572
>> $
>>
>> But then there's no ISO-8859-15 file any more. Any ideas?
>>
>
>
Thanks,
--
Andrew :-)
Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)
Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net
PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8
More information about the jdk6-dev
mailing list