Behaviour of VERBOSE=true on langtools build

[Andrew John Hughes]

On 23 February 2010 09:13, Andrew John Hughes <gnu_andrew at member.fsf.org> wrote:
> On 22 February 2010 20:39, Jonathan Gibbons <Jonathan.Gibbons at sun.com> wrote:
>> Andrew John Hughes wrote:
>>>
>>> Enabling VERBOSE=true (presumably) should cause the build to produce
>>> more verbose build output.
>>>
>>> However, on langtools it just causes Ant to print the diagnostics
>>> (which have already been logged beforehand anyway) and not build
>>> langtools at all.
>>>
>>> I'd suggest the following change:
>>>
>>> diff -r bab75805f846 make/Makefile
>>> --- a/make/Makefile     Fri Feb 19 17:14:22 2010 +0000
>>> +++ b/make/Makefile     Mon Feb 22 20:10:44 2010 +0000
>>> @@ -70,7 +70,7 @@
>>>  endif
>>>
>>>  ifdef VERBOSE
>>> -  ANT_OPTIONS += -verbose -diagnostics
>>> +  ANT_OPTIONS += -verbose -debug
>>>  endif
>>>
>>>  ifdef JDK_VERSION
>>>
>>> or just -verbose.
>>>
>>> If this looks ok, can I have a bug ID to push it?
>>>
>>> Thanks,
>>>
>>
>> 6928623: Behaviour of VERBOSE=true on langtools build
>>
>
> Thanks.  Pushed to tl:
> http://hg.openjdk.java.net/jdk7/tl/langtools/rev/f25efdb55c99
> --
> Andrew :-)
>
> Free Java Software Engineer
> Red Hat, Inc. (http://www.redhat.com)
>
> Support Free Java!
> Contribute to GNU Classpath and the OpenJDK
> http://www.gnu.org/software/classpath
> http://openjdk.java.net
>
> PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
> Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8
>

Joe, this fix is needed in 6 too.  Ok to backport?
-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8